Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26014

Make external blog set up URL field more useful

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.3
    • Component/s: Blog, Language
    • Labels:
    • Environment:
      en
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Add an external blog
      2. While adding an external blog, heck to make sure the label of the field now reads as 'RSS feed URL'
      3. After adding the external blog, check the column on the table of existing external blogs now reads as 'RSS feed URL'
      Show
      Add an external blog While adding an external blog, heck to make sure the label of the field now reads as 'RSS feed URL' After adding the external blog, check the column on the table of existing external blogs now reads as 'RSS feed URL'
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-26014-master

      Description

      ...blog/external_blog_edit.php?id=1

      Mandatory field label is "URL". It's the RSS feed URL that is required.

      Suggestion:

      Change label to "RSS feed URL"

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            phalacee Jason Fowler added a comment -

            Changed the label of the field to RSS feed URL.

            Show
            phalacee Jason Fowler added a comment - Changed the label of the field to RSS feed URL.
            Hide
            poltawski Dan Poltawski added a comment -

            Our translators have a real problem keeping up with the number of strings which we introduce so we should try and clean up unused strings.

            So, is the existing 'url' string used anywhere else? If not then lets:

            a) 'Rename' the string identifier
            1) Delete the url string
            2) Do an AMOS mov so that other languages (which may have translated that field better than english) us don't have to retranslate. (
            http://docs.moodle.org/dev/Languages/AMOS#AMOS_script)

            or

            b) Leave the string identifier as it is and just change the string in place

            Show
            poltawski Dan Poltawski added a comment - Our translators have a real problem keeping up with the number of strings which we introduce so we should try and clean up unused strings. So, is the existing 'url' string used anywhere else? If not then lets: a) 'Rename' the string identifier 1) Delete the url string 2) Do an AMOS mov so that other languages (which may have translated that field better than english) us don't have to retranslate. ( http://docs.moodle.org/dev/Languages/AMOS#AMOS_script ) or b) Leave the string identifier as it is and just change the string in place
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            phalacee Jason Fowler added a comment -

            this has been rebased

            Show
            phalacee Jason Fowler added a comment - this has been rebased
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Doing a quick grep for uses, I detected:

            blog/external_blogs.php:    $table->head = array(get_string('name'), get_string('url'),......

            Perhaps that 'url' string should be also the 'blog' one and not the core one?

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Doing a quick grep for uses, I detected: blog/external_blogs.php: $table->head = array(get_string('name'), get_string('url'),...... Perhaps that 'url' string should be also the 'blog' one and not the core one? Ciao
            Hide
            phalacee Jason Fowler added a comment -

            all sorted now Eloy, thanks for noticing this.

            Show
            phalacee Jason Fowler added a comment - all sorted now Eloy, thanks for noticing this.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master), thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passed. Both the "edit external blog" page and the "list of external blogs" one show the proper "RSS feed URL" string.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passed. Both the "edit external blog" page and the "list of external blogs" one show the proper "RSS feed URL" string.
            Hide
            phalacee Jason Fowler added a comment -

            Thanks Eloy!

            Show
            phalacee Jason Fowler added a comment - Thanks Eloy!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This has been near becoming rejected, because it's not the best code you are able to produce.

            But, luckily, at the end, it has landed and has been spread to all repos out there.

            Many thanks and, don't forget it, keep improving your skills, you can!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12