Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23754 Performance improvements META
  3. MDL-26028

X-Sendfile and ETag support

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.2.11, 2.3
    • Fix Version/s: 2.3
    • Component/s: Files API
    • Labels:
      None
    • Testing Instructions:
      Hide

      ETag testing - upload file to forum

      1/ diagnose http headers sent with the image - 304 expected on subsequent page loads (previously it was sending the whole file repeatedly)

      2/ verify that forum attachments are force downloaded, they should never open directly in browser

      —

      X-Sendfile testing
      1/ install X-Sendile extension into apache (https://tn123.org/mod_xsendfile/)
      2/ enable X-Sendfile and whitelist dataroot directory
      3/ verify you can view forum attachments, download grades in XML format and bulk export users to Excel

      —

      4/ Turn off X-Sendfile

      5/ verify you can view forum attachments, download grades in XML format and bulk export users to Excel

      6/ try some SCORM packages with and without X-Sendfile enabled

      Show
      ETag testing - upload file to forum 1/ diagnose http headers sent with the image - 304 expected on subsequent page loads (previously it was sending the whole file repeatedly) 2/ verify that forum attachments are force downloaded, they should never open directly in browser — X-Sendfile testing 1/ install X-Sendile extension into apache ( https://tn123.org/mod_xsendfile/ ) 2/ enable X-Sendfile and whitelist dataroot directory 3/ verify you can view forum attachments, download grades in XML format and bulk export users to Excel — 4/ Turn off X-Sendfile 5/ verify you can view forum attachments, download grades in XML format and bulk export users to Excel 6/ try some SCORM packages with and without X-Sendfile enabled
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w18_MDL-26028_m23_xsendfile
    • Pull Master Diff URL:
    • Documentation link:

      Description

      Add support for X-Sendfile. Related forum discussion: http://moodle.org/mod/forum/discuss.php?d=165470

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29298 Downloads failing in moodle 2.1

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-20042 Problem with browser cache and resource download - solve with Etags?

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45906 image.php sends content-length when it shouldn't, loading stalls with mod_deflate

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              tmuras Tomasz Muras
              Integrator:
              Sam Hemelryk
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              6 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12