Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26035

add new upgrade/install test that stops everything if invalid plugin detected

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      1/ the dir name can not contain ".-", in case of module it must not contain "_"
      2/ the dir name should match the language file name
      3/ there should not be old style en_utf8 dir
      4/ there should not be the postgresql.sql and mysql.sql files
      5/ the version number if present must be above 2010000 (already there)
      6/ all letters in dir name must be lowercase

      I have witnessed many false alarms from people that named the book folder incorrectly, the worst part is if the tables are created from the wrong plugin, then you can not install the new plugin any more.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            Workaround is to start with fresh installation or manually fix the table problems.

            Show
            skodak Petr Skoda added a comment - Workaround is to start with fresh installation or manually fix the table problems.
            Hide
            timhunt Tim Hunt added a comment -

            Petr, I though almost all plugin types were not allowed _ in the name. I think you should only allow _ in plugin types where it has been allowed in the past.

            Show
            timhunt Tim Hunt added a comment - Petr, I though almost all plugin types were not allowed _ in the name. I think you should only allow _ in plugin types where it has been allowed in the past.
            Hide
            skodak Petr Skoda added a comment -

            the '_' is strictly forbidden only in '/mod/', we can not change the rules now because it is technically not possible to migrate plugins to new names while keeping all data

            Show
            skodak Petr Skoda added a comment - the '_' is strictly forbidden only in '/mod/', we can not change the rules now because it is technically not possible to migrate plugins to new names while keeping all data
            Hide
            mudrd8mz David Mudrak added a comment -

            Tested. Thanks Petr.

            Show
            mudrd8mz David Mudrak added a comment - Tested. Thanks Petr.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Feb/11