Moodle
  1. Moodle
  2. MDL-26036

Save All My Feedback button not working Internet Explorer 8.0

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.1
    • Fix Version/s: STABLE backlog
    • Component/s: Gradebook
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      When you click on the Save All My Feedback button on the Activity grading page, nothing happens. Works in Safari and Firefox but not in Internet Explorer 8.0. Role change has no affect. Other buttons all work as they should and Update screen submit works but that involves an extra step for each student.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Marshall added a comment -

            This isn't related to the activity completion feature, so removing that from the list.

            Show
            Sam Marshall added a comment - This isn't related to the activity completion feature, so removing that from the list.
            Hide
            Neil Mastroianni added a comment -

            I have also had this problem while using Google Chrome. Really hoping for a fix as our school doesn't allow firefox to be installed on their workstations.

            Show
            Neil Mastroianni added a comment - I have also had this problem while using Google Chrome. Really hoping for a fix as our school doesn't allow firefox to be installed on their workstations.
            Hide
            Charles Fulton added a comment -

            I couldn't reproduce this in either IE 8.0 or Chrome (9.0.597.84). Currently running Moodle 2.0.1+ (Build: 20110204).

            Show
            Charles Fulton added a comment - I couldn't reproduce this in either IE 8.0 or Chrome (9.0.597.84). Currently running Moodle 2.0.1+ (Build: 20110204).
            Hide
            Emma Richardson added a comment -

            Still not working. I recently upgraded to version 2.0.01 (Build:20110125). Did not install latest emergency release as it is not affecting my site as yet. Not sure how to send you a screen shot of it not working! I am wondering if this is because I upgraded from 1.9. I have a clean test site that I installed from scratch that I will test tomorrow and let you know.

            Show
            Emma Richardson added a comment - Still not working. I recently upgraded to version 2.0.01 (Build:20110125). Did not install latest emergency release as it is not affecting my site as yet. Not sure how to send you a screen shot of it not working! I am wondering if this is because I upgraded from 1.9. I have a clean test site that I installed from scratch that I will test tomorrow and let you know.
            Hide
            Sam Marshall added a comment -

            Sorry, it appears this bug was for some reason assigned to me. Reassigning to automatic assignee, hopefully they will look at it.

            Show
            Sam Marshall added a comment - Sorry, it appears this bug was for some reason assigned to me. Reassigning to automatic assignee, hopefully they will look at it.
            Hide
            Emma Richardson added a comment -

            Update - I tested this on a fresh install from scratch install of Moodle 2.0 (Build 20110204). Still not working. I am using the Offline Activity to test this.

            Show
            Emma Richardson added a comment - Update - I tested this on a fresh install from scratch install of Moodle 2.0 (Build 20110204). Still not working. I am using the Offline Activity to test this.
            Hide
            Charles Fulton added a comment -

            Hi Emma, I'm sorry but I still can't reproduce this. Here's what I did:
            1. Created a new course.
            2. Enrolled 12 students in the course.
            3. Created a new offline activity.
            4. Went into the grading interface and selected the activity.
            5. Turned on quick grading.
            6. Left comments and grades for all the students and clicked "Save all my feedback."

            In both Chrome and IE8 the feedback saved with no errors. I haven't customized this Moodle site with any themes or anything like that.

            Show
            Charles Fulton added a comment - Hi Emma, I'm sorry but I still can't reproduce this. Here's what I did: 1. Created a new course. 2. Enrolled 12 students in the course. 3. Created a new offline activity. 4. Went into the grading interface and selected the activity. 5. Turned on quick grading. 6. Left comments and grades for all the students and clicked "Save all my feedback." In both Chrome and IE8 the feedback saved with no errors. I haven't customized this Moodle site with any themes or anything like that.
            Hide
            Emma Richardson added a comment -

            I don't get it. I tried it with a few different themes and now two different sites. I went back to Standard theme. No difference. I am running this in a Linux server - not sure how that might affect it. Click on save all my feedback and it acts like it is being clicked (color change on hover, animation on click) but then it doesn't even try to reload - it is as though there is just no script attached to the button. I would think that I had played with some file that had affected it or have a DB error if I wasn't having the exact same issue on a brand new site. It is not my computer because it was a teacher in another state that first noticed the problem. Would the source code for the page help? I have been looking at it and don't see any obvious errors but I might be missing something.

            Show
            Emma Richardson added a comment - I don't get it. I tried it with a few different themes and now two different sites. I went back to Standard theme. No difference. I am running this in a Linux server - not sure how that might affect it. Click on save all my feedback and it acts like it is being clicked (color change on hover, animation on click) but then it doesn't even try to reload - it is as though there is just no script attached to the button. I would think that I had played with some file that had affected it or have a DB error if I wasn't having the exact same issue on a brand new site. It is not my computer because it was a teacher in another state that first noticed the problem. Would the source code for the page help? I have been looking at it and don't see any obvious errors but I might be missing something.
            Hide
            Greg Wright added a comment -

            We're having the same problem as well. Quick grading doesn't work with IE8 or Chrome. We're using Moodle 2.0.1+ (Build: 20110125). You click the button and nothing happens. It works fine with FF. I didn't try Safari.

            We're running on CentOS 5.4 64bit, php 5.2.8, mysql 5.0.25

            Show
            Greg Wright added a comment - We're having the same problem as well. Quick grading doesn't work with IE8 or Chrome. We're using Moodle 2.0.1+ (Build: 20110125). You click the button and nothing happens. It works fine with FF. I didn't try Safari. We're running on CentOS 5.4 64bit, php 5.2.8, mysql 5.0.25
            Hide
            Richard Klein added a comment -

            Hi,
            My apologies, I couldn't find this bug when I looked earlier. I think I've solved the problem, there is a patch attached to the duplicate bug that Charles has linked (MDL-26430)

            It's all to do with HTML forms breaking eachother:

            (FORM for whole page)
            .... stuff....
            ..... (FORM for groups selection
            ............stuff....
            ......(/FORM)
            ...... "Save All My Feedback" button
            (/FORM)

            Thats the basic outline of how the page is currently coded, the problem is that some of the browsers are taking the first (/FORM) and using it for the outter one. The change I figured out in the duplicate essentially changes things to this:
            (FORM for groups selection
            .....stuff....
            (/FORM)
            (FORM for whole page)
            .... stuff....
            ...... "Save All My Feedback" button
            (/FORM)

            That solves the issue. All that the diff.patch file does in the other bug, is move the start of the "whole page form" down.
            The issue doesn't happen when the thing rendering the group selector isnt there or doesnt create a form that breaks the other one - ie. if groups are off, or only 1 group (I think).

            Show
            Richard Klein added a comment - Hi, My apologies, I couldn't find this bug when I looked earlier. I think I've solved the problem, there is a patch attached to the duplicate bug that Charles has linked ( MDL-26430 ) It's all to do with HTML forms breaking eachother: (FORM for whole page) .... stuff.... ..... (FORM for groups selection ............stuff.... ......(/FORM) ...... "Save All My Feedback" button (/FORM) Thats the basic outline of how the page is currently coded, the problem is that some of the browsers are taking the first (/FORM) and using it for the outter one. The change I figured out in the duplicate essentially changes things to this: (FORM for groups selection .....stuff.... (/FORM) (FORM for whole page) .... stuff.... ...... "Save All My Feedback" button (/FORM) That solves the issue. All that the diff.patch file does in the other bug, is move the start of the "whole page form" down. The issue doesn't happen when the thing rendering the group selector isnt there or doesnt create a form that breaks the other one - ie. if groups are off, or only 1 group (I think).
            Hide
            Orestes Mas added a comment -

            I'm having the same problem with Firefox 4.0.1 on Ubuntu Linux

            Show
            Orestes Mas added a comment - I'm having the same problem with Firefox 4.0.1 on Ubuntu Linux
            Hide
            Andrew Davis added a comment -

            This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            Andrew Davis added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: