Moodle
  1. Moodle
  2. MDL-26098

Manual grading pop-up is confused between id and uniqueid

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Questions, Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16080

      Description

      The links to the popup put uniqueid in the URL, but the popup itself treats it (mostly) as id.

        Activity

        Tim Hunt created issue -
        Hide
        Tim Hunt added a comment -

        How to test:

        To test this, you need to force quiz_attempts.id and question_attempts.id to be out of step. In most Moodle installs, they are always the same, but there is no reason why this should be the case. The fact that they are normally the same tends to mask bugs.

        So, before testing, use phpMyAdmin or something to just insert a row into the question_attempts table.

        Then, you need to test:

        1. Log in as a student and attempt an adaptive mode quiz. For at least one question, take several tries to get it right.

        2. Log in as a teacher and review. Find the question with multiple tries, and in the history of responses table under the question, click on the step numbers for some earlier steps to open the question in that state in a pop-up.

        3. Also as teacher, use the Make comment and override grade link to manually grade the question.

        Those are the bits I actually changed. You should probably also test some other aspects of the quiz, like the manual grading report, and reviewing a question by clicking on its score in the quiz reports. Also, if you are brave, try re-grading.

        The 'close window' button code was broken and I fixed it along the way. Try to find some other places that have a popup with a Close window button, and make sure they work.

        Show
        Tim Hunt added a comment - How to test: To test this, you need to force quiz_attempts.id and question_attempts.id to be out of step. In most Moodle installs, they are always the same, but there is no reason why this should be the case. The fact that they are normally the same tends to mask bugs. So, before testing, use phpMyAdmin or something to just insert a row into the question_attempts table. Then, you need to test: 1. Log in as a student and attempt an adaptive mode quiz. For at least one question, take several tries to get it right. 2. Log in as a teacher and review. Find the question with multiple tries, and in the history of responses table under the question, click on the step numbers for some earlier steps to open the question in that state in a pop-up. 3. Also as teacher, use the Make comment and override grade link to manually grade the question. Those are the bits I actually changed. You should probably also test some other aspects of the quiz, like the manual grading report, and reviewing a question by clicking on its score in the quiz reports. Also, if you are brave, try re-grading. The 'close window' button code was broken and I fixed it along the way. Try to find some other places that have a popup with a Close window button, and make sure they work.
        Tim Hunt made changes -
        Field Original Value New Value
        Status Open [ 1 ] Ready for review [ 10010 ]
        Resolution Fixed [ 1 ]
        Tim Hunt made changes -
        Link This issue will be resolved by PULL-183 [ PULL-183 ]
        Hide
        Mat Dolton added a comment -

        Urm I am really sorry, but I have no idea what you are talking about using phpMyAdmin and inserting the row into the table. Any suggestions for a newbie?
        Thanks in advance
        Mat

        Show
        Mat Dolton added a comment - Urm I am really sorry, but I have no idea what you are talking about using phpMyAdmin and inserting the row into the table. Any suggestions for a newbie? Thanks in advance Mat
        Hide
        Tim Hunt added a comment -

        Mat, are you a tester trying to test this? You only need to understand that if you are. If not, ignore it.

        Show
        Tim Hunt added a comment - Mat, are you a tester trying to test this? You only need to understand that if you are. If not, ignore it.
        Petr Škoda made changes -
        Status Ready for review [ 10010 ] Closed [ 6 ]
        Hide
        Mat Dolton added a comment -

        Ah no sorry mate... will step back and leave it to you guys. My bad

        Show
        Mat Dolton added a comment - Ah no sorry mate... will step back and leave it to you guys. My bad
        Hide
        Tim Hunt added a comment -

        No worries.

        Show
        Tim Hunt added a comment - No worries.
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 67196 ] MDL Full Workflow [ 95986 ]

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: