Moodle
  1. Moodle
  2. MDL-26109

Add docks option to all standard blocks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Blocks
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16094

      Description

      Some standard blocks don't offer docks option. All standard blocks should get an option to add them to the docks if the theme offers the functionality.

      Please check all standard blocks for missing docks feature and the functionality.

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        Added Martin & Sam H as watchers, kept stable backlog as target. Lowered priority from Blocker down to Major (doesn't cause breakage nor data loss).

        Martin, Sam, feel free to evaluate it and re-prioritize this.

        Thanks for the report, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Added Martin & Sam H as watchers, kept stable backlog as target. Lowered priority from Blocker down to Major (doesn't cause breakage nor data loss). Martin, Sam, feel free to evaluate it and re-prioritize this. Thanks for the report, ciao
        Hide
        Aparup Banerjee added a comment -

        blocks with no docks:

        • standard theme
        • Admin bookmarks , Blog Tags, Course Complete Status, Course/Site description block, Feedback, Global search, (new HTML block), (new Mentees block), Self completion
        • Random glossary entry block -> had no docking but later did after i saved settings.
        Show
        Aparup Banerjee added a comment - blocks with no docks: standard theme Admin bookmarks , Blog Tags, Course Complete Status, Course/Site description block, Feedback, Global search, (new HTML block), (new Mentees block), Self completion Random glossary entry block -> had no docking but later did after i saved settings.
        Hide
        Aparup Banerjee added a comment -

        it seemed that the empty blocks weren't getting the docking option
        so does this make sense? => https://github.com/nebgor/moodle/compare/mistress...MDL-26109

        Show
        Aparup Banerjee added a comment - it seemed that the empty blocks weren't getting the docking option so does this make sense? => https://github.com/nebgor/moodle/compare/mistress...MDL-26109
        Hide
        Ralf Hilgenstock added a comment -

        Aparup

        what do you mean with empty blocks. Html block makes sense for me,because itcan be used very differently.

        Show
        Ralf Hilgenstock added a comment - Aparup what do you mean with empty blocks. Html block makes sense for me,because itcan be used very differently.
        Hide
        Aparup Banerjee added a comment -

        Hi Ralf, i put all the blocks onto my course in editing mode and it seemed that the blocks which don't have any html content don't come up with the docking option. (this might have been due to optimizing the js to run on non-empty blocks, my tweak in my repo above takes care of that but it needs further testing)

        Show
        Aparup Banerjee added a comment - Hi Ralf, i put all the blocks onto my course in editing mode and it seemed that the blocks which don't have any html content don't come up with the docking option. (this might have been due to optimizing the js to run on non-empty blocks, my tweak in my repo above takes care of that but it needs further testing)
        Hide
        Aparup Banerjee added a comment -

        request PULL-307 created.

        Show
        Aparup Banerjee added a comment - request PULL-307 created.
        Hide
        Helen Foster added a comment -

        Ralf, thanks for your report and Apu, thanks for fixing it.

        Show
        Helen Foster added a comment - Ralf, thanks for your report and Apu, thanks for fixing it.

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: