Moodle™ is a registered trademark.
Site policy | Contact
Method print_collapsible_region() does not pass its $default param to print_collapsible_region_start
Also discovered that this same method defaults $userpref = '' when it should be $userpref = false in the method definition. Otherwise, print_collapsible_region_start() thinks the $userpref is a valid string and tries to use it.
I was going to take a stab at this issue as my first patch for Moodle. I see that replacing 'true' with $default will change the default value that print_collapsible_region_start() gets sent (because it comes in as 'false' from print_collabsible_region).
Should we change the default param in print_collapsible_region() from $default = false to $default = true in order to maintain the previous default value in _start?
This is my first attempt and creating a new branch, pushing it back to my fork on github and submitting it as a possible resolution. Suggestions for my process of patching to github and for the actual patch are welcomed!
My original changes do not alter the default value for the $default param in print_collapsible_region. This maintains expected behavior for print_collapsible_region but alters expected behavior of print_collapsible_region_start. Commit is here:
To maintain the expected behavior of print_collapsible_region_start() rather than its wrapper function, I changed $default = false to $default = true in this commit:
dix should be available in the next weekly build, thanks a lot for the report and the patches!
I came. I tested. I closed.