Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26220

$PAGE->set_pagelayout should give developer warning when it is ignoring it

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.1
    • Fix Version/s: None
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      In pagelib.php in function set_pagelayout, there is debugging information which is extremely helpful to developers - otherwise if you call the function and it doesn't work, you never find out why.

      Unfortunately the debugging information has been commented out. Is there a good reason for this, or would be it be possible to uncomment it?

      Note: It would be even more helpful if the text also added 'Note: Constructing a Moodle form will set the page layout. Try moving this set call before any form constructor.'

      Sam, assigning to you because I think this is your area; if you think this is a good change but you don't have time for it, I'm happy to make a patch and submit a PULL request, so assign back to me in that case.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              quen Sam Marshall
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: