Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.1
-
Fix Version/s: 2.2
-
Component/s: Themes
-
Environment:Firefox 3.6.13 for Ubuntu 10.10.
Chrome 8.0.552.237 for Ubuntu 10.10 (but without rounded corners, which I thought was odd).
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
The default Anomaly theme as installed with 2.0.1 has some visual inconsistencies when used with forum posts. Please see attached images:
anomaly.png: a screenshot-snippet of a forum post with the default Anomaly theme and Moodle 2.0.1.
anomaly-suggested.png: Due to low contrast of colours in first image, I have highlighted the 'block' of colour and squiggled where the colour is missing.
anomaly-mockup.png: What I believe it should look like (mocked up in GIMP, not patched).
Gliffy Diagrams
Activity
Hi Mary,
I've sending this back presently.
By adding overflow:hidden on #page you break the theme's ability to overflow horizontally which is important for the report layouts.
It pays to be very careful with using overflow:hidden on the main content area or any of its parents as you run into these sort of troubles.
Cheers
Sam
Hi Sam,
Just read your message!
Am I too late to reverse this?
I've just committed the change in general.css in MDL-26240 just this minute!
Please say it can go thru with the change?
I have so much more to add to this theme but wanted this cleaning up first!!!
Cheers
Mary
In deleting old merged branches I deleted this in error! 
Let's hope I have the original files on my computer!
@Sam
I spent 3 hours last night trying to resolve conflicts while re-basing and ended up with a diverging origin/master...which is now in my recycle bin!
I'm now re-building my Moodle-GIT and working on MDL-26240 ready for submitting today. 
Cheers
Mary
As well as restyling the forumpost left column I also restyled the docking tabs to fit in with the theme colors
Hi Mary, I've just been clearing my Email's.
This issue is on my list for today
Hi Mary,
I've just had a look at this again, its VERY close now.
Unfortunately there is a nasty bug with the dock.
A quick glance suggests you should remove the following:
body.has_dock #page {
|
width: 97%;
|
right: 3%;
|
}
|
and instead add:
body.has_dock {
|
margin:0;
|
}
|
I thought about integrating that as a solution but I think it is best if you have a look and think about it, I may have misinterpreted what you were aiming for.
Either way seems to be easily to reproduce the bug just by docking a block using Chrome.
Cheers
Sam
Sam,
Can you fix this when integrating? If so do it. I did not notice it in resolution 1024 x 768 as I had my screen. Now swapping to Chrome and 1400 x 1050 I can certainly see the BUG...thanks for that.
Mary
Thanks Mary - I made those changes in a commit afterward the integration so all fixed up and in
This looks good.
Test passed.
The master fixes corresponding to this issue have been sent upstream. Fixes for other branches (19, 20, 21 stable) will be sent in the very-next days.
Thanks for the hard work! Closing, ciao
Setting a fix version of STABLE backlog as part of our triaging process.