Moodle

When editing an event in the calendar block the number of events in the "repeat series" is always set to 1

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.8, 2.1.5, 2.2.2, 2.3
  • Fix Version/s: 2.1.6, 2.2.3
  • Component/s: Calendar
  • Environment:
    N/A
  • Testing Instructions:
    Hide

    1. Create a new course event.
    2. Check the "Repeat this event" checkbox.
    3. Set a number of repeats greater than 1.
    4. Save the event.
    5. Go back and edit the event. Under "Repeated events", the text will read "Apply changes to all 1 events in this repeat series", not the number of events.

    Show
    1. Create a new course event. 2. Check the "Repeat this event" checkbox. 3. Set a number of repeats greater than 1. 4. Save the event. 5. Go back and edit the event. Under "Repeated events", the text will read "Apply changes to all 1 events in this repeat series", not the number of events.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-26243-master
  • Pull Master Diff URL:

Description

The calender block sets the local variable $repeatedevents to show how many events are in the "repeat series". However, $repeatevents gets the result from a boolean test, so it's always 1 or 0 (and in the latter case won't display everything, which is fine). The linked patch displays the correct number. This is a display issue only.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31338 When editing repeated calendar events, the wrong number of repeats is shown

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Fulton added a comment -

Updated affected versions. Still patches cleanly against master.

Show
Charles Fulton added a comment - Updated affected versions. Still patches cleanly against master.
Hide
Permalink
Dan Poltawski added a comment -

Hi Charles,

The change looks good - but should we be either changing the language string or adding on to the value as when I add an event with 3 repeat events in total it now says:
'Apply changes to all 2 events in this repeat series'

Show
Dan Poltawski added a comment - Hi Charles, The change looks good - but should we be either changing the language string or adding on to the value as when I add an event with 3 repeat events in total it now says: 'Apply changes to all 2 events in this repeat series'
Hide
Permalink
Charles Fulton added a comment -

I've updated the string and refactored the form to include a radio select. I think this makes it clearer to the user what's actually going on.

Show
Charles Fulton added a comment - I've updated the string and refactored the form to include a radio select. I think this makes it clearer to the user what's actually going on.
Hide
Permalink
Dan Poltawski added a comment -

looks good

Show
Dan Poltawski added a comment - looks good
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Some hours ago...

the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (21, 22 & master), thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Tested under 22 and master with events having and not having repetitions, editing only current or all. Everything seems to work. So passing!

Show
Eloy Lafuente (stronk7) added a comment - Tested under 22 and master with events having and not having repetitions, editing only current or all. Everything seems to work. So passing!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

FCT (fixed, closing, thanks). Ciao

"I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
~ Benjamin Disraeli

Show
Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

People

Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: