Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.2
    • Component/s: Navigation
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16508

      Description

      We need to standardise the use of the cm_info class.
      Currently navigation when loading for an activity will use a cm_info object for standard requests but uses a standard stdClass cm for AJAX requests.
      I need to refactor the use of the stdClass cm object to get a cm_info object instead.

      Cheers
      Sam

        Activity

        Hide
        Sam Hemelryk added a comment -

        Hi Andrew,
        I've just pushed a patch for this can you please peer-review it: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-26266

        Show
        Sam Hemelryk added a comment - Hi Andrew, I've just pushed a patch for this can you please peer-review it: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-26266
        Hide
        Andrew Davis added a comment -

        Looks fine although I'm unsure why it includes an alteration to the version number.

        Show
        Andrew Davis added a comment - Looks fine although I'm unsure why it includes an alteration to the version number.
        Hide
        Sam Hemelryk added a comment -

        Created PULL-240

        Show
        Sam Hemelryk added a comment - Created PULL-240

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: