Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26272

Recent changes in modinfo caused some regressions

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.0.1
    • 2.0.2
    • Libraries, Ratings
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE
    • Moderate

    Description

      Recent changes in modinfo (MDL-25981) have caused the $cm objects to stop providing $cm->context.

      It breaks at least all the places were ratings are used because they rely on that:

      mod/data/view.php: $ratingoptions->context = $cm->context;
      mod/forum/lib.php: $ratingoptions->context = $cm->context;
      mod/glossary/view.php: $ratingoptions->context = $cm->context;

      There are also some other uses (12) of:

      $PAGE->cm->context

      But they continue working so we can keep them unmodified for now.

      Going to fix the 3 broken places NOW, hopefully there aren't more places.

      Ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                21/Feb/11