Moodle
  1. Moodle
  2. MDL-26285

Enable RSS feeds setting is not working as expected

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: RSS
    • Labels:
      None
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1/ Set enablerssfeeds to disabled
      2/ Try and add an rss feed to the rss block

      expected result:
      RSS Consumption still enabled when enablerssfeeds is set

      actual result:
      RSS consumption is disabled as well as generation

      Show
      1/ Set enablerssfeeds to disabled 2/ Try and add an rss feed to the rss block expected result: RSS Consumption still enabled when enablerssfeeds is set actual result: RSS consumption is disabled as well as generation
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      15835

      Description

      By default incoming RSS feeds are disabled.
      To enable them one must enable OUTGOING feeds. Advanced features.

      Many sites do not want outgoing feeds but want to take advantage of incoming feeds.
      The functionality is changed from pre-2.0 for no apparent reason and no additional benefit.

        Activity

        Hide
        Dan Poltawski added a comment -

        Yeah, Agreed.

        Show
        Dan Poltawski added a comment - Yeah, Agreed.
        Hide
        Dan Poltawski added a comment -

        Not tested if any other areas than the RSS block are affected by this. (e.g. blog rss import).

        But fixing it in RSS block should be fairl trivial as

        diff --git a/blocks/rss_client/block_rss_client.php b/blocks/rss_client/block_rs
        index 21eb44f..11bec78 100644
        --- a/blocks/rss_client/block_rss_client.php
        +++ b/blocks/rss_client/block_rss_client.php
        @@ -55,14 +55,6 @@
                     return $this->content;
                 }
         
        -        if (!$CFG->enablerssfeeds) {
        -            $this->content->text = '';
        -            if ($this->page->user_is_editing()) {
        -                $this->content->text = get_string('disabledrssfeeds', 'block_rs
        -            }
        -            return $this->content;
        -        }
        -
                 // initalise block content object
                 $this->content = new stdClass;
                 $this->content->text   = '';
        
        Show
        Dan Poltawski added a comment - Not tested if any other areas than the RSS block are affected by this. (e.g. blog rss import). But fixing it in RSS block should be fairl trivial as diff --git a/blocks/rss_client/block_rss_client.php b/blocks/rss_client/block_rs index 21eb44f..11bec78 100644 --- a/blocks/rss_client/block_rss_client.php +++ b/blocks/rss_client/block_rss_client.php @@ -55,14 +55,6 @@ return $ this ->content; } - if (!$CFG->enablerssfeeds) { - $ this ->content->text = ''; - if ($ this ->page->user_is_editing()) { - $ this ->content->text = get_string('disabledrssfeeds', 'block_rs - } - return $ this ->content; - } - // initalise block content object $ this ->content = new stdClass; $ this ->content->text = '';
        Hide
        Ray Lawrence added a comment -

        Edit typo in subject

        Show
        Ray Lawrence added a comment - Edit typo in subject
        Hide
        Ray Lawrence added a comment -

        Who looks after this area Dan? I'll add them a watcher.

        Show
        Ray Lawrence added a comment - Who looks after this area Dan? I'll add them a watcher.
        Hide
        Dan Poltawski added a comment -

        Hi Ray,

        Sorry its me, been a bit busy recently and unresponsive on this, sorry.

        Show
        Dan Poltawski added a comment - Hi Ray, Sorry its me, been a bit busy recently and unresponsive on this, sorry.
        Hide
        Ray Lawrence added a comment -

        Np, I know the feeling.

        Show
        Ray Lawrence added a comment - Np, I know the feeling.
        Hide
        Dan Poltawski added a comment -

        Sorry Ray. Submitting the integration request now.

        To be clear, I am absolutely in agreement that is a regression from Moodle 1.9:

        • In 1.9 that setting was used to control the output of feeds, not for the consumption with the block.
        • In 1.9 you could disable RSS feed generation, whilst allow consumption (I don't think this is true in 2.0.x or 2.1.x with this bug present)
        • It is possible to disable the consumption of RSS feeds by disabling the block
        Show
        Dan Poltawski added a comment - Sorry Ray. Submitting the integration request now. To be clear, I am absolutely in agreement that is a regression from Moodle 1.9: In 1.9 that setting was used to control the output of feeds, not for the consumption with the block. In 1.9 you could disable RSS feed generation, whilst allow consumption (I don't think this is true in 2.0.x or 2.1.x with this bug present) It is possible to disable the consumption of RSS feeds by disabling the block
        Hide
        Dan Poltawski added a comment -

        Integrators: this patch can be cherry-picked cleanly into 20_STABLE and 21_STABLE

        thanks,
        dan

        Show
        Dan Poltawski added a comment - Integrators: this patch can be cherry-picked cleanly into 20_STABLE and 21_STABLE thanks, dan
        Hide
        Ray Lawrence added a comment -

        Thanks Dan. I read your post from 4:16, not sure what the patch does. Does it give proper independent control of consumption and out put of feeds?

        Show
        Ray Lawrence added a comment - Thanks Dan. I read your post from 4:16, not sure what the patch does. Does it give proper independent control of consumption and out put of feeds?
        Hide
        Dan Poltawski added a comment -

        Ray: It just removes the ability for that setting to affect the RSS block (like 1.9)

        Show
        Dan Poltawski added a comment - Ray: It just removes the ability for that setting to affect the RSS block (like 1.9)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Oh, my. Yes, I think this is one regression introduced into 2.x series by miss-interpretation @ MDL-20565 (b58961ac).

        So the best is to revert it, agree.

        Thanks and ciao

        PS: Ralf, I think the comment does not say that. Only 1 setting for controlling generation of feeds available. Incoming feeds will be stopped by disabling the block.

        Show
        Eloy Lafuente (stronk7) added a comment - Oh, my. Yes, I think this is one regression introduced into 2.x series by miss-interpretation @ MDL-20565 (b58961ac). So the best is to revert it, agree. Thanks and ciao PS: Ralf, I think the comment does not say that. Only 1 setting for controlling generation of feeds available. Incoming feeds will be stopped by disabling the block.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (20, 21 and master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (20, 21 and master)
        Hide
        Andrew Davis added a comment -

        Looks good. I noticed MDL-28231 while testing.

        Show
        Andrew Davis added a comment - Looks good. I noticed MDL-28231 while testing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Incorporated upstream, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Incorporated upstream, thanks!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: