Moodle

Cancelling restore operation generates fatal error

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0.1, 2.0.2
  • Fix Version/s: 2.0.3
  • Component/s: Backup
  • Labels:
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

If you cancel the restore operation, using the "Cancel" button, an error is generated as follows:

Fatal error: Call to undefined method restore_ui::cancel_backup()in /.../backup/util/ui/restore_ui_stage.class.php on line 395

I believe this was from the last possible screen cancel could be used.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27012 Cancel button broken on restore screens

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Fulton added a comment -

I was able to reproduce this in Moodle 2.0.2+ (Build: 20110323) by clicking "Cancel" (and confirming the popup) from step 4: schema. Note that canceling worked fine from step 3.

Show
Charles Fulton added a comment - I was able to reproduce this in Moodle 2.0.2+ (Build: 20110323) by clicking "Cancel" (and confirming the popup) from step 4: schema. Note that canceling worked fine from step 3.
Hide
Permalink
Helen Foster added a comment -

Mike, thanks for your report and Charles, thanks for confirming the bug. Increasing priority in the hope it can be fixed soon.

Show
Helen Foster added a comment - Mike, thanks for your report and Charles, thanks for confirming the bug. Increasing priority in the hope it can be fixed soon.
Hide
Permalink
Aparup Banerjee added a comment -

ok, i've got a patch up at
https://github.com/nebgor/moodle/compare/mistress...MDL-26319
and
https://github.com/nebgor/moodle/compare/MOODLE_20_STABLE...MDL-26319_MOODLE_20_STABLE

Show
Aparup Banerjee added a comment - ok, i've got a patch up at https://github.com/nebgor/moodle/compare/mistress...MDL-26319 and https://github.com/nebgor/moodle/compare/MOODLE_20_STABLE...MDL-26319_MOODLE_20_STABLE
Hide
Permalink
Aparup Banerjee added a comment -

PULL-593 and PULL-594 created and linked.
Thanks for the quick review SamH!

Show
Aparup Banerjee added a comment - PULL-593 and PULL-594 created and linked. Thanks for the quick review SamH!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: