Primarly
numerical/questiontype.php
line 1047 $unitgradingtypes = array('1' => get_string('decfractionofquestiongrade', 'qtype_numerical'), '2' => get_string('decfractionofresponsegrade', 'qtype_numerical'));
should be change to
Pierre Pichet
added a comment - Primarly
numerical/questiontype.php
line 1047 $unitgradingtypes = array('1' => get_string('decfractionofquestiongrade', 'qtype_numerical'), '2' => get_string('decfractionofresponsegrade', 'qtype_numerical'));
should be change to
$unitgradingtypes = array('1' => get_string('decfractionofresponsegrade', 'qtype_numerical'), '2' => get_string('decfractionofquestiongrade', 'qtype_numerical'));
Will look if there are not other unit grading settings to change.
and use this as a first git ...
Pierre Pichet
added a comment - Tim
Here a first GIT trial.
https://github.com/ppichet/moodle/commit/ff6b824e6da0e48fdd1266612f0dc9c0ceea04bc
Fixing GIT in Windows is somehow searching the LOST ARK...
Finally I found the Z: directory containing the SSH keys in another server...
Tim Hunt
added a comment - Thanks Pierre. That fix looks good to me, so I have made pull-request PULL-270 for it, so that should get into next week's weekly build.
Just one thing I would change in future, your commit comment:
MDL-26356 :Correcting the texts of Numerical Units grading select element
Does not quite match the standard format. You can see three good examples here: https://github.com/stronk7/moodle/compare/master...MDL-26229_restore_attempts_wip
MDL-26229 backup & restore - fix quiz & lesson conflicts
MDL-26229 restore - prevent tag-conflicting structures to be created
MDL-26229 restore - parser improvements (repetitions and skipped tags)
Just something to note for future bug-fixes. Thanks, Tim.
This might be the same thing I wanted to report, but not sure. The bug I see is that if one sets up a quiz question with "Only the NUMERICAL ANSWER will be graded, Unit1 will be shown" then enters the units and saves, all is well. However, when re-entering that question to edit it, the Units Handling radio button is not set correctly. My proofreader/editor helper then cannot figure this out so her only option is to cancel the changes.
Britt
added a comment - This might be the same thing I wanted to report, but not sure. The bug I see is that if one sets up a quiz question with "Only the NUMERICAL ANSWER will be graded, Unit1 will be shown" then enters the units and saves, all is well. However, when re-entering that question to edit it, the Units Handling radio button is not set correctly. My proofreader/editor helper then cannot figure this out so her only option is to cancel the changes.
This is not the same bug but MDL-26299 which was recently resolved.
On testing with the proposed new MDL-26299 code, the probleem disappears.
Your site needs updating.
Pierre Pichet
added a comment - - edited This is not the same bug but MDL-26299 which was recently resolved.
On testing with the proposed new MDL-26299 code, the probleem disappears.
Your site needs updating.
Bug
Closed
Minor
Primarly
numerical/questiontype.php
line 1047 $unitgradingtypes = array('1' => get_string('decfractionofquestiongrade', 'qtype_numerical'), '2' => get_string('decfractionofresponsegrade', 'qtype_numerical'));
should be change to
$unitgradingtypes = array('1' => get_string('decfractionofresponsegrade', 'qtype_numerical'), '2' => get_string('decfractionofquestiongrade', 'qtype_numerical'));
Will look if there are not other unit grading settings to change.
and use this as a first git ...