Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Enrolments
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      15973

      Description

      The 2.0 conversion of enrol/imsenterprise did not fix basic problems such as:
      1/ course creation
      2/ user creation
      3/ user deleting
      4/ undefined $line
      5/ sloppy whitespace
      6/ unset() instead new
      7/ etc, etc.

      At the moment it is definitely not suitable for production, sorry.

        Issue Links

          Activity

          Hide
          Gilles-Philippe Leblanc added a comment -

          Could you be more specific about theses problems ?
          We use presently the enrol/imsenterprise for:

          • course creation
          • user creation

          We fix somes problems in our IMS and we want to know if the problems are the same.

          We also want to know what are the other problems.

          Thanks.

          Show
          Gilles-Philippe Leblanc added a comment - Could you be more specific about theses problems ? We use presently the enrol/imsenterprise for: course creation user creation We fix somes problems in our IMS and we want to know if the problems are the same. We also want to know what are the other problems. Thanks.
          Hide
          moodle.com added a comment -

          Gilles-Philippe, when you said you fixed problems in yours, is that just in your 2.0 copy? Can you post patches please?

          Show
          moodle.com added a comment - Gilles-Philippe, when you said you fixed problems in yours, is that just in your 2.0 copy? Can you post patches please?
          Hide
          Gilles-Philippe Leblanc added a comment -

          I have already submitted some of the fix/improvement:

          • http://tracker.moodle.org/browse/MDL-25983. Its an improvement because it add the summary on an IMS course ans its alors a fix because without it, the course created with a summary to null cannot be found with the moodle course search engine.
          • http://tracker.moodle.org/browse/MDL-20223 This one fix the default value for a course. it also add he code for adding the default enrolment method like the ones added when a course is created by others creation methods.

          Finnally, we did a little change for the default language of the created user:

          $person->lang = 'manual'; //TODO: this needs more work due tu multiauth changes
          

          Modified to:

          $person->lang = $CFG->lang; //TODO: this needs more work due tu multiauth changes
          

          We also modified the startdate of our created courses to fit the beginning of your sessions dates.

          Show
          Gilles-Philippe Leblanc added a comment - I have already submitted some of the fix/improvement: http://tracker.moodle.org/browse/MDL-25983 . Its an improvement because it add the summary on an IMS course ans its alors a fix because without it, the course created with a summary to null cannot be found with the moodle course search engine. http://tracker.moodle.org/browse/MDL-20223 This one fix the default value for a course. it also add he code for adding the default enrolment method like the ones added when a course is created by others creation methods. Finnally, we did a little change for the default language of the created user: $person->lang = 'manual'; //TODO: this needs more work due tu multiauth changes Modified to: $person->lang = $CFG->lang; //TODO: this needs more work due tu multiauth changes We also modified the startdate of our created courses to fit the beginning of your sessions dates.
          Hide
          Gilles-Philippe Leblanc added a comment -

          However we would like to know are the changes to be made ​​to the IMS Enterprise enrollment method that will be included in this task.

          Indeed, nothing is explicitly specified. It is only said that it does not work. We want to know exactly what does not, if our patches can help to achieve this task and finally if other patches need / are included in this task.

          Show
          Gilles-Philippe Leblanc added a comment - However we would like to know are the changes to be made ​​to the IMS Enterprise enrollment method that will be included in this task. Indeed, nothing is explicitly specified. It is only said that it does not work. We want to know exactly what does not, if our patches can help to achieve this task and finally if other patches need / are included in this task.
          Hide
          Jérôme Mouneyrac added a comment -

          I agree that the description is not helpful. I guess Petr wrote it as a reminder for himself for later and it ended up in the Agile sprint.

          Anyway, after talking about this issue in the Sprint meeting, we decide to clarify it a bit, I'll organize this issue as a central issue to fix these IMS problems.

          Show
          Jérôme Mouneyrac added a comment - I agree that the description is not helpful. I guess Petr wrote it as a reminder for himself for later and it ended up in the Agile sprint. Anyway, after talking about this issue in the Sprint meeting, we decide to clarify it a bit, I'll organize this issue as a central issue to fix these IMS problems.
          Hide
          moodle.com added a comment -

          This needs a clear specification soon, so we can fix it in stable.

          Show
          moodle.com added a comment - This needs a clear specification soon, so we can fix it in stable.
          Hide
          Adam Barbary added a comment -

          I have been playing with the IMS import in Moodle 2, and have found a lot of errors too.

          The <cohort> tag is definitely broken
          Only 1 authentication plugin can be enabled (Manual and No) are fine, but only one other. We use LDAP. You can hard code this to a specific one if that is all you need. (This bug goes back to the dawn of time....)
          New courses are not searchable. Something is amiss there. Entering the course settings and saving (no changes needed) will make the course searchable.
          System Defaults for course settings are again ignored. For the time being these need to be hard coded.

          Good luck Petr with that finding time thing...

          Adam

          Show
          Adam Barbary added a comment - I have been playing with the IMS import in Moodle 2, and have found a lot of errors too. The <cohort> tag is definitely broken Only 1 authentication plugin can be enabled (Manual and No) are fine, but only one other. We use LDAP. You can hard code this to a specific one if that is all you need. (This bug goes back to the dawn of time....) New courses are not searchable. Something is amiss there. Entering the course settings and saving (no changes needed) will make the course searchable. System Defaults for course settings are again ignored. For the time being these need to be hard coded. Good luck Petr with that finding time thing... Adam
          Hide
          Adam Barbary added a comment - - edited

          After having a look at the database after an import, I believe I have a work-around for the non-searchable courses. The current IMS load creates a course without anything in the course summary field, and this is assigned the value NULL. However, when searching, a course with NULL as the summary will not be included in the search results. I'm not sure which end the problem lies, whether the search should be able to ignore the NULL, or the IMS load should not create NULL entries or whether the database structure should not be set as NULL by default. Anyway, if you put this line in your lib.php file, around line 354, you should have a suitable workaround.

          $course->summary = '';

          Cheers,

          Adam

          Show
          Adam Barbary added a comment - - edited After having a look at the database after an import, I believe I have a work-around for the non-searchable courses. The current IMS load creates a course without anything in the course summary field, and this is assigned the value NULL. However, when searching, a course with NULL as the summary will not be included in the search results. I'm not sure which end the problem lies, whether the search should be able to ignore the NULL, or the IMS load should not create NULL entries or whether the database structure should not be set as NULL by default. Anyway, if you put this line in your lib.php file, around line 354, you should have a suitable workaround. $course->summary = ''; Cheers, Adam
          Hide
          Mark van Hoek added a comment -

          Bumping this.

          Show
          Mark van Hoek added a comment - Bumping this.
          Hide
          Adam Barbary added a comment - - edited

          Quick note, 2 and 5 are the same issue. I accidentally cloned this about 4 months ago. This has been resolved in 2.2 by Dan Marsden, so that can be closed off. Only leaves point 1 as far as I can see. The status of blocker could also be changed to improvement, as I don't see the addition of the summary as being a blocker IMHO.

          Show
          Adam Barbary added a comment - - edited Quick note, 2 and 5 are the same issue. I accidentally cloned this about 4 months ago. This has been resolved in 2.2 by Dan Marsden, so that can be closed off. Only leaves point 1 as far as I can see. The status of blocker could also be changed to improvement, as I don't see the addition of the summary as being a blocker IMHO.
          Hide
          David Monllaó added a comment -

          Closing, all sub-tasks are closed. Further work on http://tracker.moodle.org/browse/MDL-28705

          Show
          David Monllaó added a comment - Closing, all sub-tasks are closed. Further work on http://tracker.moodle.org/browse/MDL-28705

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: