Moodle
  1. Moodle
  2. MDL-26388

Handle duplicate files uploaded through filepicker

    Details

    • Testing Instructions:
      Hide

      Hello testers
      This issue needs to test in html editor and file manager.

      HTML Editor
      1. Adding a picture to html editor with name for example: test.jpg
      2. Adding another picture with the same name by using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected.

      File manager, for example in your private file management page
      1. Adding a picture to filemanager with name for example: test.jpg
      2. Adding another picture with the same name using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected.

      Show
      Hello testers This issue needs to test in html editor and file manager. HTML Editor 1. Adding a picture to html editor with name for example: test.jpg 2. Adding another picture with the same name by using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected. File manager, for example in your private file management page 1. Adding a picture to filemanager with name for example: test.jpg 2. Adding another picture with the same name using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull Master Branch:
      s9_MDL-26388_filepicker_existing_files_master

      Description

      User are not able to:
      1/ delete "uploaded" file
      2/ user can not find out what files were already uploaded
      3/ users can not link again already existing image

      The reason is that there is no way to manage the files that are uploaded to the file area referenced from the text in tinymce editor. Attempts to work around this missing feature (overriding of files, link from forms, etc.) were only creating regressions.

      Possible solution - add a new tab "Used files" to the file picker, this would solve all 3 issues above. I have proposed several different solutions before, but I think this is the best one.

        Gliffy Diagrams

        1. 2011-04-11 12.01.bmml
          1 kB
          Dongsheng Cai
        1. 2011-04-11 12.01.png
          13 kB
        2. mdl_26388.jpg
          170 kB
        3. picker.png
          23 kB
        4. picker2.png
          307 kB
        5. safari.png
          46 kB

          Issue Links

            Activity

            Petr Skoda created issue -
            Petr Skoda made changes -
            Field Original Value New Value
            Attachment picker.png [ 23014 ]
            Petr Skoda made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            Description User are not able to:
            1/ delete "uploaded" file
            2/ user can not find out what files were already uploaded
            3/ users can not link again already existing image

            The reason is that there is no way to manage the files that are uploaded to the file area referenced from the text in tinymce editor. Attempts to work around this missing feature (overriding of files, link from forms, etc.) were only creating regressions.

            Possible solution - add a new tab "Current files" to the file picker, this would solve all 3 issues above. I have proposed several different solutions before, but I think this is the best one.
            User are not able to:
            1/ delete "uploaded" file
            2/ user can not find out what files were already uploaded
            3/ users can not link again already existing image

            The reason is that there is no way to manage the files that are uploaded to the file area referenced from the text in tinymce editor. Attempts to work around this missing feature (overriding of files, link from forms, etc.) were only creating regressions.

            Possible solution - add a new tab "Used files" to the file picker, this would solve all 3 issues above. I have proposed several different solutions before, but I think this is the best one.
            Petr Skoda made changes -
            Link This issue is duplicated by MDL-26107 [ MDL-26107 ]
            Petr Skoda made changes -
            Link This issue is duplicated by MDL-26090 [ MDL-26090 ]
            Petr Skoda made changes -
            Link This issue is duplicated by MDL-25585 [ MDL-25585 ]
            Petr Skoda made changes -
            Link This issue is duplicated by MDL-25518 [ MDL-25518 ]
            Helen Foster made changes -
            Labels triaged
            Petr Skoda made changes -
            Attachment picker2.png [ 23048 ]
            Petr Skoda made changes -
            Link This issue is duplicated by MDL-26650 [ MDL-26650 ]
            moodle.com made changes -
            Summary no management of files uploaded through tinymce filepicker Handle duplicate files uploaded through filepicker
            Fix Version/s STABLE Sprint 9 [ 10550 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Dongsheng Cai made changes -
            Assignee moodle.com [ moodle.com ] Dongsheng Cai [ dongsheng ]
            Dongsheng Cai made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Dongsheng Cai made changes -
            Link This issue will help resolve MDL-26832 [ MDL-26832 ]
            Martin Dougiamas made changes -
            Fix Version/s STABLE Sprint 10 [ 10551 ]
            Fix Version/s STABLE Sprint 9 [ 10550 ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 67716 ] MDL Full Workflow [ 76680 ]
            Dongsheng Cai made changes -
            Status Development in progress [ 3 ] Open [ 1 ]
            Dan Marsden made changes -
            Link This issue is duplicated by MDL-27297 [ MDL-27297 ]
            moodle.com made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            Dongsheng Cai made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            Dongsheng Cai made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            Pull Master Diff URL https://github.com/dongsheng/moodle/compare/master...s9_MDL-26388_filepicker_existing_files_master
            Pull Master Branch s9_MDL-26388_filepicker_existing_files_master
            Pull 2.0 Diff URL https://github.com/dongsheng/moodle/compare/MOODLE_20_STABLE...s9_MDL-26388_filepicker_existing_files_20
            Pull 2.0 Branch s9_MDL-26388_filepicker_existing_files_20
            Pull from Repository git://github.com/dongsheng/moodle.git
            Peer reviewer nebgor
            Testing Instructions Hello testers
            This issue needs to test in html editor and file manager.

            HTML Editor
            1. Adding a picture to html editor with name for example: test.jpg
            2. Adding another picture with the same name by using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected.


            File manager, for example in your private file management page
            1. Adding a picture to filemanager with name for example: test.jpg
            2. Adding another picture with the same name using upload/local/recent/private repository plugins, you should see a dialog pop up asking you want to overwrite/rename or cancel, try all options to see if it works as expected.
            Aparup Banerjee made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
            Dongsheng Cai made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            Dongsheng Cai made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Sam Hemelryk made changes -
            Labels triaged ci pullweek-2011-18
            Dongsheng Cai made changes -
            Component/s Repositories [ 10306 ]
            Dongsheng Cai made changes -
            Link This issue will help resolve MDL-23989 [ MDL-23989 ]
            Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Helen Foster made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester tsala
            Helen Foster made changes -
            Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
            Sam Hemelryk made changes -
            Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
            Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Eloy Lafuente (stronk7) made changes -
            Attachment safari.png [ 23776 ]
            Michael Blake made changes -
            Attachment mdl_26388.jpg [ 23777 ]
            Eloy Lafuente (stronk7) made changes -
            Link This issue has been marked as being related by MDL-27381 [ MDL-27381 ]
            Eloy Lafuente (stronk7) made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Fix Version/s 2.0.3 [ 10537 ]
            Resolution Fixed [ 1 ]
            Eloy Lafuente (stronk7) made changes -
            Labels ci pullweek-2011-18 pullweek-2011-18
            Eloy Lafuente (stronk7) made changes -
            Integration date 4/May/11
            Martin Dougiamas made changes -
            Link This issue is a clone of MDL-28019 [ MDL-28019 ]
            Eloy Lafuente (stronk7) made changes -
            Fix Version/s STABLE Sprint 10 [ 10551 ]

              People

              • Votes:
                42 Vote for this issue
                Watchers:
                19 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: