Moodle
  1. Moodle
  2. MDL-26400

problem w/ left and right blocks on rtl languages with ie7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Won't Fix
    • Affects Version/s: 2.1
    • Fix Version/s: STABLE backlog
    • Component/s: Themes
    • Labels:
    • Environment:
      windows and ie7
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Prepare for this one. You will need IE7 & IE8, IE9 Firefox, Chrome, and Safari (minimum). You will also need to know a RTL language. So a tester with this ability would be better equipped.
      2. Ensure you have a custom menu created on your site with multi lang capability.
      3. Switch to a RTL language.
      4. Enable "Allow theme change by URL" in theme settings
      5. In each browser open the following pages (order is important)
        • /index.php?theme=base_rtl
        • /login/index.php(and login as an admin)
        • /course/report/outline/index.php?id=1

      Make sure that blocks and layout works on all pages, it should look nearly identical in all pages. However, blocks normally on the left will swap to the right and visa-versa.

      After testing in RTL change back to LTR and test to see that the theme works OK, checking to see that the blocks are positioned correctly.

      Show
      Prepare for this one. You will need IE7 & IE8, IE9 Firefox, Chrome, and Safari (minimum). You will also need to know a RTL language. So a tester with this ability would be better equipped. Ensure you have a custom menu created on your site with multi lang capability. Switch to a RTL language. Enable "Allow theme change by URL" in theme settings In each browser open the following pages (order is important) /index.php?theme=base_rtl /login/index.php(and login as an admin) /course/report/outline/index.php?id=1 Make sure that blocks and layout works on all pages, it should look nearly identical in all pages. However, blocks normally on the left will swap to the right and visa-versa. After testing in RTL change back to LTR and test to see that the theme works OK, checking to see that the blocks are positioned correctly.
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      15993

      Description

      This BUG affects all CORE themes apart from Standard (Legacy)

      while using windows and ie7 on RTL languages (like Hebrew and Arabic)
      both right and left blocks aren't appearing at all...

      other problems extend to the Login page, where the middle part of the page appears blank, whilst the header and footer are visible, including performance info as seen in Moodle Q&A Test site when viewing Standard theme in IE8 in IE7 Compatibility Mode.

        Issue Links

          Activity

          Hide
          Yedidia Klein added a comment -

          can be fixed by adding these lines to theme style/core.css
          /* fixes for heb and IE7 */
          .ie7.dir-rtl div#page-content #region-pre

          { margin-left:0px; }

          .ie7.dir-rtl div#page-content #region-post

          { left: 200px; float: none;}
          Show
          Yedidia Klein added a comment - can be fixed by adding these lines to theme style/core.css /* fixes for heb and IE7 */ .ie7.dir-rtl div#page-content #region-pre { margin-left:0px; } .ie7.dir-rtl div#page-content #region-post { left: 200px; float: none;}
          Hide
          Yedidia Klein added a comment -

          better - but not final...

          /* fixes for heb and IE7 */
          .ie7.dir-rtl div#page-content #region-pre

          { margin-left:0px; left:-35%;}

          .ie7.dir-rtl div#page-content #region-post

          { left: 200px; float: none;}

          .ie7.dir-rtl div#page-content #region-main-box

          { width:100%; }

          .ie7.dir-rtl div#page-content #region-main-wrap

          { right:50%; }

          html

          {Overflow-x:hidden;}

          /* for removing horizontal scrollbar */

          Show
          Yedidia Klein added a comment - better - but not final... /* fixes for heb and IE7 */ .ie7.dir-rtl div#page-content #region-pre { margin-left:0px; left:-35%;} .ie7.dir-rtl div#page-content #region-post { left: 200px; float: none;} .ie7.dir-rtl div#page-content #region-main-box { width:100%; } .ie7.dir-rtl div#page-content #region-main-wrap { right:50%; } html {Overflow-x:hidden;} /* for removing horizontal scrollbar */
          Hide
          omer added a comment -

          hi,
          this doesnt work for me - from some reason.

          ie7 still displays "blank" screen - shows only header

          Show
          omer added a comment - hi, this doesnt work for me - from some reason. ie7 still displays "blank" screen - shows only header
          Hide
          Menachem Burshtein added a comment -

          in order to get better view , course block in right size add the following lines in same file

          .ie7.dir-rtl div#page-content #region-main

          { margin-left:-200px; }

          .ie7.dir-rtl div#page-content .region-content

          { padding-left:2px; }

          .ie7.dir-rtl .block .header

          { text-align:right; }

          you must delete the cache in moodledata/cache to see the changes.

          Show
          Menachem Burshtein added a comment - in order to get better view , course block in right size add the following lines in same file .ie7.dir-rtl div#page-content #region-main { margin-left:-200px; } .ie7.dir-rtl div#page-content .region-content { padding-left:2px; } .ie7.dir-rtl .block .header { text-align:right; } you must delete the cache in moodledata/cache to see the changes.
          Hide
          omer added a comment -

          any progress made with this report ?
          it seems to be forgotten...

          this is a very "painful" bug, and me telling clients to install chrome\firefox is a bad solution...

          omer

          Show
          omer added a comment - any progress made with this report ? it seems to be forgotten... this is a very "painful" bug, and me telling clients to install chrome\firefox is a bad solution... omer
          Hide
          James added a comment -

          so?

          Show
          James added a comment - so?
          Hide
          Mary Evans added a comment - - edited

          I am assuming that the problem is in the layout, and as some CORE themes use different layouts, this makes fixing this BUG quite a task, as each theme will need to be looked at individually.

          This problem has come to light again because the fix offered (see above) is not working.

          I can most probably do the fixes, but I will need someone to test them as I don't have IE7, and IE8 in IE7 Compatibility Mode is not a very good alternative .

          Show
          Mary Evans added a comment - - edited I am assuming that the problem is in the layout, and as some CORE themes use different layouts, this makes fixing this BUG quite a task, as each theme will need to be looked at individually. This problem has come to light again because the fix offered (see above) is not working. I can most probably do the fixes, but I will need someone to test them as I don't have IE7, and IE8 in IE7 Compatibility Mode is not a very good alternative .
          Hide
          Mary Evans added a comment -

          I'm going to see what can be done...but not making any promises

          Show
          Mary Evans added a comment - I'm going to see what can be done...but not making any promises
          Hide
          Mary Evans added a comment -

          Sam, I have made you a watcher for this issue as I think I may need some guidance!
          Thanks
          Mary

          Show
          Mary Evans added a comment - Sam, I have made you a watcher for this issue as I think I may need some guidance! Thanks Mary
          Hide
          Mary Evans added a comment -

          Login page @ Moodle Q & A Test Site as viewed in IE8 (Compatibility Mode) which mimics what is seen when using IE7.

          Show
          Mary Evans added a comment - Login page @ Moodle Q & A Test Site as viewed in IE8 (Compatibility Mode) which mimics what is seen when using IE7.
          Hide
          omer added a comment -

          I have IE7 and am willing to test whatever changes you make happily.
          Omer

          Show
          omer added a comment - I have IE7 and am willing to test whatever changes you make happily. Omer
          Hide
          omer added a comment -

          1- i'll be happy to assist in any way possible (though i'm not very good with CSS)
          2- what will be the "Road map" for this issue ? i'm guessing it won't be fixed for the upcoming 2.1 release..

          Omer

          Show
          omer added a comment - 1- i'll be happy to assist in any way possible (though i'm not very good with CSS) 2- what will be the "Road map" for this issue ? i'm guessing it won't be fixed for the upcoming 2.1 release.. Omer
          Hide
          Mary Evans added a comment -

          Hi Omar

          Thank you very much for your offer to help in this project.
          There is no way this will get into Moodle 2.1 unless I get some divine inspiration, as whatever fixes I add seems to have little or no impact whatsoever on the core themes.

          While writing this comment this morning, and at the same time praying for some inspiration, it occurred to me to try one of my very first themes for |Moodle 2.0 and see how that compares. Strangely enough I can get the Login page when lang is in Hebrew, which is a start! LOL So things are looking good in IE8 Compatibility mode. This is perhaps the fact that the theme 'Cafelite' works independently and as such has no parent theme.

          I've set up a Sandbox at http://visible-expression.co.uk/sandbox/ where you can do the testing. The version is Moodle 2.0.3 (Build: 5th May 2011)

          I'll set you up with an account and then you can add a course or two if wish, as the site is a fresh install and empty.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Omar Thank you very much for your offer to help in this project. There is no way this will get into Moodle 2.1 unless I get some divine inspiration, as whatever fixes I add seems to have little or no impact whatsoever on the core themes. While writing this comment this morning, and at the same time praying for some inspiration, it occurred to me to try one of my very first themes for |Moodle 2.0 and see how that compares. Strangely enough I can get the Login page when lang is in Hebrew, which is a start! LOL So things are looking good in IE8 Compatibility mode. This is perhaps the fact that the theme 'Cafelite' works independently and as such has no parent theme. I've set up a Sandbox at http://visible-expression.co.uk/sandbox/ where you can do the testing. The version is Moodle 2.0.3 (Build: 5th May 2011) I'll set you up with an account and then you can add a course or two if wish, as the site is a fresh install and empty. Cheers Mary
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          Just popping in to say that it looks like this is heading in the right direction.
          With the pressure now on to get Moodle 2.1 ready for release I don't think I will have time to lend a hand here sorry.
          I've brought this to the attention of the higher powers - if there is any chance that changes will land for 2.1 this will have to be looked at immediately (only about 16 hours now until nothing more will be integrated).
          If this doesn't make it to 2.1 surely it should make it to 2.1.1

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, Just popping in to say that it looks like this is heading in the right direction. With the pressure now on to get Moodle 2.1 ready for release I don't think I will have time to lend a hand here sorry. I've brought this to the attention of the higher powers - if there is any chance that changes will land for 2.1 this will have to be looked at immediately (only about 16 hours now until nothing more will be integrated). If this doesn't make it to 2.1 surely it should make it to 2.1.1 Cheers Sam
          Hide
          Michael de Raadt added a comment -

          Hi, Mary.

          Thanks for taking on this work.

          Please let us know if we can help you test the results.

          Michael;

          Show
          Michael de Raadt added a comment - Hi, Mary. Thanks for taking on this work. Please let us know if we can help you test the results. Michael;
          Hide
          James added a comment -

          hi
          In response to what Sam Hemelryk wrote - why it is not listed on developments to 2.1.1? Hope it is not forgotten ..

          Show
          James added a comment - hi In response to what Sam Hemelryk wrote - why it is not listed on developments to 2.1.1? Hope it is not forgotten ..
          Hide
          Mary Evans added a comment -

          No one has forgotten this...I am still waiting for someone to give me feedback, to tell me if they can see the login page in IE7 in the following website! http://visible-expression.co.uk/sandbox/

          The theme at that site is built differently than any theme in Moodle Core. If you can verify that the theme works I can get on with loading it into Moodle, and when I get the all clear from Sam, it will be integrated into whatever version of Moodle I can get it into - ASAP. It's not rocket science...but it is a lot of hard work for a little lady!

          If you want a copy of the theme I can give you a link to download it.

          Cheers
          Mary

          Show
          Mary Evans added a comment - No one has forgotten this...I am still waiting for someone to give me feedback, to tell me if they can see the login page in IE7 in the following website! http://visible-expression.co.uk/sandbox/ The theme at that site is built differently than any theme in Moodle Core. If you can verify that the theme works I can get on with loading it into Moodle, and when I get the all clear from Sam, it will be integrated into whatever version of Moodle I can get it into - ASAP. It's not rocket science...but it is a lot of hard work for a little lady! If you want a copy of the theme I can give you a link to download it. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary

          http://visible-expression.co.uk/sandbox/
          look great using IE7/IE8 on an Hebrew Windows XP
          in both Hebrew and English Moodle UI modes.

          Show
          Nadav Kavalerchik added a comment - Hi Mary http://visible-expression.co.uk/sandbox/ look great using IE7/IE8 on an Hebrew Windows XP in both Hebrew and English Moodle UI modes.
          Hide
          Nadav Kavalerchik added a comment -

          BTW, does this theme can invert (switch sides of) block columns when switching from LTR to RTL ?
          I am asking, since all current Moodle 2 themes do not.
          And I am not sure if this is a bug or a new intent or feature of the new layout (holy-grail-no-quirks-mode)

          Show
          Nadav Kavalerchik added a comment - BTW, does this theme can invert (switch sides of) block columns when switching from LTR to RTL ? I am asking, since all current Moodle 2 themes do not. And I am not sure if this is a bug or a new intent or feature of the new layout (holy-grail-no-quirks-mode)
          Hide
          Yedidia Klein added a comment -

          Nadav! you are checking IE visibility ?? how did you get to an operating system that use this browser ??
          Tnx...

          Show
          Yedidia Klein added a comment - Nadav! you are checking IE visibility ?? how did you get to an operating system that use this browser ?? Tnx...
          Hide
          Nadav Kavalerchik added a comment -

          Hi Yedidia

          Indeed a rare occasion to see a closed source OS in our neighborhood.
          My brother is visiting us. I borrowed his laptop for this occasion.

          It is all from concern to all those "locked in" K12 schools that do not have
          the technicians that could install Firefox/Chrome or even upgrade to IE9.

          (Omer from MASHOV told me they installed Moodle 2 at 70 K12 Schools
          and i do not want them to get disappointed from the experience of using Moodle)

          Show
          Nadav Kavalerchik added a comment - Hi Yedidia Indeed a rare occasion to see a closed source OS in our neighborhood. My brother is visiting us. I borrowed his laptop for this occasion. It is all from concern to all those "locked in" K12 schools that do not have the technicians that could install Firefox/Chrome or even upgrade to IE9. (Omer from MASHOV told me they installed Moodle 2 at 70 K12 Schools and i do not want them to get disappointed from the experience of using Moodle)
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          How are things going on this? any luck finding the cause or and solution to the problems?

          We're really keen to get this fixed, I've had a bit of a play today and noted that yes it is easily reproducible on IE7 and 8, both of which are browsers we try to support.
          I haven't had a chance to really look at the cause of the problems yet however.
          If you would like a hand I am more than happy to help.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, How are things going on this? any luck finding the cause or and solution to the problems? We're really keen to get this fixed, I've had a bit of a play today and noted that yes it is easily reproducible on IE7 and 8, both of which are browsers we try to support. I haven't had a chance to really look at the cause of the problems yet however. If you would like a hand I am more than happy to help. Cheers Sam
          Hide
          Mary Evans added a comment -

          Hi Sam,

          I've looked through all the CSS in Base theme, and there does not seem to be anything that stands out, except in pagelayout. I have ruled out Canvas as this uses Base anyway.

          Last year you may recall I created a theme called Cafelite where I used one of Matthew James Taylor's layouts that uses percentages, not pixels. The difference in that layout and the one used in Base theme is that #region-side-post does not exist, and in it's place is #region-side-pre. I named it that, because of its position in the layout. There was a forum discussion at the time which you may also recall... (http://moodle.org/mod/forum/discuss.php?d=148688)

          The theme I am using on my website ( http://visible-expression.co.uk/sandbox/) to test this phenomenon, uses that same layout, and as you will see, works when RTL language is selected. If you want to test that theme against others on the site I've set it up so you can change theme by url.

          So the conclusion I have come to is that it's nothing to do with Moodle, but more to do with Base theme's layout.

          I did wonder if it was possible to add this theme to Moodle Core as a base for other themes to use as a parent. In fact I did wonder why other layouts, like the 2 column or 3 column blog style layouts which Matthew J. Taylor offers on his website (http://matthewjamestaylor.com/blog/perfect-3-column-blog-style.htm) were not already set up to use as parent themes. Having a selection of basic layouts, with hardly any styling, (as the styling of the main areas within Moodle could come from Base theme but exclude Base pagelayout), would make themeing easier, similar to the lines of the CSS Zen Garden (http://www.mezzoblue.com/zengarden/alldesigns/) where there is a set layout, but hundreds of different designs, as it is the layout which is the crux of the theme, and also the hardest to get right.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Sam, I've looked through all the CSS in Base theme, and there does not seem to be anything that stands out, except in pagelayout. I have ruled out Canvas as this uses Base anyway. Last year you may recall I created a theme called Cafelite where I used one of Matthew James Taylor's layouts that uses percentages, not pixels. The difference in that layout and the one used in Base theme is that #region-side-post does not exist, and in it's place is #region-side-pre. I named it that, because of its position in the layout. There was a forum discussion at the time which you may also recall... ( http://moodle.org/mod/forum/discuss.php?d=148688 ) The theme I am using on my website ( http://visible-expression.co.uk/sandbox/ ) to test this phenomenon, uses that same layout, and as you will see, works when RTL language is selected. If you want to test that theme against others on the site I've set it up so you can change theme by url. So the conclusion I have come to is that it's nothing to do with Moodle, but more to do with Base theme's layout. I did wonder if it was possible to add this theme to Moodle Core as a base for other themes to use as a parent. In fact I did wonder why other layouts, like the 2 column or 3 column blog style layouts which Matthew J. Taylor offers on his website ( http://matthewjamestaylor.com/blog/perfect-3-column-blog-style.htm ) were not already set up to use as parent themes. Having a selection of basic layouts, with hardly any styling, (as the styling of the main areas within Moodle could come from Base theme but exclude Base pagelayout), would make themeing easier, similar to the lines of the CSS Zen Garden ( http://www.mezzoblue.com/zengarden/alldesigns/ ) where there is a set layout, but hundreds of different designs, as it is the layout which is the crux of the theme, and also the hardest to get right. Cheers Mary
          Hide
          Mary Evans added a comment -

          Hi Sam,

          Since this problem only presents itself at the login page in IE7, when a RTL language is selected, and I know the layout I have used on some of my own themes works in this scenario, could we just go from a theme based login.php layout page similar to the report.php? This would get over the login part of this problem, as once logged in I think the problems are lessened, but at the same time making the CORE themes usable again.

          What do you think?

          Mary

          Show
          Mary Evans added a comment - Hi Sam, Since this problem only presents itself at the login page in IE7, when a RTL language is selected, and I know the layout I have used on some of my own themes works in this scenario, could we just go from a theme based login.php layout page similar to the report.php? This would get over the login part of this problem, as once logged in I think the problems are lessened, but at the same time making the CORE themes usable again. What do you think? Mary
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          Sorry I totally forgot to reply to you the other about this last week!
          I am in the process of moving at the moment so not a work but I really wanted to let you know about this.
          I spent a little bit of time on Friday and investigated this, I managed to track down what I believe to be the culprit (of most of it anyway).
          The YUI custom menu CSS (moodle/lib/yui/3.2.0/build/node-menunav/assets/.css and moodle/lib/yui/3.2.0/build/node-menunav/assets/skins/.css) has some styles that are setting left:-10000px or close to that, of course on rtl languages the browser scrolls to the left which is what is causing things to disappear off screen and causing that scroll bar.
          A quick test to override the couple I found there seemed to fix 90% of the problems, however I didn't have much time and may have missed one or two, hopefully it solves it 100%.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, Sorry I totally forgot to reply to you the other about this last week! I am in the process of moving at the moment so not a work but I really wanted to let you know about this. I spent a little bit of time on Friday and investigated this, I managed to track down what I believe to be the culprit (of most of it anyway). The YUI custom menu CSS (moodle/lib/yui/3.2.0/build/node-menunav/assets/ .css and moodle/lib/yui/3.2.0/build/node-menunav/assets/skins/ .css) has some styles that are setting left:-10000px or close to that, of course on rtl languages the browser scrolls to the left which is what is causing things to disappear off screen and causing that scroll bar. A quick test to override the couple I found there seemed to fix 90% of the problems, however I didn't have much time and may have missed one or two, hopefully it solves it 100%. Cheers Sam
          Hide
          omer added a comment -

          hey guys,

          any luck ?

          10x,
          omer

          Show
          omer added a comment - hey guys, any luck ? 10x, omer
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          Alright after much research, testing and cursing I think I've managed to find both the problem and the solution.
          I've sent several patches up to my github account now that I will start testing in all supported browsers to ensure consistency.
          If anyone who actively uses a rtl, any rtl language could test them as well that would be most appreciated. The details have now been added to this bug report.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, Alright after much research, testing and cursing I think I've managed to find both the problem and the solution. I've sent several patches up to my github account now that I will start testing in all supported browsers to ensure consistency. If anyone who actively uses a rtl, any rtl language could test them as well that would be most appreciated. The details have now been added to this bug report. Cheers Sam
          Hide
          Nadav Kavalerchik added a comment -

          Hi Sam

          Thank you for those fixes!
          I have tested you patches (only on several themes) and they look OK.

          I used a VirtualBox instance with Windows XP using IE8 running IE7 compatibility mode.

          Tests:
          Tested current (4/11/2011) moodle/master... working (IE8)
          Tested current (4/11/2011) moodle/master... not working (IE7 compatibility mode)
          Tested sam's fix ... working (IE8)
          Tested sam's fix ... working (IE7 compatibility mode)

          Show
          Nadav Kavalerchik added a comment - Hi Sam Thank you for those fixes! I have tested you patches (only on several themes) and they look OK. I used a VirtualBox instance with Windows XP using IE8 running IE7 compatibility mode. Tests: Tested current (4/11/2011) moodle/master... working (IE8) Tested current (4/11/2011) moodle/master... not working (IE7 compatibility mode) Tested sam's fix ... working (IE8) Tested sam's fix ... working (IE7 compatibility mode)
          Hide
          Sam Hemelryk added a comment -

          Hi Nadav,

          Thanks for testing all of that - its a BIG help!
          I'll be attempting to get Petr to peer-review this today and putting it up for integration so that this makes the next release (which is nearly here).

          Cheer
          Sam

          Show
          Sam Hemelryk added a comment - Hi Nadav, Thanks for testing all of that - its a BIG help! I'll be attempting to get Petr to peer-review this today and putting it up for integration so that this makes the next release (which is nearly here). Cheer Sam
          Hide
          Sam Hemelryk added a comment -

          Hi Petr,

          Any chance I could get you to take a peak at this in the next day. I'd really like to get this up for integration and I know Eloy would appreciate your thoughts on these changes from a theme perspective (it makes changes to nearly every core theme).

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Petr, Any chance I could get you to take a peak at this in the next day. I'd really like to get this up for integration and I know Eloy would appreciate your thoughts on these changes from a theme perspective (it makes changes to nearly every core theme). Cheers Sam
          Hide
          Mary Evans added a comment -

          Hi Sam,
          There are another RTL patches which Nadav as put in for Peer Review in MDL-29226 at the moment this is assigned to me but not sure how best to move forward with it. If you have a moment can you check it out?
          Thanks
          Mary

          Show
          Mary Evans added a comment - Hi Sam, There are another RTL patches which Nadav as put in for Peer Review in MDL-29226 at the moment this is assigned to me but not sure how best to move forward with it. If you have a moment can you check it out? Thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - Sorry about not getting back to you on things I'm insanely busy at the moment. I'll endeavour to look at that but please if I forget harass me! You have my complete permission to pester me continually until it gets done if you want

          Show
          Sam Hemelryk added a comment - Thanks Mary - Sorry about not getting back to you on things I'm insanely busy at the moment. I'll endeavour to look at that but please if I forget harass me! You have my complete permission to pester me continually until it gets done if you want
          Hide
          Mary Evans added a comment -

          @ Sam,
          I there ANY chance this will get nearer to being resolved?
          The RTL group are getting anxious! Very anxious at that...

          Thanks
          Mary

          Show
          Mary Evans added a comment - @ Sam, I there ANY chance this will get nearer to being resolved? The RTL group are getting anxious! Very anxious at that... Thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          I am keeping my fingers crossed that this will get integrated as part of the daily integrations that will be starting shortly as we build up for the next releases.
          This issue hasn't made it up because I have been kept busy reviewing and on in house projects, certainly it needs to be in and I will pushing that with HQ as much as possible.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, I am keeping my fingers crossed that this will get integrated as part of the daily integrations that will be starting shortly as we build up for the next releases. This issue hasn't made it up because I have been kept busy reviewing and on in house projects, certainly it needs to be in and I will pushing that with HQ as much as possible. Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Oki, after sharing with Sam about this, some points:

          A) It's a horrible hack, but surely the only able to revive IE7 usage for 2.0, 2.1 and 2.2
          B) It's huge, it modifies ALL layouts in ALL themes in 2.0, 2.1 and 2.2
          C) It's safe (html only, no css nor js) and 3rd part themes will continue working the same at worst (if they override/have own layouts) or will be magically fixed if they use parent's layouts.

          Knowing that, this is the plan:

          1) Agree about IE7 support to be dropped in Moodle 2.3. Requires MD confirmation here.
          2) Agree about fix IE7 ltr support (i.e. about to apply this "hack"). MD confirmation too.
          3) Integrate the patch.
          4) Test it for all themes in the target pages, as specified in the instructions, both for 2.1 and 2.2
          5) The day 1 after branching 2.2, we will be reverting this change in master, so it won't be in 2.3 at all. Create one issue about that.

          So, if knowing A), B) and C), MD gives his to 1) and 2), we'll proceed with the plan. Simple!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Oki, after sharing with Sam about this, some points: A) It's a horrible hack, but surely the only able to revive IE7 usage for 2.0, 2.1 and 2.2 B) It's huge, it modifies ALL layouts in ALL themes in 2.0, 2.1 and 2.2 C) It's safe (html only, no css nor js) and 3rd part themes will continue working the same at worst (if they override/have own layouts) or will be magically fixed if they use parent's layouts. Knowing that, this is the plan: 1) Agree about IE7 support to be dropped in Moodle 2.3. Requires MD confirmation here. 2) Agree about fix IE7 ltr support (i.e. about to apply this "hack"). MD confirmation too. 3) Integrate the patch. 4) Test it for all themes in the target pages, as specified in the instructions, both for 2.1 and 2.2 5) The day 1 after branching 2.2, we will be reverting this change in master, so it won't be in 2.3 at all. Create one issue about that. So, if knowing A), B) and C), MD gives his to 1) and 2), we'll proceed with the plan. Simple! Ciao
          Hide
          Martin Dougiamas added a comment -

          Sounds like a good plan so:

          1) +1 for IE7 to be dropped in 2.3. In fact, was already announced. http://docs.moodle.org/dev/Roadmap

          2) +1 to apply the patch for 2.2 and 2.1 only (not sure about 2.0, as we are just about to drop support for it, but if the port is done already then I guess we might as well apply it).

          My only doubt: Will this make maintenance of themes painful in future, when devs are making ports to 2.3, 2.2 and 2.1? It's probably worth it though: I imagine there is a large amount of people needing RTL on IE7.

          Show
          Martin Dougiamas added a comment - Sounds like a good plan so: 1) +1 for IE7 to be dropped in 2.3. In fact, was already announced. http://docs.moodle.org/dev/Roadmap 2) +1 to apply the patch for 2.2 and 2.1 only (not sure about 2.0, as we are just about to drop support for it, but if the port is done already then I guess we might as well apply it). My only doubt: Will this make maintenance of themes painful in future, when devs are making ports to 2.3, 2.2 and 2.1? It's probably worth it though: I imagine there is a large amount of people needing RTL on IE7.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          As commented above, this patch fixes RTL for all core themes, so no problems with that. And also, related with 3rd part themes it causes one of these behaviors:

          A) If the 3rd part theme had inherited layouts from parent (core) theme, then they will get their RTL problems under IE automatically fixed.

          B) If the 3rd part theme had own defined layout, it will continue behaving 100% like it was before the patch. Not affected.

          So I think that both possible behaviors are ok to be assumed by default. I don't think there are more cases for 99% of 3rd part themes.

          Ciao

          Just perhaps it would be worth adding one more step to the process:

          6) Comment in the release notes about how the change has been performed for all core themes, and heads-up 3rd part themes in case they need to review and/or add the same type of patch to their theme layouts (if the are using them). The patch for each layout is really simple.

          Show
          Eloy Lafuente (stronk7) added a comment - - edited As commented above, this patch fixes RTL for all core themes, so no problems with that. And also, related with 3rd part themes it causes one of these behaviors: A) If the 3rd part theme had inherited layouts from parent (core) theme, then they will get their RTL problems under IE automatically fixed. B) If the 3rd part theme had own defined layout, it will continue behaving 100% like it was before the patch. Not affected. So I think that both possible behaviors are ok to be assumed by default. I don't think there are more cases for 99% of 3rd part themes. Ciao Just perhaps it would be worth adding one more step to the process: 6) Comment in the release notes about how the change has been performed for all core themes, and heads-up 3rd part themes in case they need to review and/or add the same type of patch to their theme layouts (if the are using them). The patch for each layout is really simple.
          Hide
          Nadav Kavalerchik added a comment -

          Thank you

          Show
          Nadav Kavalerchik added a comment - Thank you
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Uhm, finally I got here IE7, IE8, FF, Safari and Chrome.

          And before sending anything to integration, I applied locally the patch and started testing. And there is something that, after testing some themes, was detected:

          • Without the patch applied, master branch
          • Set the theme to base (via URL): htttp://yoursite/?theme=base
          • Set to ltr language and login.
          • With all browsers go to the outline report: htttp://yoursite/report/outline/index.php?id=1
          • In ALL browsers, you'll see the navigation and settings blocks on the left.
          • Switch to rtl language
          • Refresh the report page. You'll continue viewing the navigation and setting blocks (now on the right) in ALL browsers (IE7 included, imperfectly but they are there)
          • Apply the patch (master)
          • Refresh the report page.
          • BOOM, the blocks have disappeared completely, BOTH in IE7 and IE8! But... also from Safari, FF and Chrome!

          The other 2 pages seems to work consistently (index and login), but the report one, as said, is really worse once the patch is applied, and affects all browsers.

          I've been able to reproduce this wrong behavior in: base, standard, anomaly, boxxie, canvas...

          In others I see how the blocks are there, on the right, but 90% offscreen: arialist, binarius, formfactor...

          More yet, others get the blocks perfectly in: brick, formal_white (but on the left)...

          And I've stopped there, something seems to be wrong in the report page layout and the patch makes it really worse, affecting ALL browsers.

          So I think this only can be rejected, sorry. Ciao.

          Show
          Eloy Lafuente (stronk7) added a comment - Uhm, finally I got here IE7, IE8, FF, Safari and Chrome. And before sending anything to integration, I applied locally the patch and started testing. And there is something that, after testing some themes, was detected: Without the patch applied, master branch Set the theme to base (via URL): htttp://yoursite/?theme=base Set to ltr language and login. With all browsers go to the outline report: htttp://yoursite/report/outline/index.php?id=1 In ALL browsers, you'll see the navigation and settings blocks on the left. Switch to rtl language Refresh the report page. You'll continue viewing the navigation and setting blocks (now on the right) in ALL browsers (IE7 included, imperfectly but they are there) Apply the patch (master) Refresh the report page. BOOM, the blocks have disappeared completely, BOTH in IE7 and IE8! But... also from Safari, FF and Chrome! The other 2 pages seems to work consistently (index and login), but the report one, as said, is really worse once the patch is applied, and affects all browsers. I've been able to reproduce this wrong behavior in: base, standard, anomaly, boxxie, canvas... In others I see how the blocks are there, on the right, but 90% offscreen: arialist, binarius, formfactor... More yet, others get the blocks perfectly in: brick, formal_white (but on the left)... And I've stopped there, something seems to be wrong in the report page layout and the patch makes it really worse, affecting ALL browsers. So I think this only can be rejected, sorry. Ciao.
          Hide
          Mary Evans added a comment -

          Hi Eloy,

          Dietmar and myself have found that there are some potential problems with report and pagelayout as there are only 8 themes which actually use theme/base/style/pagelayout.css as some themes exclude it because they use a different pagelayout/ These themes are Afterburner, Magazine, Sky High, Nonzero and Overlay.

          MDL-29904 outlines some problems we have found along these lines and this has in itself opened up a host of other issues mainly with pagelayout in some themes.

          Dietmar and myself are questioning if BASE and CANVAS (parent themes) are actually causing the problems.

          But it is a great pity that these patches are rejected based on your testing.

          Mary

          Show
          Mary Evans added a comment - Hi Eloy, Dietmar and myself have found that there are some potential problems with report and pagelayout as there are only 8 themes which actually use theme/base/style/pagelayout.css as some themes exclude it because they use a different pagelayout/ These themes are Afterburner, Magazine, Sky High, Nonzero and Overlay. MDL-29904 outlines some problems we have found along these lines and this has in itself opened up a host of other issues mainly with pagelayout in some themes. Dietmar and myself are questioning if BASE and CANVAS (parent themes) are actually causing the problems. But it is a great pity that these patches are rejected based on your testing. Mary
          Hide
          Martin Dougiamas added a comment -

          Mary, are you able to continue testing and analysis to try and narrow the issues here? Can you bring in anyone else from NewSchool?

          Show
          Martin Dougiamas added a comment - Mary, are you able to continue testing and analysis to try and narrow the issues here? Can you bring in anyone else from NewSchool?
          Hide
          Mary Evans added a comment -

          Hi Martin,

          I have been thinking about the problems here for a long time, and my conclusion is not to change anything in the standard core themes for IE7 but to create a new layout which WILL work in that scenario. I am sure there are people like Nadav who would be willing to style a new parent theme purely for RTL. I know for a fact the HolyGrail Percentage layout works better in this senario, which I was trying to do with my Cafelite theme from the start. http://visible-expression.co.uk/sandbox/?theme=cafelite but ran into problems as I don't have IE7 now, although I do have IE6 on a laptop. But yes I am willing to help with this...but to be truthful you can analyse it till you are blue in the face...and not realy get anywhere as the face of Moodle is changing so rapidly.

          I'll talk with Patrick, but I doubt whether he has the time, as his workload is pretty manic, from what I can gather. I am not too sure about John either, as he also has a pretty tight work schedule, but I will ask and see what can be done.

          Thanks

          Mary

          Show
          Mary Evans added a comment - Hi Martin, I have been thinking about the problems here for a long time, and my conclusion is not to change anything in the standard core themes for IE7 but to create a new layout which WILL work in that scenario. I am sure there are people like Nadav who would be willing to style a new parent theme purely for RTL. I know for a fact the HolyGrail Percentage layout works better in this senario, which I was trying to do with my Cafelite theme from the start. http://visible-expression.co.uk/sandbox/?theme=cafelite but ran into problems as I don't have IE7 now, although I do have IE6 on a laptop. But yes I am willing to help with this...but to be truthful you can analyse it till you are blue in the face...and not realy get anywhere as the face of Moodle is changing so rapidly. I'll talk with Patrick, but I doubt whether he has the time, as his workload is pretty manic, from what I can gather. I am not too sure about John either, as he also has a pretty tight work schedule, but I will ask and see what can be done. Thanks Mary
          Hide
          Nadav Kavalerchik added a comment -

          I agree with Mary. And after talking to fellow Moodle administrators I would also like to add...

          The IE7 user base is shrinking in Israel (as far as the global stats show:http://gs.statcounter.com/#browser_version-IL-monthly-201004-201103 ) Users of IE7, in the educational sector, that are not upgrading to IE8 or other modern browsers because of old Educational web services that they depend on and use, daily, which do not support W3C standards are dissolving, rapidly.

          Basically, users of IE7 can upgrade to IE8 and still have "compatibility mode" (IE7 mode) to view some specific (educational dependent) websites. More over, I predict a major Moodle 2 install (shift from Moodle 1.9) at the end of this academic and K12 year. by that time and according to the IE7 dissolvement trend, I do not see the necessity to integrate support for IE7 inside core Moodle themes which will make the CSS more "heavy" for no good reason.

          So basically, let's not adjust the core themes. Instead, let's make a single base theme for the RTL users of IE7/8 like Mary suggested.

          I(We) thank Mary for all the efforts and help she invested in those issues and helped us solve these problems. I would not like to see it dissolved.

          Show
          Nadav Kavalerchik added a comment - I agree with Mary. And after talking to fellow Moodle administrators I would also like to add... The IE7 user base is shrinking in Israel (as far as the global stats show: http://gs.statcounter.com/#browser_version-IL-monthly-201004-201103 ) Users of IE7, in the educational sector, that are not upgrading to IE8 or other modern browsers because of old Educational web services that they depend on and use, daily, which do not support W3C standards are dissolving, rapidly. Basically, users of IE7 can upgrade to IE8 and still have "compatibility mode" (IE7 mode) to view some specific (educational dependent) websites. More over, I predict a major Moodle 2 install (shift from Moodle 1.9) at the end of this academic and K12 year. by that time and according to the IE7 dissolvement trend, I do not see the necessity to integrate support for IE7 inside core Moodle themes which will make the CSS more "heavy" for no good reason. So basically, let's not adjust the core themes. Instead, let's make a single base theme for the RTL users of IE7/8 like Mary suggested. I(We) thank Mary for all the efforts and help she invested in those issues and helped us solve these problems. I would not like to see it dissolved.
          Hide
          Richard Oelmann added a comment - - edited

          +1 for Mary's comment
          I understand from previous comments in the thread that Mary's cafelite layout went back to Matthew James Taylor's original layout as a base, I did the same with my recent multilayout theme and both of those (by removing the base theme pagelayout.css) appear to work in IE7/rtl - @Mary, I did some (light) testing of your sandbox site on IE7 when I was doing multithemed and it came up in one of the forum discussions.
          So I would recommend Mary's solution of providing a base-like 'empty' theme with layout files which work correctly for rtl/IE7 and this can then be styled on top as a parent theme in the same way as Canvas/Base etc.

          Happy to help out with any testing, or contributing to the theme(s) to get this happening, just let me know what needs doing

          Richard

          Show
          Richard Oelmann added a comment - - edited +1 for Mary's comment I understand from previous comments in the thread that Mary's cafelite layout went back to Matthew James Taylor's original layout as a base, I did the same with my recent multilayout theme and both of those (by removing the base theme pagelayout.css) appear to work in IE7/rtl - @Mary, I did some ( light ) testing of your sandbox site on IE7 when I was doing multithemed and it came up in one of the forum discussions. So I would recommend Mary's solution of providing a base-like 'empty' theme with layout files which work correctly for rtl/IE7 and this can then be styled on top as a parent theme in the same way as Canvas/Base etc. Happy to help out with any testing, or contributing to the theme(s) to get this happening, just let me know what needs doing Richard
          Hide
          Mary Evans added a comment - - edited

          @Dietmar

          I just added you as a watcher knowing how much you learnt with Cafelite last year!

          The proposal is to create a new parent theme with one difference it will be only designed with RTL languages in mind. So whatever is left will be right, and via-versa.

          It is going to be a steep learning curve but I am, perhaps naively, hopeful it will be successful, if it is accepted.

          Cheers
          Mary

          PS...It needs to work in IE7

          Show
          Mary Evans added a comment - - edited @Dietmar I just added you as a watcher knowing how much you learnt with Cafelite last year! The proposal is to create a new parent theme with one difference it will be only designed with RTL languages in mind. So whatever is left will be right, and via-versa. It is going to be a steep learning curve but I am, perhaps naively, hopeful it will be successful, if it is accepted. Cheers Mary PS...It needs to work in IE7
          Hide
          Dietmar Wagner added a comment -

          Hi all,

          after several tests I would like to recommend Mary's conclusion in as much as we will only get a working rtl theme if we use percentages for measuring the widths of the regions. And perhaps we need a new parent theme (or additional core themes like Mary's CAFEL(R)ITE) as the only core theme that uses percentages is MAGAZINE. But I'm not quite sure about that.

          In the moment I would like to start with core theme MAGAZINE and look what's possible.

          I see the following two options for making MAGAZINE rtl compatible:

          1) Add

          • the line .dir-rtl html {overflow-x: hidden;}

            to the pagelayout.css (or core.css) [Yedidia's idea, 11/March/11]

          • the file afterburner/style/rtl.css to the directory magazine/style/ and
          • rtl to the theme sheets in config.php.
            and ... I think theme MAGAZINE now works for ltr as well as for rtl. I hope so!!!

          2) Move the custommenu from the header to the main-content and magazine again seems to work for both directions (rtl.css should be added again):

          <div id="region-main-wrap">
          <div id="region-main">
          <div class="region-content">

          <?php if ($hascustommenu)

          { ?> <div id="custommenuwrap"><div id="custommenu"><?php echo $custommenu; ?></div></div> <?php }

          ?>
          <?php echo core_renderer::MAIN_CONTENT_TOKEN ?>
          </div>

          If the necessary tests are successfull we are only two steps away from a solution. All kinds of ideas, feedbacks and test results are as always very much appreciated.

          Cheers
          Dietmar

          @Mary: I tested your theme C (on 2.1) and I (still) love it. After including a custommenu - just below the HAEDER - I got the scrollbar at the bottom as expected. It vanished after adding html

          {overflow-x: hidden;}

          to CSS.

          Show
          Dietmar Wagner added a comment - Hi all, after several tests I would like to recommend Mary's conclusion in as much as we will only get a working rtl theme if we use percentages for measuring the widths of the regions. And perhaps we need a new parent theme (or additional core themes like Mary's CAFEL(R)ITE) as the only core theme that uses percentages is MAGAZINE. But I'm not quite sure about that. In the moment I would like to start with core theme MAGAZINE and look what's possible. I see the following two options for making MAGAZINE rtl compatible: 1) Add the line .dir-rtl html {overflow-x: hidden;} to the pagelayout.css (or core.css) [Yedidia's idea, 11/March/11] the file afterburner/style/rtl.css to the directory magazine/style/ and rtl to the theme sheets in config.php. and ... I think theme MAGAZINE now works for ltr as well as for rtl. I hope so!!! 2) Move the custommenu from the header to the main-content and magazine again seems to work for both directions (rtl.css should be added again): <div id="region-main-wrap"> <div id="region-main"> <div class="region-content"> <?php if ($hascustommenu) { ?> <div id="custommenuwrap"><div id="custommenu"><?php echo $custommenu; ?></div></div> <?php } ?> <?php echo core_renderer::MAIN_CONTENT_TOKEN ?> </div> If the necessary tests are successfull we are only two steps away from a solution. All kinds of ideas, feedbacks and test results are as always very much appreciated. Cheers Dietmar @Mary: I tested your theme C (on 2.1) and I (still) love it. After including a custommenu - just below the HAEDER - I got the scrollbar at the bottom as expected. It vanished after adding html {overflow-x: hidden;} to CSS.
          Hide
          Mary Evans added a comment -

          This is great news Dietmar! Thanks for that.
          I wonder if we could rope John in at this point as he put the magazine theme together, as if you remember we where bother working with that percentage layout last year.

          The fact that Magazine uses Base as a parent is hopeful too as this will enable it to pick up all the RTL fixes Nadav is working on.

          Thanks again for all your help Dietmar.

          Cheers
          Mary

          Show
          Mary Evans added a comment - This is great news Dietmar! Thanks for that. I wonder if we could rope John in at this point as he put the magazine theme together, as if you remember we where bother working with that percentage layout last year. The fact that Magazine uses Base as a parent is hopeful too as this will enable it to pick up all the RTL fixes Nadav is working on. Thanks again for all your help Dietmar. Cheers Mary
          Hide
          Mary Evans added a comment - - edited

          @Martin,

          I have created a theme which will work both in RTL as well as LTR languages as well as work in IE7. The main objective of this theme, which I have called RTLBase (rtlbase), is for it to become a parent theme for RTL themes.

          RTLBase is based on Matthew James Taylor's Holy Grail percentage layout, and as such works well in Moodle 2.2(beta) and earlier.

          RTLBase uses Base as a parent theme, from where it draws most of the core CSS plus much of the RTL which is currently being updated by Nadav Kavalerchik.

          RTLBase is pretty minimalist in appearance but could be restyled to become a Default theme for Moodle 2.2 as it works well in both LTR & RTL.

          With your permission I would like to submit it for Peer Review.

          Special thanks and acknowledgments to Dietmar Wagner for his constant help in testing and finding solutions which has made this theme possible.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited @Martin, I have created a theme which will work both in RTL as well as LTR languages as well as work in IE7. The main objective of this theme, which I have called RTLBase (rtlbase), is for it to become a parent theme for RTL themes. RTLBase is based on Matthew James Taylor's Holy Grail percentage layout, and as such works well in Moodle 2.2(beta) and earlier. RTLBase uses Base as a parent theme, from where it draws most of the core CSS plus much of the RTL which is currently being updated by Nadav Kavalerchik. RTLBase is pretty minimalist in appearance but could be restyled to become a Default theme for Moodle 2.2 as it works well in both LTR & RTL. With your permission I would like to submit it for Peer Review. Special thanks and acknowledgments to Dietmar Wagner for his constant help in testing and finding solutions which has made this theme possible. Thanks Mary
          Hide
          moodle.com added a comment -

          Taking this out of the sprint and assigning to our wonderful theme masters.

          Show
          moodle.com added a comment - Taking this out of the sprint and assigning to our wonderful theme masters.
          Hide
          Mary Evans added a comment -

          Thanks Moodle.com!

          Show
          Mary Evans added a comment - Thanks Moodle.com!
          Hide
          Mary Evans added a comment - - edited

          I'm going to submit a new theme for consideration as the basis for development of RTL themes for Moodle 2.3.x. The theme itself is called base_rtl

          Show
          Mary Evans added a comment - - edited I'm going to submit a new theme for consideration as the basis for development of RTL themes for Moodle 2.3.x. The theme itself is called base_rtl
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          Please add me to the watch list for that new themes you are uploading

          Show
          Nadav Kavalerchik added a comment - @Mary Please add me to the watch list for that new themes you are uploading
          Hide
          Mary Evans added a comment - - edited

          Hi Nadav,

          It is the BASE-RTL I am going to submit for Peer Review first. So perhaps you can let me have some feedback after I add it here in MDL-26400 this weekend. OK?

          Initially it is for Moodle 2.3, but it will work in Moodle 2.2.x and Moodle 2.1.x in IE7 & IE8 so if it passes Peer Review and Testing (if Integrated) then it can be added to Moodle 2.1.x & Moodle 2.2.x if Martin wishes it so.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited Hi Nadav, It is the BASE-RTL I am going to submit for Peer Review first. So perhaps you can let me have some feedback after I add it here in MDL-26400 this weekend. OK? Initially it is for Moodle 2.3, but it will work in Moodle 2.2.x and Moodle 2.1.x in IE7 & IE8 so if it passes Peer Review and Testing (if Integrated) then it can be added to Moodle 2.1.x & Moodle 2.2.x if Martin wishes it so. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Great, I will test it.

          Show
          Nadav Kavalerchik added a comment - Great, I will test it.
          Hide
          Mary Evans added a comment -

          @Nadav
          Over to you...

          I'm not expectiing too many things to be wrong with this theme, but if you can Peer Review it that would be great.
          Cheers
          Mary

          Show
          Mary Evans added a comment - @Nadav Over to you... I'm not expectiing too many things to be wrong with this theme, but if you can Peer Review it that would be great. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          Got it

          Show
          Nadav Kavalerchik added a comment - @Mary Got it
          Hide
          Nadav Kavalerchik added a comment -

          @Mary

          I have copied your base_rtl into my updated (last week) Moodle 2.3 devel tree
          and changed standard/config.php to use base_rtl (from using base)

          When i am viewing a regular Hebrew content course, i get allot of visual issues.
          Am i using/testing it correctly?

          Show
          Nadav Kavalerchik added a comment - @Mary I have copied your base_rtl into my updated (last week) Moodle 2.3 devel tree and changed standard/config.php to use base_rtl (from using base) When i am viewing a regular Hebrew content course, i get allot of visual issues. Am i using/testing it correctly?
          Hide
          Mary Evans added a comment -

          Hi Nadav,
          No you have this all wrong. Base-RTL is a theme on it's own, the pagelayout is completely different than Base theme which Standard theme is based on. All the CSS in standard is for the pagelayout of base theme, not Base-RTL. Just try using Base-RTL on it's own.

          Because Base-RTL is hidden, by default, from the Theme selector, you will either need to change the settings in the base_rtl/config.php so you can un-hide this theme or you will need to enable Theme designer mode in theme settings otherwise you can't see it in the selector.

          Also...have you seen the test Instruction in the top half of MDL-26400 Moodle Tracker page?

          Thanks again for testing this.

          Mary

          Show
          Mary Evans added a comment - Hi Nadav, No you have this all wrong. Base-RTL is a theme on it's own, the pagelayout is completely different than Base theme which Standard theme is based on. All the CSS in standard is for the pagelayout of base theme, not Base-RTL. Just try using Base-RTL on it's own. Because Base-RTL is hidden, by default, from the Theme selector, you will either need to change the settings in the base_rtl/config.php so you can un-hide this theme or you will need to enable Theme designer mode in theme settings otherwise you can't see it in the selector. Also...have you seen the test Instruction in the top half of MDL-26400 Moodle Tracker page? Thanks again for testing this. Mary
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary

          Looks much better, after i read your comment

          Show
          Nadav Kavalerchik added a comment - Hi Mary Looks much better, after i read your comment
          Hide
          Nadav Kavalerchik added a comment -

          base_rtl - Hebrew Translation
          https://github.com/nadavkav/moodle/commit/627c1451abf76c9a720ec7b39a40d46674f51fba

          base_rtl - MDL-31777 - Switch block's columns when course is set to RTL Mode (patch)
          https://github.com/nadavkav/moodle/commit/4d21d4b8ba24c2942db87498014add5f7e7fa683
          ( I had to use that patch, since the columns were not switched, as expected, in RTL mode )

          Show
          Nadav Kavalerchik added a comment - base_rtl - Hebrew Translation https://github.com/nadavkav/moodle/commit/627c1451abf76c9a720ec7b39a40d46674f51fba base_rtl - MDL-31777 - Switch block's columns when course is set to RTL Mode (patch) https://github.com/nadavkav/moodle/commit/4d21d4b8ba24c2942db87498014add5f7e7fa683 ( I had to use that patch, since the columns were not switched, as expected, in RTL mode )
          Hide
          Mary Evans added a comment -

          Well I know it's not going to look good in some pages, but I know it looks OK on most pages.

          Show
          Mary Evans added a comment - Well I know it's not going to look good in some pages, but I know it looks OK on most pages.
          Hide
          Nadav Kavalerchik added a comment -

          MDL-26400 - base_rtl theme - right align activity completion checkboxes (in RTL mode)
          https://github.com/nadavkav/moodle/commit/4f6a80e866459f1a5dc970f3e57c370993f8bec5

          Show
          Nadav Kavalerchik added a comment - MDL-26400 - base_rtl theme - right align activity completion checkboxes (in RTL mode) https://github.com/nadavkav/moodle/commit/4f6a80e866459f1a5dc970f3e57c370993f8bec5
          Hide
          Mary Evans added a comment -

          I'm just committed these changes.
          However, what about report.php you missed that off in your base theme changes.

          Show
          Mary Evans added a comment - I'm just committed these changes. However, what about report.php you missed that off in your base theme changes.
          Hide
          Mary Evans added a comment -

          I think there is going to be a conflict with the report page, more in the way it is styled rather than the layout, although that will have some bearing on it eventually.

          For the tie being I have saved a copy of general.php as report.php to see how that works.

          More later

          Show
          Mary Evans added a comment - I think there is going to be a conflict with the report page, more in the way it is styled rather than the layout, although that will have some bearing on it eventually. For the tie being I have saved a copy of general.php as report.php to see how that works. More later
          Hide
          Nadav Kavalerchik added a comment -

          yes, i left the report out. since i was not sure if the "switch columns" patch is good.
          here is a little different patch for the report.php
          https://github.com/nadavkav/moodle/commit/8219a27bb7fef56dbfc48b11f05ed32a22a34e6d

          MDL-26400 - base_rtl theme - right align the DOCK panel (in RTL mode)
          https://github.com/nadavkav/moodle/commit/f9972f861c76db750bfb8402fd3e4754a4ff96c8

          MDL-26400 - base_rtl theme - right align menu element (in RTL mode)
          https://github.com/nadavkav/moodle/commit/b78ee76f97e8941621543721ffb69fae0ff7c12d

          I am wondering if you are ok with removing the following css rules from #page
          width: 95%;
          margin: 2% auto;

          Show
          Nadav Kavalerchik added a comment - yes, i left the report out. since i was not sure if the "switch columns" patch is good. here is a little different patch for the report.php https://github.com/nadavkav/moodle/commit/8219a27bb7fef56dbfc48b11f05ed32a22a34e6d MDL-26400 - base_rtl theme - right align the DOCK panel (in RTL mode) https://github.com/nadavkav/moodle/commit/f9972f861c76db750bfb8402fd3e4754a4ff96c8 MDL-26400 - base_rtl theme - right align menu element (in RTL mode) https://github.com/nadavkav/moodle/commit/b78ee76f97e8941621543721ffb69fae0ff7c12d I am wondering if you are ok with removing the following css rules from #page width: 95%; margin: 2% auto;
          Hide
          Mary Evans added a comment -

          Yes sure...you can change #page width to whatever you think best, probably width: 100%; margin: 0;

          I agree too with Report changes, custom menu also to float right. I am concerned about getting the menu to work properly, I found it really difficult when I tried it that's why it was on the left side by default. It's strange as I got this to work in Moodle 1.9 but YUI CSS was a different build in 1.9.

          I was not sure if you needed dock on left or right....so the change there I approve of too. Thanks for taking time to fix these.


          Mary

          Show
          Mary Evans added a comment - Yes sure...you can change #page width to whatever you think best, probably width: 100%; margin: 0; I agree too with Report changes, custom menu also to float right. I am concerned about getting the menu to work properly, I found it really difficult when I tried it that's why it was on the left side by default. It's strange as I got this to work in Moodle 1.9 but YUI CSS was a different build in 1.9. I was not sure if you needed dock on left or right....so the change there I approve of too. Thanks for taking time to fix these. Mary
          Hide
          Nadav Kavalerchik added a comment -

          Great!

          I am stuck with figuring out the YUI3 menu
          Maybe, it is best to move it back to the left? for now.
          (until someone figure it out - make it work in RTL mode)

          Show
          Nadav Kavalerchik added a comment - Great! I am stuck with figuring out the YUI3 menu Maybe, it is best to move it back to the left? for now. (until someone figure it out - make it work in RTL mode)
          Hide
          Mary Evans added a comment - - edited

          The alternative to the menu is to use the same one that is in Afterburner, this uses renderers.php which change the way the menu is set which gives you a better way of styling the menu.

          I'll have a play with this and see how I get on.

          You might as well leave the code in for float: right for the menu because that' where we want it. If you check out Magazine theme the styling for the YUI menu works as you want it to on the right and dropdown open to left which is how it should work. But this reverses in RTL, but even so, there may be a way to style YUI Menu, or we change it to use renderers. We will get it to work eventually.

          Show
          Mary Evans added a comment - - edited The alternative to the menu is to use the same one that is in Afterburner, this uses renderers.php which change the way the menu is set which gives you a better way of styling the menu. I'll have a play with this and see how I get on. You might as well leave the code in for float: right for the menu because that' where we want it. If you check out Magazine theme the styling for the YUI menu works as you want it to on the right and dropdown open to left which is how it should work. But this reverses in RTL, but even so, there may be a way to style YUI Menu, or we change it to use renderers. We will get it to work eventually.
          Hide
          Mary Evans added a comment -

          Just this minute pushed commit: MDL-26400 theme_base_rtl: Added fixes for RTL custom menu. to my GITHUB. It still needs some work, but is looking better.

          Show
          Mary Evans added a comment - Just this minute pushed commit: MDL-26400 theme_base_rtl: Added fixes for RTL custom menu. to my GITHUB. It still needs some work, but is looking better.
          Hide
          Mary Evans added a comment -

          Just pushed report fixes to GITHUB

          Thanks for all these extra fixes Nadav you are a star!

          Show
          Mary Evans added a comment - Just pushed report fixes to GITHUB Thanks for all these extra fixes Nadav you are a star!
          Hide
          Nadav Kavalerchik added a comment -

          I am blushing ("Blushing refers to the involuntary reddening of a person's face due to embarrassment" / Wikipedia)

          Show
          Nadav Kavalerchik added a comment - I am blushing ("Blushing refers to the involuntary reddening of a person's face due to embarrassment" / Wikipedia)
          Hide
          Mary Evans added a comment -

          Have you had time to test the custom menu? It works in IE7 (using IE9 browser set to IE7 browser & IE7 document standards settings in F12 Web Developer). At one point it looked better, but then the dropdown menu worked in one section but not another...very odd. I think it is YUICSS it really does some odd thing...too many CSS selectors for my liking.

          But at least the float right works and the dropdown opends to the left...so this is an achievement.

          Show
          Mary Evans added a comment - Have you had time to test the custom menu? It works in IE7 (using IE9 browser set to IE7 browser & IE7 document standards settings in F12 Web Developer). At one point it looked better, but then the dropdown menu worked in one section but not another...very odd. I think it is YUICSS it really does some odd thing...too many CSS selectors for my liking. But at least the float right works and the dropdown opends to the left...so this is an achievement.
          Hide
          Mary Evans added a comment -

          Nadav,

          I found a couple of errors in the code I committed yesterday and so corrected these and pushed them to my GITHUB in the early hours of the this morning before I logged out.

          I'll be testing this again later today, but would love some feedback if you get time to review what I have done so far?

          Thanks
          Mary

          Show
          Mary Evans added a comment - Nadav, I found a couple of errors in the code I committed yesterday and so corrected these and pushed them to my GITHUB in the early hours of the this morning before I logged out. I'll be testing this again later today, but would love some feedback if you get time to review what I have done so far? Thanks Mary
          Hide
          Nadav Kavalerchik added a comment -

          Mary,

          I have finished testing your updated base_rtl theme against the entire system.
          It looks properly (Beautifully) aligned and can be the base of more complex RTL themes. GREAT WORK !!!
          (got it from your github as of : https://github.com/lazydaisy/moodle/commit/0ec6c9c32fd8800c585f35df98c96b838afe6e79 )

          Here are my tiny additions on top of yours:
          https://github.com/nadavkav/moodle/commit/78387499b35322b71482be6fd732c6a78011b68c
          (It is a little bit mixed with yours, since I committed them together by mistake)

          1. added hacky css rules to have the menu and sub menus visible ( you are welcome to fix those !important rules )
          2. added missing images (weird)
          3. removed underline dashed links
          4. removed redundant php code that added dir-rtl class to custommenu (we already have dir-rtl in rtl mode, so i changed all the css rules in rtl_menu too)
          5. some rtl box, table and table cells alignments
          6. $bodyclasses[] right_to_left() manipulations (for pages with only one side of block columns)

          Please ignore my personal UI css roles at theme/base_rtl/style/core.css
          under the remark "add some visual borders to make the course more usable"
          which are committed out of the code. (as they should be)

          Happy Holidays
          Nadav

          Show
          Nadav Kavalerchik added a comment - Mary, I have finished testing your updated base_rtl theme against the entire system. It looks properly (Beautifully) aligned and can be the base of more complex RTL themes. GREAT WORK !!! (got it from your github as of : https://github.com/lazydaisy/moodle/commit/0ec6c9c32fd8800c585f35df98c96b838afe6e79 ) Here are my tiny additions on top of yours: https://github.com/nadavkav/moodle/commit/78387499b35322b71482be6fd732c6a78011b68c (It is a little bit mixed with yours, since I committed them together by mistake) added hacky css rules to have the menu and sub menus visible ( you are welcome to fix those !important rules ) added missing images (weird) removed underline dashed links removed redundant php code that added dir-rtl class to custommenu (we already have dir-rtl in rtl mode, so i changed all the css rules in rtl_menu too) some rtl box, table and table cells alignments $bodyclasses[] right_to_left() manipulations (for pages with only one side of block columns) Please ignore my personal UI css roles at theme/base_rtl/style/core.css under the remark "add some visual borders to make the course more usable" which are committed out of the code. (as they should be) Happy Holidays Nadav
          Hide
          Mary Evans added a comment -

          Nadav,
          This is all music to my ears!

          Thank you for making these finishing touches.
          I think I will now create a sub-task of MDL-26400 to add base_rtl as a new theme, then it leaves MDL-26400 free and if the theme is accepted and integrated to 2.3 we can close this MDL as it serves as a reminder of the discussions which went on here.

          Happy Holidays to you too Nadav!
          and Many, many thanks.

          Mary

          Show
          Mary Evans added a comment - Nadav, This is all music to my ears! Thank you for making these finishing touches. I think I will now create a sub-task of MDL-26400 to add base_rtl as a new theme, then it leaves MDL-26400 free and if the theme is accepted and integrated to 2.3 we can close this MDL as it serves as a reminder of the discussions which went on here. Happy Holidays to you too Nadav! and Many, many thanks. Mary
          Hide
          Mary Evans added a comment -

          Hi,

          Is there a way I can copy this commit to merge into my GitHub MDL-26400_master branch.
          I'm still learning GIT and can do most things, but this one is new to me as this commit does not seem to be on a branch.

          Help!

          Mary

          Show
          Mary Evans added a comment - Hi, Is there a way I can copy this commit to merge into my GitHub MDL-26400 _master branch. I'm still learning GIT and can do most things, but this one is new to me as this commit does not seem to be on a branch. Help! Mary
          Hide
          Nadav Kavalerchik added a comment -

          Mary,
          I still about to fix all the core themes, regarding the "RTL mode, column switch" and some minor theme specific CSS rules for RTL
          and Commit it in one big patch. regardless the new base_rtl theme. Is that OK? (with you and with Moodle HQ)

          Show
          Nadav Kavalerchik added a comment - Mary, I still about to fix all the core themes, regarding the "RTL mode, column switch" and some minor theme specific CSS rules for RTL and Commit it in one big patch. regardless the new base_rtl theme. Is that OK? (with you and with Moodle HQ)
          Hide
          Mary Evans added a comment - - edited

          Hi Nadav,

          If you are intending to change ALL core THEMES individually, to make the column switch the same way it has been done in BASE-RTL, that's great!

          The only reason I am submitting BASE-RTL is that it works in IE7 where CORE themes don't, other than perhaps Magazine theme, but that was built on an earlier version of this theme which I first built two years ago, called Cafelite. It uses the percentage layout, rather than the fixed values of core themes and so is built completely differently.

          However, whatever commits you make to Moodle themes are nothing to do with me, I only do what I do as a volunteer, I don't work for HQ, although I get the feeling you think I do.

          You will need to talk with Sam Hemelryk about this. But I have no objection to your proposed work adding more RTL fixes. If BASE-RTL is not required then it will become a FREE theme to download, either way it will be a Moodle theme people can modify.

          Does that answer you question?

          Thanks for all the support you give for getting Moodle fixed for RTL languages.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited Hi Nadav, If you are intending to change ALL core THEMES individually, to make the column switch the same way it has been done in BASE-RTL, that's great! The only reason I am submitting BASE-RTL is that it works in IE7 where CORE themes don't, other than perhaps Magazine theme, but that was built on an earlier version of this theme which I first built two years ago, called Cafelite. It uses the percentage layout, rather than the fixed values of core themes and so is built completely differently. However, whatever commits you make to Moodle themes are nothing to do with me, I only do what I do as a volunteer, I don't work for HQ, although I get the feeling you think I do. You will need to talk with Sam Hemelryk about this. But I have no objection to your proposed work adding more RTL fixes. If BASE-RTL is not required then it will become a FREE theme to download, either way it will be a Moodle theme people can modify. Does that answer you question? Thanks for all the support you give for getting Moodle fixed for RTL languages. Cheers Mary
          Hide
          Yedidia Klein added a comment -

          I agree with nadav that changing all themes will be great...
          We (Atar + Plus Company) could also help with css writing and testing.

          Yedidia

          Show
          Yedidia Klein added a comment - I agree with nadav that changing all themes will be great... We (Atar + Plus Company) could also help with css writing and testing. Yedidia
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary,

          I am part of the Israeli Moodle Translation team which is funded by the Israeli ISOC to do just that. (Translate and fix RTL and BIDI issues in Moodle's core)

          Indeed, I was under the impression that you work at Moodle HQ and responsible to the "themes" plugins. none the less, I am very happy for your huge support to us (the RTL world wide community)

          I regard the very important "base_rtl theme" to be a grace present and last support effort to all those people who have difficulties upgrading their IE7 browser to a more modern version of IE (currently 9 and soon...10) due to various dependency issue with old educational websites and service. (Though, they probably should be use IETAB with Chrome or Firefox)
          I know of two Universities that were anxiously waiting for base_rtl and I guess the other five are also in the same boat (Yedidia, which supports all of them, can probably confirm this) not counting the Teacher Training collages and K12 sectors...

          Back to "business"...
          I am about to open a new RTL Theme issue as sub task to the famous Meta RTL Themes into which i will link a new git branch with all the accumulating commits for each theme i fix (considering all the updated CSS rules and php code from base_rtl which we know to work) that way, it can be merged entirely or each theme can be cherry picked
          I would LOVE to get Your and Yedidia's feedback on them as they show up.
          What do you think?

          Show
          Nadav Kavalerchik added a comment - Hi Mary, I am part of the Israeli Moodle Translation team which is funded by the Israeli ISOC to do just that. (Translate and fix RTL and BIDI issues in Moodle's core) Indeed, I was under the impression that you work at Moodle HQ and responsible to the "themes" plugins. none the less, I am very happy for your huge support to us (the RTL world wide community) I regard the very important "base_rtl theme" to be a grace present and last support effort to all those people who have difficulties upgrading their IE7 browser to a more modern version of IE (currently 9 and soon...10) due to various dependency issue with old educational websites and service. (Though, they probably should be use IETAB with Chrome or Firefox) I know of two Universities that were anxiously waiting for base_rtl and I guess the other five are also in the same boat (Yedidia, which supports all of them, can probably confirm this) not counting the Teacher Training collages and K12 sectors... Back to "business"... I am about to open a new RTL Theme issue as sub task to the famous Meta RTL Themes into which i will link a new git branch with all the accumulating commits for each theme i fix (considering all the updated CSS rules and php code from base_rtl which we know to work) that way, it can be merged entirely or each theme can be cherry picked I would LOVE to get Your and Yedidia's feedback on them as they show up. What do you think?
          Hide
          Yedidia Klein added a comment -

          Nadav,

          Thanks for all this nice work.
          As I already wrote - we will be happy to help in tests, and we could also help in CSS work.

          Just let me know.. you know how to find me

          Cheers,

          --Y

          Show
          Yedidia Klein added a comment - Nadav, Thanks for all this nice work. As I already wrote - we will be happy to help in tests, and we could also help in CSS work. Just let me know.. you know how to find me Cheers, --Y
          Hide
          Mary Evans added a comment -

          Nadav,

          What Yedidia said goes for me too!
          I'll be watching out for this new initiative, and will willingly give you feedback, and any assistance you may need with this.

          Best wishes and thanks
          Mary

          Show
          Mary Evans added a comment - Nadav, What Yedidia said goes for me too! I'll be watching out for this new initiative, and will willingly give you feedback, and any assistance you may need with this. Best wishes and thanks Mary
          Hide
          Mary Evans added a comment - - edited

          Just linked MDL-32959 Convert BASE theme layout to Perfect Holy Grail Percentage Layout.

          By converting Base theme whilst preserving the layouts of all CORE themes, the only ones truly affected would be Afterburner & Anomaly, as all the other CORE themes use CANVAS as parent, so Canvas theme would carry the current Base theme pagelayout.css (baselayout.css.

          At this moment in time my testing is proving to be successful, and as if by magic, the problem with IE7 just disappears.

          Show
          Mary Evans added a comment - - edited Just linked MDL-32959 Convert BASE theme layout to Perfect Holy Grail Percentage Layout. By converting Base theme whilst preserving the layouts of all CORE themes, the only ones truly affected would be Afterburner & Anomaly, as all the other CORE themes use CANVAS as parent, so Canvas theme would carry the current Base theme pagelayout.css (baselayout.css. At this moment in time my testing is proving to be successful, and as if by magic, the problem with IE7 just disappears.
          Hide
          Nadav Kavalerchik added a comment -

          Great news

          Show
          Nadav Kavalerchik added a comment - Great news
          Hide
          Mary Evans added a comment -

          Well it is good news and bad news as the majority of the themes in CORE are based on the Holy Grail Pixel Layout which does not work in IE7 with Moodle so either I will need to convert those themes that use 3 column layout ([left][middle][right]) like Boxxie, FormFactor, Formal White, Leatherbound, Magazine, Serenity and Splash, but the others that use 2 columns blog style ([middle] [right]) or 3 column blog style ([middle][left][right]) will have to stay as they are.

          Either way it makes for an interesting project.

          Show
          Mary Evans added a comment - Well it is good news and bad news as the majority of the themes in CORE are based on the Holy Grail Pixel Layout which does not work in IE7 with Moodle so either I will need to convert those themes that use 3 column layout ( [left] [middle] [right] ) like Boxxie, FormFactor, Formal White, Leatherbound, Magazine, Serenity and Splash, but the others that use 2 columns blog style ( [middle] [right] ) or 3 column blog style ( [middle] [left] [right] ) will have to stay as they are. Either way it makes for an interesting project.
          Hide
          Yedidia Klein added a comment -

          interesting,
          adding:

          html

          {direction: ltr;}

          fix the problem on most of the themes.

          but, somehow it breaks all JS
          language selector and tree menus stop working...

          something w/ YUI ?!?

          --Yedidia

          Show
          Yedidia Klein added a comment - interesting, adding: html {direction: ltr;} fix the problem on most of the themes. but, somehow it breaks all JS language selector and tree menus stop working... something w/ YUI ?!? --Yedidia

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: