Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26433

contants defined in messaging need to be made more specific to avoid conflicts

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.3
    • Component/s: Messages
    • Labels:
    • Database:
      Any
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      There are a bunch of defines using really common names like CONTACT_ID, VIEW_PARAM, IS_BLOCKER etc that can conflict because they are really generic. They must be more "unique" or be transformed into another beast.

      Eloy has also said that there use in optional_param() and building URLs is bad although Im not sure why. Hopefully he can provide more information on that.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11