Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26436

Verify that all recordsets are being closed in messaging

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.4
    • Component/s: Messages

      Description

      Are we closing all recordsets in the messaging code?

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            Found 1 place where we weren't closing the record set. Also did a little bit of rearranging to make the code more readable so its more obvious how the record sets are being handled.

            Show
            andyjdavis Andrew Davis added a comment - Found 1 place where we weren't closing the record set. Also did a little bit of rearranging to make the code more readable so its more obvious how the record sets are being handled.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            andyjdavis Andrew Davis added a comment -

            rebased

            Show
            andyjdavis Andrew Davis added a comment - rebased
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Hi Andrew, can you plz review your suggested solution for MOODLE_20_STABLE? It seems to include one commit from MDL-27460 by mistake.

            TIA!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Hi Andrew, can you plz review your suggested solution for MOODLE_20_STABLE? It seems to include one commit from MDL-27460 by mistake. TIA!
            Hide
            andyjdavis Andrew Davis added a comment -

            Not sure exactly what I did to get that to happen but its fixed now

            Show
            andyjdavis Andrew Davis added a comment - Not sure exactly what I did to get that to happen but its fixed now
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            tsala Helen Foster added a comment -

            Tested on local 20_STABLE site as described.

            Show
            tsala Helen Foster added a comment - Tested on local 20_STABLE site as described.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            closing recordsets leads to closing, this, lol. Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - closing recordsets leads to closing, this, lol. Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11