Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26439

When searching for message, the message content is displayed with some 'weird' text

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.2.6, 2.3.3
    • Fix Version/s: 2.2.7, 2.3.4
    • Component/s: Messages
    • Labels:
      None

      Description

      As admin I went in My profile > messages and I sent some messages to a student (my message saying 'Hello student').
      Then I searched the word 'student' and all resulting messages had the following text appended to the bottom:

      --------------------------------------------------------------------- This is a copy of a message sent to you at "thisisthemoodleintegrationsuper...
      Context

      Note: very minor note, maybe context should be 'User discussions'. I didn't know what I was going to see before I clicked context.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andyjdavis Andrew Davis added a comment - - edited

            This is actually still an issue. I can reproduce it. In messagelib.php somewhere it is using fullmessage when it should be using smallmessage.

            Show
            andyjdavis Andrew Davis added a comment - - edited This is actually still an issue. I can reproduce it. In messagelib.php somewhere it is using fullmessage when it should be using smallmessage.
            Hide
            andyjdavis Andrew Davis added a comment -

            Adding a potential fix.

            Show
            andyjdavis Andrew Davis added a comment - Adding a potential fix.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            The patch looks good and tested for 2.4. It works great.

            [y] Syntax
            [y] Output
            [y] Whitespace
            [-] Language
            [y] Databases
            [y] Testing
            [-] Security
            [-] Documentation
            [-] Git
            [y] Sanity check

            This probably should probably be backported to 2.2 and 2.3.

            Show
            rwijaya Rossiani Wijaya added a comment - The patch looks good and tested for 2.4. It works great. [y] Syntax [y] Output [y] Whitespace [-] Language [y] Databases [y] Testing [-] Security [-] Documentation [-] Git [y] Sanity check This probably should probably be backported to 2.2 and 2.3.
            Hide
            andyjdavis Andrew Davis added a comment -

            2.2 and 2.3 branches added. Putting up for integration.

            Show
            andyjdavis Andrew Davis added a comment - 2.2 and 2.3 branches added. Putting up for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Andrew, i've integrated this now.

            Show
            poltawski Dan Poltawski added a comment - Thanks Andrew, i've integrated this now.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Works as described.
            passing
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Works as described. passing Thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week!

            ciao
            Dan

            Show
            poltawski Dan Poltawski added a comment - Congratulations! Another bug solved.. only another 7330 to go, thanks for contributing to contributing to 0.8% of all bugs being fixed this week! ciao Dan

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13