Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26440

remove references to uid in DB queries as it is a reserved word in Oracle

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.3
    • Component/s: General
    • Labels:
      None
    • Database:
      Oracle
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      uid is a reserved word in oracle. search the code base for "uid" and remove any references to it in SQL queries.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            Have commented changes for this.

            repo: git://github.com/andyjdavis/moodle.git
            branch: MDL-26440_uid
            diff: https://github.com/andyjdavis/moodle/compare/master...MDL-26440_uid

            Show
            andyjdavis Andrew Davis added a comment - Have commented changes for this. repo: git://github.com/andyjdavis/moodle.git branch: MDL-26440 _uid diff: https://github.com/andyjdavis/moodle/compare/master...MDL-26440_uid
            Hide
            timhunt Tim Hunt added a comment -

            Changing just that one line in mod/quiz/overrides.php will surely break things. You need to find the other places that refer to that field in the data returned, and fix them.

            Show
            timhunt Tim Hunt added a comment - Changing just that one line in mod/quiz/overrides.php will surely break things. You need to find the other places that refer to that field in the data returned, and fix them.
            Hide
            andyjdavis Andrew Davis added a comment -

            I actually couldnt find anywhere that was referencing the 'uid' column. At line 137 and 140 there is already a reference to a 'userid' column. Actually, that userid value could well be coming out of the quiz_override table. Can the uid column on line 101 just be removed?

            Show
            andyjdavis Andrew Davis added a comment - I actually couldnt find anywhere that was referencing the 'uid' column. At line 137 and 140 there is already a reference to a 'userid' column. Actually, that userid value could well be coming out of the quiz_override table. Can the uid column on line 101 just be removed?
            Hide
            timhunt Tim Hunt added a comment -

            Looks like it can be removed. Good.

            Show
            timhunt Tim Hunt added a comment - Looks like it can be removed. Good.
            Hide
            andyjdavis Andrew Davis added a comment -

            Removed id.

            Show
            andyjdavis Andrew Davis added a comment - Removed id.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Looks ok, as far as neither $rating->id and $rating->uid are used later. +1 for after 2.0.2

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Looks ok, as far as neither $rating->id and $rating->uid are used later. +1 for after 2.0.2
            Hide
            andyjdavis Andrew Davis added a comment -

            PULL-324

            Show
            andyjdavis Andrew Davis added a comment - PULL-324

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11