Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.0.3
    • Component/s: Filters
    • Labels:
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      While testing PULL-274 (MDL-26030 for 2.0), some problems have been found (thanks to Petr for his help):

      1) flv sizes borked there as before.
      2) Size not working on all video/image types
      3) CSS hardcoded + not passed to flowplayer
      4) original links not being displayed for all medias

      This needs fixing in 2.0 ASAP ,IMO.

      Below, it's the HTML content to be pasted into one page resource to see the results:

      <p><a href="http://www.pacdv.com/sounds/applause-sounds/app-5.mp3" title="mp3">mp3</a></p>
      <hr />
      <p><a href="http://www.flashadvisor.com/movie/swf/butterfly_safak_311.swf?d=240x180" title="swf">swf</a></p>
      <hr />
      <p><a href="http://www.thirdpartyplugins.com/stormtracer/movies/bubbles.mov?d=240x180" title="mov">mov</a></p>
      <hr />
      <p><a href="http://www.socialtext.net/data/workspaces/exchange/attachments/a_simple_example_of_wmv_video_file:20090811235232-0-16969/original/travelingr_83q3cvch.wmv?d=240x180" title="vmv">vmv</a></p>
      <hr />
      <p><a href="http://www.cs.ubc.ca/nest/imager/contributions/forsey/dragon/mpeg/talk.mpg?d=240x180" title="mpg">mpg</a></p>
      <hr />
      <p><a href="http://www.arielnet.com/topics2/AVI_files/Hammer_Sedick0001.avi?d=240x180" title="avi">avi</a></p>
      <hr />
      <p><a href="http://www.publiblanes.net/video_flv/flashplayer_swf/RUBIK_en_1_minuto.flv?d=240x180" title="flv">flv</a></p>
      <hr />
      <p><a href="http://www17.real.com/help/library/guides/realone/IntroToStreaming/samples/ramfiles/doublesize.ram" title="ram">ram</a></p>
      <hr />
      <p>rpm</p>
      <hr />
      <p><a href="http://mcprog.homedns.org/sound/AlleluiaHeIsComing.ra" title="ra">rm</a></p>
      <hr />
      <p><a href="http://www.youtube.com/watch?v=FUrhl974wSE?d=240x180" title="youtube">youtubelinks</a></p>
      <hr />
      <p><a href="http://dspace.wijiti.com/i/testing/bitstream/123456789/16/1/06_-_Vivaldi_Summer_mvt_3_Presto_-_John_Harrison_violin.ogg" title="ogg">ogg</a></p>
      <hr />
      <p><a href="http://upload.wikimedia.org/wikipedia/commons/e/e6/Typing_example.ogv?d=240x180" title="ogv">ogv</a></p>
      <hr />
      <p><a href="http://upload.wikimedia.org/wikipedia/en/8/8f/Example.gif" title="gif">image gif</a></p>
      <hr />
      <p><a href="http://images2.wikia.nocookie.net/__cb20101001183661/htmlcss/images/2/28/PNG_Example_2.png" title="png">image png</a></p>
      <hr />

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            Hopefully fixed in submitted PULL request.

            Thanks

            Show
            skodak Petr Skoda added a comment - Hopefully fixed in submitted PULL request. Thanks
            Hide
            orestes Orestes Mas added a comment -

            I've reported some issues related to mediaplugin filter: MDL-26727 and MDL-26729, so I can't wait for your improvements

            Also, it would be very useful if you can code into the filter some option for deactivating the embedding mechanism as per-file level. The reason behind this is the following: imagine that you embed a video in one resource page, but for some reason the user isn't able to view it embedded. In this case is very useful to provide a plain link to the file for the user to download it directly. I'm thinking of a code like:

            <p>Please watch the following video:<br />
            <center><a href="a.link.to/the_video.flv">The video</a></center></p>
            <p>If you're experiencing problems viewing the video above, please <a href="a.link.to/the_video.flv?embed=none">download it directly</a>.</p>

            The key will be supporting some sort of extension mechanism similar to the one used to specify the size of the embedded video.

            Sounds good?

            Show
            orestes Orestes Mas added a comment - I've reported some issues related to mediaplugin filter: MDL-26727 and MDL-26729 , so I can't wait for your improvements Also, it would be very useful if you can code into the filter some option for deactivating the embedding mechanism as per-file level. The reason behind this is the following: imagine that you embed a video in one resource page, but for some reason the user isn't able to view it embedded. In this case is very useful to provide a plain link to the file for the user to download it directly. I'm thinking of a code like: <p>Please watch the following video:<br /> <center><a href="a.link.to/the_video.flv">The video</a></center></p> <p>If you're experiencing problems viewing the video above, please <a href="a.link.to/the_video.flv?embed=none">download it directly</a>.</p> The key will be supporting some sort of extension mechanism similar to the one used to specify the size of the embedded video. Sounds good?
            Hide
            skodak Petr Skoda added a comment -

            Finally marking as fixed, the only remaining issue is the YouTube resizing which has a separate issue.

            Thanks!

            Show
            skodak Petr Skoda added a comment - Finally marking as fixed, the only remaining issue is the YouTube resizing which has a separate issue. Thanks!

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11