Moodle
  1. Moodle
  2. MDL-26469

Cron setting not updated when plugins are upgraded

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.0.8, 2.1.5, 2.2.2
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      Test the mod_quiz upgrade in MDL-30635 and make sure modules.cron gets updated from 0 to 60.

      Show
      Test the mod_quiz upgrade in MDL-30635 and make sure modules.cron gets updated from 0 to 60.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Rank:
      16062

      Description

      1. Create a new plugin with and put the following line in version.php:
      $plugin->cron = 0

      2. Install the plugin to a Moodle server.
      3. Update version.php, changing the $plugin->version number and setting the cron line to, for example:
      $plugin->cron = 60

      4. Visit the admin/notifications page to upgrade the module

      Expected outcome:
      'mdl_modules' database table now contains the updated 'cron' value for this plugin (i.e. it should be '60')

      Actual outcome:
      'mdl_modules' database table still has the original 'cron' value ('0')

      Workaround:
      For the moment, I've added a manual upgrade to the cron value in 'mypluginname/db/upgrade.php', but would prefer not to have to do that.

        Issue Links

          Activity

          Davo Smith created issue -
          Tomasz Muras made changes -
          Field Original Value New Value
          Affects Version/s 2.0.2 [ 10421 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 68037 ] MDL Full Workflow [ 75915 ]
          Dan Poltawski made changes -
          Assignee moodle.com [ moodle.com ] Dan Poltawski [ poltawski ]
          Dan Poltawski made changes -
          Assignee Dan Poltawski [ poltawski ] moodle.com [ moodle.com ]
          Dan Poltawski made changes -
          Labels triaged
          Tim Hunt made changes -
          Assignee moodle.com [ moodle.com ] Tim Hunt [ timhunt ]
          Tim Hunt made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull 2.0 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_20_STABLE...MDL-26469_20
          Pull from Repository git://github.com/timhunt/moodle.git
          Pull 2.0 Branch MDL-26469_20
          Fix Version/s 2.0.8 [ 11554 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Testing Instructions Test the mod_quiz upgrade in MDL-30635 and make sure modules.cron gets updated from 0 to 60.
          Pull 2.1 Branch MDL-26469_21
          Pull 2.1 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-26469_21
          Tim Hunt made changes -
          Link This issue will help resolve MDL-30635 [ MDL-30635 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.2.1 [ 11456 ]
          Affects Version/s 2.1.4 [ 11452 ]
          Affects Version/s 2.3 [ 10657 ]
          Affects Version/s 2.0.2 [ 10421 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester stronk7
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 12/Jan/12

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: