[MDL-26500] rss.xml files are not showing image attachments - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0.1, 2.1, 2.2.2, 2.3
Fix Version/s: 2.1.6, 2.2.3
Component/s: RSS
Labels:
- triaged
Environment:
LAMP

Database:

MySQL
Testing Instructions:
Hide

For ease of testing we will setup our test site to allow guests all over.

Setup

In Admin > Permissions > User Policies, Enable autologinguests

In Admin > Advanced features > Enable RSS

In Admin > Plugins > [Forum & Glossary] > Enable RSS

In Admin > Advanced features > set blog visbility to word accessible

Setup Course

Create a new course and set guest access to yes

Forum Article Feed

Create a new forum activity setting 'RSS feed for this activity': Posts and number of rss articles: 20

Post in the forum and use the image button on tinymce to embed an uploaded image in the post text

Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed of posts' for the url)

You should have images embeded and displayed within the posts

Forum Discussion Feed

Create a new forum activity setting 'RSS feed for this activity': Discussions and number of rss articles: 20

Post in the forum and use the image button on tinymce to embed an uploaded image in the post text

Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed of discussion' for the url)

You should have images embeded and displayed within the posts

Glossary

Create a new forum activity setting 'RSS feed for this activity' to concepts with author and number of rss articles:3

Add a new glossary enrtry and use the image button on tinymce to embed an uploaded image in the entry text

Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed for this activity' for the url)

You should have images embeded and displayed within the posts

Blog

Add a new blog enrtry and use the image button on tinymce to embed an uploaded image in the entry text

Use an RSS reader to view the feed for this forum (See the link in nav block 'Blog RSS feed' for the url)

You should have images embeded and displayed within the posts
Show
For ease of testing we will setup our test site to allow guests all over. Setup In Admin > Permissions > User Policies, Enable autologinguests In Admin > Advanced features > Enable RSS In Admin > Plugins > [Forum & Glossary] > Enable RSS In Admin > Advanced features > set blog visbility to word accessible Setup Course Create a new course and set guest access to yes Forum Article Feed Create a new forum activity setting 'RSS feed for this activity': Posts and number of rss articles: 20 Post in the forum and use the image button on tinymce to embed an uploaded image in the post text Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed of posts' for the url) You should have images embeded and displayed within the posts Forum Discussion Feed Create a new forum activity setting 'RSS feed for this activity': Discussions and number of rss articles: 20 Post in the forum and use the image button on tinymce to embed an uploaded image in the post text Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed of discussion' for the url) You should have images embeded and displayed within the posts Glossary Create a new forum activity setting 'RSS feed for this activity' to concepts with author and number of rss articles:3 Add a new glossary enrtry and use the image button on tinymce to embed an uploaded image in the entry text Use an RSS reader to view the feed for this forum (See the link in nav block 'RSS feed for this activity' for the url) You should have images embeded and displayed within the posts Blog Add a new blog enrtry and use the image button on tinymce to embed an uploaded image in the entry text Use an RSS reader to view the feed for this forum (See the link in nav block 'Blog RSS feed' for the url) You should have images embeded and displayed within the posts
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
wip-~~MDL-26500~~
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/wip-MDL-26500

Description

Image attachments are not diaplayed in rss.xml files for forum & blog posts (not tested for glossary etc.). Instead, something like, "PLUGINFILE /RM1.jpg" alt="" width="387" height="162" />" is displayed.

Gliffy Diagrams

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

rss_image.jpg
13 kB
18/Oct/11 7:07 PM

Issue Links

has a non-specific relationship to

MDL-26311 Some inconsistencies across data/forum/glossary rss feeds

Closed

is duplicated by

MDLSITE-1333 Useful posts RSS feed isn't processing @@PLUGINFILE@@

Closed

will be (partly) resolved by

MDL-31129 Implement post attachment handling for Forum RSS Feeds

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Manish Verma added a comment - 04/Jul/11 1:58 AM

On upgrade from 2.0.1+ to 2.1, I noticed the issue in 2.1 also.

Show

Manish Verma added a comment - 04/Jul/11 1:58 AM On upgrade from 2.0.1+ to 2.1, I noticed the issue in 2.1 also.

Hide

Permalink

Michael Hughes added a comment - 18/Oct/11 7:07 PM - edited

not sure if this is related but RSS block won't show a channel image if available, just displays broken image link (see attached image)

... ah, seems this is just the moodle.org rss image then! works fine with BBC etc ... please ignore.

Show

Michael Hughes added a comment - 18/Oct/11 7:07 PM - edited not sure if this is related but RSS block won't show a channel image if available, just displays broken image link (see attached image) ... ah, seems this is just the moodle.org rss image then! works fine with BBC etc ... please ignore.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 03/Mar/12 8:22 AM - edited

Well, I think we need, ASAP:

1) Add the missing file_rewrite_pluginfile_urls() to all RSS generators missing them: forum, glossary, data, blog, useful posts...

And, once working for public content...

2) We need to define what happens with "protected" images (aka, images requiring cap check and/or be logged to access). As Glenn pointed @ ~~MDL-26311~~, perhaps we could make some "magic" with the token and provide an alternative validation method, much like it has been done by the webservice_pluginfile.php, into a new, specialised, rss_pluginfile.php or so.

But I think we should fix the missing calls (1) ASAP, so at least the urls will be correct, instead of those unconverted PLUGINFILEs. (2) can be made in separate, followup, issue.

Ciao

Show

Eloy Lafuente (stronk7) added a comment - 03/Mar/12 8:22 AM - edited Well, I think we need, ASAP: 1) Add the missing file_rewrite_pluginfile_urls() to all RSS generators missing them: forum, glossary, data, blog, useful posts... And, once working for public content... 2) We need to define what happens with "protected" images (aka, images requiring cap check and/or be logged to access). As Glenn pointed @ MDL-26311 , perhaps we could make some "magic" with the token and provide an alternative validation method, much like it has been done by the webservice_pluginfile.php, into a new, specialised, rss_pluginfile.php or so. But I think we should fix the missing calls (1) ASAP, so at least the urls will be correct, instead of those unconverted PLUGINFILEs. (2) can be made in separate, followup, issue. Ciao

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 30/Mar/12 7:35 AM

ping!

Show

Eloy Lafuente (stronk7) added a comment - 30/Mar/12 7:35 AM ping!

Hide

Permalink

Dan Poltawski added a comment - 30/Mar/12 4:24 PM

Untested patch for forum: https://github.com/danpoltawski/moodle/compare/wip-MDL-26500

Show

Dan Poltawski added a comment - 30/Mar/12 4:24 PM Untested patch for forum: https://github.com/danpoltawski/moodle/compare/wip-MDL-26500

Hide

Permalink

Dan Poltawski added a comment - 30/Mar/12 8:40 PM

Ok so it looks like mod/data is OK, but i've fixed blog, glossary and forum

Show

Dan Poltawski added a comment - 30/Mar/12 8:40 PM Ok so it looks like mod/data is OK, but i've fixed blog, glossary and forum

Hide

Permalink

Dan Poltawski added a comment - 30/Mar/12 8:55 PM

Dear peer reviewer: please note the branches have slight differences

Show

Dan Poltawski added a comment - 30/Mar/12 8:55 PM Dear peer reviewer: please note the branches have slight differences

Hide

Permalink

Dan Poltawski added a comment - 30/Mar/12 8:58 PM

I have only done part 1 of eloys suggestion. I am not sure about (2) myself - exposing a magic token so readily to users in RSSS feeds

Show

Dan Poltawski added a comment - 30/Mar/12 8:58 PM I have only done part 1 of eloys suggestion. I am not sure about (2) myself - exposing a magic token so readily to users in RSSS feeds

Hide

Permalink

Dan Poltawski added a comment - 17/Apr/12 5:50 PM

Well, I asked 3 times for a peer review and didn't get one, so submitting for integration.

Show

Dan Poltawski added a comment - 17/Apr/12 5:50 PM Well, I asked 3 times for a peer review and didn't get one, so submitting for integration.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 18/Apr/12 7:24 AM

(well done!)

Show

Eloy Lafuente (stronk7) added a comment - 18/Apr/12 7:24 AM (well done!)

Hide

Permalink

Dan Poltawski added a comment - 19/Apr/12 9:57 PM

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show

Dan Poltawski added a comment - 19/Apr/12 9:57 PM The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 24/Apr/12 6:06 AM

Integrated, thanks! (21, 22 & master)

Show

Eloy Lafuente (stronk7) added a comment - 24/Apr/12 6:06 AM Integrated, thanks! (21, 22 & master)

Hide

Permalink

Adrian Greeve added a comment - 26/Apr/12 11:35 AM

Tested with versions 2.1, 2.2 and master. RSS feeds are displaying pictures as required.
Thanks Dan for your help.

Show

Adrian Greeve added a comment - 26/Apr/12 11:35 AM Tested with versions 2.1, 2.2 and master. RSS feeds are displaying pictures as required. Thanks Dan for your help.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 27/Apr/12 11:13 PM

This has been near becoming rejected, because it's not the best code you are able to produce.

But, luckily, at the end, it has landed and has been spread to all repos out there.

Many thanks and, don't forget it, keep improving your skills, you can!

Closing, ciao

Show

Eloy Lafuente (stronk7) added a comment - 27/Apr/12 11:13 PM This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

People

Assignee:

Dan Poltawski

Reporter:

Manish Verma

Integrator:

Eloy Lafuente (stronk7)

Tester:

Adrian Greeve

Participants:

Adrian Greeve, Dan Poltawski, Eloy Lafuente (stronk7), Manish Verma, Michael Hughes

Votes:

4 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

18/Feb/11 7:36 PM

Updated:

27/Apr/12 11:13 PM

Resolved:

27/Apr/12 11:13 PM

Fix Release Date:

14/May/12

Details

Setup

Setup Course

Forum Article Feed

Forum Discussion Feed

Glossary

Blog

Description

Gliffy Diagrams

Attachments

Attachments

Issue Links

Activity

People

Dates