Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26501

Glossary: 'Without author' option does not work in all places

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1 (upgrade):

      1. Create glossary in "simple" display format with categories
      2. Run upgrade
      3. Browse glossary, make sure the "simple" display format has categories tabs.

      Test 2 (upgrade):

      1. Create glossary in "simple" display format without categories, make sure there are no "simple" glossaries with categories.
      2. Run upgrade
      3. Browse glossary, make sure the "simple" display format does not have any tabs.

      Test 3:

      • Create glossary with all settings default except for approval; set display format to "full with author"
      • As student(s) add several entires, as a teacher approve some of them
      • Make sure that tab "By author" is visible and accessible (leave the tab open so you can copy url for later)
      • Change glossary settings to display entries without author
      • Make sure that the tab "By author" is not visible, try to mock URL of the "by author" view and make sure it does not work
      • View entries waiting for approval, make sure sure the display setting for them is respected
      • Try setting "approval display format" to something different, make sure there is still no tab "By author" and you can't see author of approved entries but on the "Waiting for approval" page the author of each entry is displayed
      • Try setting "approval display format" without author but the "display format" with author (in case it ever makes sense), make sure the tab is present but there is no author on "waiting for approval" page
      Show
      Test 1 (upgrade): Create glossary in "simple" display format with categories Run upgrade Browse glossary, make sure the "simple" display format has categories tabs. Test 2 (upgrade): Create glossary in "simple" display format without categories, make sure there are no "simple" glossaries with categories. Run upgrade Browse glossary, make sure the "simple" display format does not have any tabs. Test 3: Create glossary with all settings default except for approval; set display format to "full with author" As student(s) add several entires, as a teacher approve some of them Make sure that tab "By author" is visible and accessible (leave the tab open so you can copy url for later) Change glossary settings to display entries without author Make sure that the tab "By author" is not visible, try to mock URL of the "by author" view and make sure it does not work View entries waiting for approval, make sure sure the display setting for them is respected Try setting "approval display format" to something different, make sure there is still no tab "By author" and you can't see author of approved entries but on the "Waiting for approval" page the author of each entry is displayed Try setting "approval display format" without author but the "display format" with author (in case it ever makes sense), make sure the tab is present but there is no author on "waiting for approval" page
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      wip-MDL-26501-master

      Description

      When you choose the existing glossary format 'Full without author', the 'Browse by author' tab is still shown.

      This is stupid - we'd like to fix it so that when you choose that 'without author' format, author does not display in any part of the (student-visible) glossary UI.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15