Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26523

Various problems found with the grader report in gradebook

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Gradebook, JavaScript
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      As always make sure your test site is set to show all errors etc. You'll need a course with at least one activity that uses a custom scale.

      Go to the grader report for the course. Turn on editing.

      Click one of the hand/pencil icons for a student grade for the activity using a custom scale. If MDL-26275 has been integrated you should only have to click it once. If it hasn't been integrated you will have to click it twice.

      No missing string errors should be displayed.

      Show
      As always make sure your test site is set to show all errors etc. You'll need a course with at least one activity that uses a custom scale. Go to the grader report for the course. Turn on editing. Click one of the hand/pencil icons for a student grade for the activity using a custom scale. If MDL-26275 has been integrated you should only have to click it once. If it hasn't been integrated you will have to click it twice. No missing string errors should be displayed.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-26523_grader

      Description

      Detected while testing @ MDLQA-683

      1) Using AJAX in the grader report, it seems that 2 fields should be shown when overriding one grade (grade and comment), but I'm only getting one field (grade) and the comment one isn't present.

      2) Two clicks are necessary in the "hand with one pencil" icon in order to get the override grade_grade form page. With one click nothing is launched / requested.

      3) When the override grade_grade page is invoked for one "scale item", some strings seem to be missing:

      Help title string does not exist: [finalgrade, finalgrade]
      
          * line 351 of /lib/outputcomponents.php: call to debugging()
          * line 1678 of /lib/outputrenderers.php: call to help_icon->diag_strings()
          * line 1507 of /lib/formslib.php: call to core_renderer->help_icon()
          * line 76 of /grade/edit/tree/grade_form.php: call to MoodleQuickForm->addHelpButton()
          * line 152 of /lib/formslib.php: call to edit_grade_form->definition()
          * line 98 of /grade/edit/tree/grade.php: call to moodleform->moodleform()
      
      Help contents string does not exist: [finalgrade_help, finalgrade]
      
          * line 354 of /lib/outputcomponents.php: call to debugging()
          * line 1678 of /lib/outputrenderers.php: call to help_icon->diag_strings()
          * line 1507 of /lib/formslib.php: call to core_renderer->help_icon()
          * line 76 of /grade/edit/tree/grade_form.php: call to MoodleQuickForm->addHelpButton()
          * line 152 of /lib/formslib.php: call to edit_grade_form->definition()
          * line 98 of /grade/edit/tree/grade.php: call to moodleform->moodleform()
      
      Invalid get_string() identifier: 'finalgrade' or component 'finalgrade'
      
          * line 5863 of /lib/moodlelib.php: call to debugging()
          * line 6418 of /lib/moodlelib.php: call to core_string_manager->get_string()
          * line 1698 of /lib/outputrenderers.php: call to get_string()
          * line 70 of /lib/outputrenderers.php: call to core_renderer->render_help_icon()
          * line 1684 of /lib/outputrenderers.php: call to renderer_base->render()
          * line 1507 of /lib/formslib.php: call to core_renderer->help_icon()
          * line 76 of /grade/edit/tree/grade_form.php: call to MoodleQuickForm->addHelpButton()
          * line 152 of /lib/formslib.php: call to edit_grade_form->definition()
          * line 98 of /grade/edit/tree/grade.php: call to moodleform->moodleform()
      

      Ciao

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/12