Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26557

Checkbox controller text variable is wrong. Button/Link shows always the default text.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.11
    • Fix Version/s: 2.0.3
    • Component/s: Forms Library
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Variable $buttontext in function add_checkbox_controller should be renamed to $text. Even if you assign a value in the function, the button/link will always show the default value "select all/none".

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Additionally, the documentation at http://docs.moodle.org/en/Development:lib/formslib.php_add_checkbox_controller suggests that the function can be called with only the first param, but the defautls have been removed.

            I've pushed a fix for both issues to https://git.luns.net.uk/moodle.git on branch MDL-26557

            Show
            dobedobedoh Andrew Nicols added a comment - Additionally, the documentation at http://docs.moodle.org/en/Development:lib/formslib.php_add_checkbox_controller suggests that the function can be called with only the first param, but the defautls have been removed. I've pushed a fix for both issues to https://git.luns.net.uk/moodle.git on branch MDL-26557
            Hide
            tsala Helen Foster added a comment -

            This issue is fixed in this week's 2.0.2+. Thanks everyone

            Show
            tsala Helen Foster added a comment - This issue is fixed in this week's 2.0.2+. Thanks everyone

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11