Moodle
  1. Moodle
  2. MDL-26557

Checkbox controller text variable is wrong. Button/Link shows always the default text.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.11
    • Fix Version/s: 2.0.3
    • Component/s: Forms Library
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16320

      Description

      Variable $buttontext in function add_checkbox_controller should be renamed to $text. Even if you assign a value in the function, the button/link will always show the default value "select all/none".

        Activity

        Hide
        Andrew Nicols added a comment -

        Additionally, the documentation at http://docs.moodle.org/en/Development:lib/formslib.php_add_checkbox_controller suggests that the function can be called with only the first param, but the defautls have been removed.

        I've pushed a fix for both issues to https://git.luns.net.uk/moodle.git on branch MDL-26557

        Show
        Andrew Nicols added a comment - Additionally, the documentation at http://docs.moodle.org/en/Development:lib/formslib.php_add_checkbox_controller suggests that the function can be called with only the first param, but the defautls have been removed. I've pushed a fix for both issues to https://git.luns.net.uk/moodle.git on branch MDL-26557
        Hide
        Helen Foster added a comment -

        This issue is fixed in this week's 2.0.2+. Thanks everyone

        Show
        Helen Foster added a comment - This issue is fixed in this week's 2.0.2+. Thanks everyone

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: