Moodle
  1. Moodle
  2. MDL-26562

Forum string "overviewnumpostssince" should contain a substitution for a number so that it can be translated

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1.6, 2.2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Forum, Language
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as a student
      2. Edit profile settings
      3. Turn forum tracking on
      4. Log out
      5. Log in as teacher/admin
      6. Go to a course that student is enrolled in
      7. If there is not already a forum there, create one
      8. Post some messages to the forum
      9. Log in as a student
      10. Navigate to the My Moodle page
      11. The Course overview block should be present in the central column (if not, add it to the page).

      The overview should include forum post messages like...

      Forum: Forum example
      3 posts since last login
      4 total unread

      Show
      Log in as a student Edit profile settings Turn forum tracking on Log out Log in as teacher/admin Go to a course that student is enrolled in If there is not already a forum there, create one Post some messages to the forum Log in as a student Navigate to the My Moodle page The Course overview block should be present in the central column (if not, add it to the page). The overview should include forum post messages like... Forum: Forum example 3 posts since last login 4 total unread
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
    • Rank:
      16144

      Description

      The forum string "overviewnumpostssince" translates to 'posts since last login' and is used to show '3 post since last login', however this makes it impossible, in some languages, to translate this string because it begins with number. The string should contain a substitution for a number.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks again for providing a solution to this problem.

        Show
        Michael de Raadt added a comment - Thanks again for providing a solution to this problem.
        Hide
        Michael de Raadt added a comment - - edited

        Integrators: This is a simple string change, although not a high priority before release.

        The change is consistent in 2.1, 2.2 and master.

        Show
        Michael de Raadt added a comment - - edited Integrators: This is a simple string change, although not a high priority before release. The change is consistent in 2.1, 2.2 and master.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks Vadim, this has been integrated now!

        Show
        Sam Hemelryk added a comment - Thanks Vadim, this has been integrated now!
        Hide
        Sam Hemelryk added a comment -

        Testing during integration review and passed.

        Show
        Sam Hemelryk added a comment - Testing during integration review and passed.
        Hide
        Martin Dougiamas added a comment -

        Shouldn't this have AMOS commit messages?!

        Show
        Martin Dougiamas added a comment - Shouldn't this have AMOS commit messages?!
        Hide
        Michael de Raadt added a comment -

        I did ask that. The answer I got was "no". But that could have been wrong.

        Show
        Michael de Raadt added a comment - I did ask that. The answer I got was "no". But that could have been wrong.
        Hide
        Sam Hemelryk added a comment -

        No need for AMOS messages here I believe.
        AMOS only requires help when copying/moving a string or in converting a legacy help file to a string.
        A version bump/upgrade would be required to clear caches and prevent cache problems however we always bump when pushing from integration => stable so that won't be a problem.

        Show
        Sam Hemelryk added a comment - No need for AMOS messages here I believe. AMOS only requires help when copying/moving a string or in converting a legacy help file to a string. A version bump/upgrade would be required to clear caches and prevent cache problems however we always bump when pushing from integration => stable so that won't be a problem.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: