Moodle
  1. Moodle
  2. MDL-26609

Admins are not warned if they are going to install or upgrade to a unstable Moodle version

    Details

    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16404

      Description

      By an accident, admins can run install or upgrade using an unstable Moodle checkout. Especially now when Moodle 2.0 unfortunately lives at 'master' Git branch which will become the main development (hence unstable) branch after we fork MOODLE_20_STABLE. As was discussed in HQ jabber chatroom, it would be useful if Moodle warned admins about the maturity of the code they are about to install or upgrade to.

        Activity

        Hide
        David Mudrak added a comment -

        Screenshot

        Show
        David Mudrak added a comment - Screenshot
        Hide
        David Mudrak added a comment -

        The patch submitted in PULL-360

        Show
        David Mudrak added a comment - The patch submitted in PULL-360
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hi David,

        I like this feature a lot, so here it's my +1

        Anyway, as far as it is a new functionality and this is, more or less, stable branch... I think we need Martin's +1 here. So awaiting for that now.

        At the same time, and always I see that page (the one in your screenshot), would be possible to add information about the current version in the gray box? Note it displays in the browser's title (you are going to upgrade from xxxx to yyyy), but I think it would be great to have that info also in the box. Please vote +1 to it too.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Hi David, I like this feature a lot, so here it's my +1 Anyway, as far as it is a new functionality and this is, more or less, stable branch... I think we need Martin's +1 here. So awaiting for that now. At the same time, and always I see that page (the one in your screenshot), would be possible to add information about the current version in the gray box? Note it displays in the browser's title (you are going to upgrade from xxxx to yyyy), but I think it would be great to have that info also in the box. Please vote +1 to it too. Ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        reopening for voting

        Show
        Eloy Lafuente (stronk7) added a comment - reopening for voting
        Hide
        Petr Škoda added a comment -

        I think we need this before creating MOODLE_20_STABLE in git. I personally think we should not create any new branches in CVS and keep cvshead as 2.0stable forever there.

        Show
        Petr Škoda added a comment - I think we need this before creating MOODLE_20_STABLE in git. I personally think we should not create any new branches in CVS and keep cvshead as 2.0stable forever there.
        Hide
        Martin Dougiamas added a comment -

        yes, this is a good catch David!

        I would just add more info, probably a link to a Moodledocs page that could explain any branching events, what they mean, and some sample commands to switch branches using git / cvs etc.

        I'm not sure I follow what Petr means. What happens with 2.1?

        Show
        Martin Dougiamas added a comment - yes, this is a good catch David! I would just add more info, probably a link to a Moodledocs page that could explain any branching events, what they mean, and some sample commands to switch branches using git / cvs etc. I'm not sure I follow what Petr means. What happens with 2.1?
        Hide
        David Mudrak added a comment -

        Two additional patches implementing Martin's and Eloy's suggestions appended to the branch. Please re-review.

        Show
        David Mudrak added a comment - Two additional patches implementing Martin's and Eloy's suggestions appended to the branch. Please re-review.
        Hide
        David Mudrak added a comment -

        The second screenshot illustrates the screen after implementing Martin's and Eloy's suggestions.

        Show
        David Mudrak added a comment - The second screenshot illustrates the screen after implementing Martin's and Eloy's suggestions.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hi David,

        I was about to integrate this when I detected that, perhaps, we are missing one maturity level like:

        define('MATURITY_DEV',    0);
        

        or so, that should come before ALPHA, IMO.

        For your consideration, I'll retain PULL-360 awaiting for feedback about this... ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Hi David, I was about to integrate this when I detected that, perhaps, we are missing one maturity level like: define('MATURITY_DEV', 0); or so, that should come before ALPHA, IMO. For your consideration, I'll retain PULL-360 awaiting for feedback about this... ciao
        Hide
        Petr Škoda added a comment -

        my +1 to have just ALPHA and better, no work-in-progress === your DEV should ever get through the PULL to main git repository.

        Show
        Petr Škoda added a comment - my +1 to have just ALPHA and better, no work-in-progress === your DEV should ever get through the PULL to main git repository.
        Hide
        Helen Foster added a comment -

        Great work David, thanks!

        Show
        Helen Foster added a comment - Great work David, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Ping!

        http://docs.moodle.org/en/admin/versions is right now pointing to this issue that has been already closed.

        Suggestion: Create new issue about pending documentation and use it to track the needed changes @ Docs.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Ping! http://docs.moodle.org/en/admin/versions is right now pointing to this issue that has been already closed. Suggestion: Create new issue about pending documentation and use it to track the needed changes @ Docs. Ciao

          People

          • Votes:
            10 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: