Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26611

Legacy role mentioned on role screen instead of Role archetype

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Trivial
          • Resolution: Fixed
          • Affects Version/s: 2.0, 2.1, 2.2
          • Fix Version/s: 2.0.4, 2.1.1
          • Component/s: Roles / Access
          • Labels:
            None
          • Environment:
            All
          • Testing Instructions:
            Hide
            • Purge your caches
            • Go to Site Admin > Users > Permissions > Define roles
            • Then click to edit a role (if you click on the role on the next screen click edit)
            • Then click Show Advanced
            • When the page reloads there will be a notice above the hide advanced button
            • Check the notice doesn't refer to 'Legacy role'
            Show
            Purge your caches Go to Site Admin > Users > Permissions > Define roles Then click to edit a role (if you click on the role on the next screen click edit) Then click Show Advanced When the page reloads there will be a notice above the hide advanced button Check the notice doesn't refer to 'Legacy role'
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-26611-take2
          • Pull Master Diff URL:

            Description

            The highlighted cells in the table below show the default permission for this type of role, based on the 'Legacy role type above'.

            should read

            The highlighted cells in the table below show the default permission for this type of role, based on the Role archetype above.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Thanks Alex - I've submitted this change for integration.

                  dan

                  Show
                  poltawski Dan Poltawski added a comment - Thanks Alex - I've submitted this change for integration. dan
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Hi guys,
                  I've just been talking to Helen about this string, she thinks that it should be changed to:

                  The permissions selected in the table below are the defaults for the role archetype selected above.

                  Does that sound OK to you two? if so either Dan you can create a branch for it and I'll integrate otherwise I'll do it tomorrow in 24hrs if its still here.

                  Cheers
                  Sam

                  Show
                  samhemelryk Sam Hemelryk added a comment - Hi guys, I've just been talking to Helen about this string, she thinks that it should be changed to: The permissions selected in the table below are the defaults for the role archetype selected above. Does that sound OK to you two? if so either Dan you can create a branch for it and I'll integrate otherwise I'll do it tomorrow in 24hrs if its still here. Cheers Sam
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Makes sense, i've created a new branch for that MDL-26611-take2

                  Show
                  poltawski Dan Poltawski added a comment - Makes sense, i've created a new branch for that MDL-26611 -take2
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Dan, this has been integrated now.
                  It was merged to master and cherry-picked to MOODLE_20_STABLE and MOODLE_21_STABLE

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Dan, this has been integrated now. It was merged to master and cherry-picked to MOODLE_20_STABLE and MOODLE_21_STABLE
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  Tested and it works well.

                  Show
                  rwijaya Rossiani Wijaya added a comment - Tested and it works well.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Incorporated upstream, thanks!

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Incorporated upstream, thanks!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      1 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        1/Aug/11