Moodle
  1. Moodle
  2. MDL-26618

Block does not move if using Oracle database

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1, 2.1, 2.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Blocks, Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      2.0.1, Linux, Oracle 11g
    • Database:
      Oracle
    • Testing Instructions:
      Hide

      1. Using your install of Moodle 2.0 or 2.1 on Oracle ...
      2. Add a block on the course page, and set it to appear on all pages in the coures (page type *, course context and subcontext)
      3. Go into one of the activities (e.g. a Page resource), turn editing on, and try to move the block elsewhere on the page.

      It should work, with no errors.

      Show
      1. Using your install of Moodle 2.0 or 2.1 on Oracle ... 2. Add a block on the course page, and set it to appear on all pages in the coures (page type *, course context and subcontext) 3. Go into one of the activities (e.g. a Page resource), turn editing on, and try to move the block elsewhere on the page. It should work, with no errors.
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Please see the following discuss topic for details on this problem: http://moodle.org/mod/forum/discuss.php?d=169685

      The Block does not move when using Oracle database, and Tim found the reason for this, and already created a patch file. I have put on our test environment, and it works well so far. But, need to do more test before moving to Production.

      Actually, the patch needs to be reviewed.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Hunt added a comment -
            Show
            Tim Hunt added a comment - OK, commit ready for review: https://github.com/timhunt/moodle/compare/master...MDL-26618
            Hide
            Tim Hunt added a comment -

            Adding Eloy as a watcher.

            Eloy, I would appreciate your comments on my patch when you have time. Thanks.

            Show
            Tim Hunt added a comment - Adding Eloy as a watcher. Eloy, I would appreciate your comments on my patch when you have time. Thanks.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Ops, sorry for the delay. I remember myself already having seen that patch but obviously I forgot to comment here.

            Looks ok IMO. +1 Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Ops, sorry for the delay. I remember myself already having seen that patch but obviously I forgot to comment here. Looks ok IMO. +1 Thanks!
            Hide
            Tim Hunt added a comment -

            Although I got a +1 from Eloy months ago, I never submitted this for integration.

            I have now rebased this. It needs to go on 2.0, 2.1 and master (2.1 can be a cherry pick of the master branch.)

            Show
            Tim Hunt added a comment - Although I got a +1 from Eloy months ago, I never submitted this for integration. I have now rebased this. It needs to go on 2.0, 2.1 and master (2.1 can be a cherry pick of the master branch.)
            Hide
            Tim Hunt added a comment -

            Oops. Just fixing assignee.

            Show
            Tim Hunt added a comment - Oops. Just fixing assignee.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Getting this for immediate integration to check if it also fixes problems hiding blocks detected @ MDL-28185 (I guess it will).

            Show
            Eloy Lafuente (stronk7) added a comment - Getting this for immediate integration to check if it also fixes problems hiding blocks detected @ MDL-28185 (I guess it will).
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Tested into own and "child" page, moving, hiding and deleting, all them worked ok. Passed.

            Show
            Eloy Lafuente (stronk7) added a comment - Tested into own and "child" page, moving, hiding and deleting, all them worked ok. Passed.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Incorporated upstream, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Incorporated upstream, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: