Moodle
  1. Moodle
  2. MDL-26624

Various improvements to perform over all the core themes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Environment:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      16205

      Description

      While reviewing MDL-26047 (PULL-359), some non-perfect things have been detected in current themes stuff and should be fixed globally:

      1) Comments are under code and should be the opposite (in config.php mainly)
      2) All the .php scripts aren't ever called directly, so all them should include the MOODLE_INTERNAL check to prevent direct invocation.

      Note none of them are critical at all, but should be fixed or the same problems are going to be populated to 3rd part themes. Also, if there is any template or information in Docs, it should be fixed too.

      Anyone, feel free to add more points above if necessary. Ciao

        Activity

        Hide
        John Stabinger added a comment -

        Should the MOODLE_INTERNAL check be done on layout php files as well?

        Show
        John Stabinger added a comment - Should the MOODLE_INTERNAL check be done on layout php files as well?
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: