Moodle
  1. Moodle
  2. MDL-26624

Various improvements to perform over all the core themes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.2
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Environment:
      Any
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      16205

      Description

      While reviewing MDL-26047 (PULL-359), some non-perfect things have been detected in current themes stuff and should be fixed globally:

      1) Comments are under code and should be the opposite (in config.php mainly)
      2) All the .php scripts aren't ever called directly, so all them should include the MOODLE_INTERNAL check to prevent direct invocation.

      Note none of them are critical at all, but should be fixed or the same problems are going to be populated to 3rd part themes. Also, if there is any template or information in Docs, it should be fixed too.

      Anyone, feel free to add more points above if necessary. Ciao

        Activity

        Eloy Lafuente (stronk7) created issue -
        Patrick Malley made changes -
        Field Original Value New Value
        Assignee Patrick Malley [ ptrkmkl ] John Stabinger [ epsd ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 68261 ] MDL Full Workflow [ 76012 ]
        Michael de Raadt made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee John Stabinger [ epsd ]
        Resolution Won't Fix [ 2 ]
        Fix Version/s STABLE backlog [ 10463 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: