Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26634

LDAP NTLM SSO Multiple subnet separator is not specified and people use a wrong one

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.11, 2.0.2
    • Fix Version/s: 1.9.12, 2.0.3
    • Component/s: Authentication
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      Most of the LDAP settings use semicolon as the separator character. But NTLM SSO subnet setting uses comma instead and this is not specified anywhere. So people try to use semicolon and it doesn't work.

      The attached patch adds a small not to the setting help text stating how to separate multiple subnets.

      Saludos.
      Iñaki.

        Gliffy Diagrams

        1. mdl-26634-19.diff
          1 kB
          Iñaki Arenaza
        2. mdl-26634-20.diff
          1 kB
          Iñaki Arenaza

          Activity

          Hide
          skodak Petr Skoda added a comment -

          Hello,
          I have create the integration request for you fixes. Sorry for not including you as the author in git commit, I did not know which email to use there, if you have any public repo feel free to link a branch there or you can create the PULL requests yourself.

          Thanks a lot for the report and patches.

          Petr

          Show
          skodak Petr Skoda added a comment - Hello, I have create the integration request for you fixes. Sorry for not including you as the author in git commit, I did not know which email to use there, if you have any public repo feel free to link a branch there or you can create the PULL requests yourself. Thanks a lot for the report and patches. Petr
          Hide
          tsala Helen Foster added a comment -

          Iñaki, thanks for your report and fixes, which are included in this week's 1.9.11+ and 2.0.2+.

          Show
          tsala Helen Foster added a comment - Iñaki, thanks for your report and fixes, which are included in this week's 1.9.11+ and 2.0.2+.

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/May/11