Moodle
  1. Moodle
  2. MDL-26644

'Completion tracking begins on enrolment' should not be in Moodle

    Details

    • Testing Instructions:
      Hide

      Pre-requisites

      • Enable the completion tracking enablecompletion.

      Test

      1. Upgrade to the latest and Make sure the course table (DB) does not contain the column completionstartonenrol any more.
      2. Run the PHP Unit tests to make sure the Web Services don't fail.
      3. Create a new course with Completion tracking enabled:
        • Make sure no error appear
      4. Edit the course settings:
        • Make sure no error appear
      5. Confirm that the completion tracking is enabled and works (you will have to add activities for that).
      1. As an admin, access the default course settings and make sure there is no setting for "Completion tracking begins on enrolment".
      2. Save the defaults, and make sure no error appeared.
      1. Install a fresh install, make sure there is no field completionstartonenrol in mdl_course.
      Show
      Pre-requisites Enable the completion tracking enablecompletion . Test Upgrade to the latest and Make sure the course table (DB) does not contain the column completionstartonenrol any more. Run the PHP Unit tests to make sure the Web Services don't fail. Create a new course with Completion tracking enabled: Make sure no error appear Edit the course settings: Make sure no error appear Confirm that the completion tracking is enabled and works (you will have to add activities for that). As an admin, access the default course settings and make sure there is no setting for "Completion tracking begins on enrolment". Save the defaults, and make sure no error appeared. Install a fresh install, make sure there is no field completionstartonenrol in mdl_course.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-26644-master
    • Rank:
      16221

      Description

      This config option, and all references, should not be in the code (doesn't do anything).

        Issue Links

          Activity

          Hide
          Rex Lorenzo added a comment -

          I was confused about this setting and found this tracker issue via the forum post: http://moodle.org/mod/forum/discuss.php?d=155158

          Hopefully this can be triaged and put into the next release because it is so minor?

          Show
          Rex Lorenzo added a comment - I was confused about this setting and found this tracker issue via the forum post: http://moodle.org/mod/forum/discuss.php?d=155158 Hopefully this can be triaged and put into the next release because it is so minor?
          Hide
          Howard Miller added a comment -

          However, this begs the question when should the 'timestarted' time stamp for course completion be set? Currently this only seems to be set at the same time as completion so it's pretty pointless. I'd quite like it to do something useful.

          Show
          Howard Miller added a comment - However, this begs the question when should the 'timestarted' time stamp for course completion be set? Currently this only seems to be set at the same time as completion so it's pretty pointless. I'd quite like it to do something useful.
          Hide
          Ray Lawrence added a comment -

          This option is still causing general confusion. Any further thoughts on it Aaron?

          Show
          Ray Lawrence added a comment - This option is still causing general confusion. Any further thoughts on it Aaron?
          Hide
          Helen Foster added a comment -

          Adding 2.4.3 as affects version, as this issue remains a problem.

          Show
          Helen Foster added a comment - Adding 2.4.3 as affects version, as this issue remains a problem.
          Hide
          Dan Poltawski added a comment -

          Looks great to me Fred. Sending for integration.

          Show
          Dan Poltawski added a comment - Looks great to me Fred. Sending for integration.
          Hide
          Mary Cooch added a comment -

          Just adding docs_required note to remember to document the removal

          Show
          Mary Cooch added a comment - Just adding docs_required note to remember to document the removal
          Hide
          Damyon Wiese added a comment -

          This looks good Fred,

          Integrated to master only.

          Show
          Damyon Wiese added a comment - This looks good Fred, Integrated to master only.
          Hide
          Damyon Wiese added a comment -

          Pushed one extra commit to remove this setting from the behat tests.

          Show
          Damyon Wiese added a comment - Pushed one extra commit to remove this setting from the behat tests.
          Hide
          Aaron Barnes added a comment -

          Thanks for getting this one guys

          Much appreciated.

          Show
          Aaron Barnes added a comment - Thanks for getting this one guys Much appreciated.
          Hide
          David Monllaó added a comment -

          It passes

          I see the debugging message already reported in MDL-38744, but nothing related with the removed field

          Did you remember to call setType() for 'criteria_grade_value'? Defaulting to PARAM_RAW cleaning.
          line 1291 of /lib/formslib.php: call to debugging()
          line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
          line 202 of /lib/formslib.php: call to moodleform->_process_submission()
          line 73 of /course/completion.php: call to moodleform->moodleform()
          
          Show
          David Monllaó added a comment - It passes I see the debugging message already reported in MDL-38744 , but nothing related with the removed field Did you remember to call setType() for 'criteria_grade_value'? Defaulting to PARAM_RAW cleaning. line 1291 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 73 of /course/completion.php: call to moodleform->moodleform()
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()
          Hide
          Mary Cooch added a comment -

          Removing docs_required as the setting is not referenced in the 2.5 docs now it has gone.

          Show
          Mary Cooch added a comment - Removing docs_required as the setting is not referenced in the 2.5 docs now it has gone.

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: