Moodle

Custom CSS not working in Nonzero CORE theme

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0, 2.0.1, 2.0.2
  • Fix Version/s: 2.0.3
  • Component/s: Themes
  • Labels:
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The [[setting:customcss]] setting has been omitted from the core.css file for the Nonzero CORE theme, rendering the option for the user to customise the CSS a pointless task!

Need to add the following to moodle/theme/nonzero/style/core.css

/** Custom CSS **/
[[setting:customcss]]

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Helen Foster added a comment -

Mary, thanks for your report.

Adding a fix version of stable backlog as part of our triaging process.

Show
Helen Foster added a comment - Mary, thanks for your report. Adding a fix version of stable backlog as part of our triaging process.
Hide
Permalink
Mary Evans added a comment -

Well Helen,

I've just made my first commit
it took me most of the day!!!
I thought it was going to be easy
but it turned out a bit of a git.
I pushed it, then I pulled it
then gave it a bit of a bash.
I nearly merged it but didn't
I almost threw it in the trash.
I sent it upstream, then down stream
Then went and laid down for a rest
till I finally picked up the courage
and put in a pull request...

Show
Mary Evans added a comment - Well Helen, I've just made my first commit it took me most of the day!!! I thought it was going to be easy but it turned out a bit of a git. I pushed it, then I pulled it then gave it a bit of a bash. I nearly merged it but didn't I almost threw it in the trash. I sent it upstream, then down stream Then went and laid down for a rest till I finally picked up the courage and put in a pull request...
Hide
Permalink
Mary Evans added a comment - - edited

Helen,

I was wondering if the reason the Pull-Request, which I did on for this issue, didn't go through might be because I was not the Assignee? Could this be the problem, do you think?

Mary

Show
Mary Evans added a comment - - edited Helen, I was wondering if the reason the Pull-Request, which I did on for this issue, didn't go through might be because I was not the Assignee? Could this be the problem, do you think? Mary
Hide
Permalink
Helen Foster added a comment -

Loved the poem, as did all at Moodle HQ!

Thanks for creating a pull request.

Show
Helen Foster added a comment - Loved the poem, as did all at Moodle HQ! Thanks for creating a pull request.
Hide
Permalink
Patrick Malley added a comment -

Mary - this ticket is resolved then - correct?

Helen - after a Pull-Request makes it into the core, do the HQ developers mark tickets as resolved? Or, is this something we should do once the Pull-Request has been submitted?

Show
Patrick Malley added a comment - Mary - this ticket is resolved then - correct? Helen - after a Pull-Request makes it into the core, do the HQ developers mark tickets as resolved? Or, is this something we should do once the Pull-Request has been submitted?
Hide
Permalink
Mary Evans added a comment -

Yes it is resolved. I was awaiting confirmation on what to do next. Seems like I forgot to close it!

Show
Mary Evans added a comment - Yes it is resolved. I was awaiting confirmation on what to do next. Seems like I forgot to close it!
Hide
Permalink
Helen Foster added a comment -

Whoa! You guys are so fast!

To answer Patrick's question, if a pull request passes the integration review and then passes testing, it is added to core. Once the weekly packages are available, the production maintainer (or me, if Petr is busy!) closes the issue. It's kind-of explained in the diagram http://docs.moodle.org/en/Development:Process#Workflow_in_tracker though maybe not so well

Mary, you didn't forget to close it as it shouldn't be closed until after the weekly package is available. Thus I'm just reopening it in order to mark it resolved again...

Show
Helen Foster added a comment - Whoa! You guys are so fast! To answer Patrick's question, if a pull request passes the integration review and then passes testing, it is added to core. Once the weekly packages are available, the production maintainer (or me, if Petr is busy!) closes the issue. It's kind-of explained in the diagram http://docs.moodle.org/en/Development:Process#Workflow_in_tracker though maybe not so well Mary, you didn't forget to close it as it shouldn't be closed until after the weekly package is available. Thus I'm just reopening it in order to mark it resolved again...
Hide
Permalink
Helen Foster added a comment -

Mary, thanks for your fix, which is included in this week's 2.0.2+.

Show
Helen Foster added a comment - Mary, thanks for your fix, which is included in this week's 2.0.2+.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: