Moodle
  1. Moodle
  2. MDL-26707

missing News forum - it doesn't appear if latest news block is missing in new courses

    Details

    • Testing Instructions:
      Hide

      1. Uncomment $CFG->defaultblocks_override and remove news_items.
      2. Add a new course.
      3. Verify that the new course has a news forum but not the Latest news block.

      Show
      1. Uncomment $CFG->defaultblocks_override and remove news_items. 2. Add a new course. 3. Verify that the new course has a news forum but not the Latest news block.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-26707-master
    • Rank:
      16311

      Description

      There is a problem while creating new courses. The news forum doesn't appear as usual if the latest news block is missing. You have to add the latest news block and than delete it again to make the news forum appear within your new created course. Refreshing doesn't help. It's quite annoying, because many people do not want to have there latest news block within their courses. There shouldn't be the need to add the latest news block just to make the news forum visible!

        Issue Links

          Activity

          Katarzyna Potocka created issue -
          Katarzyna Potocka made changes -
          Field Original Value New Value
          Security Minor security issue [ 10001 ]
          Katarzyna Potocka made changes -
          Description There is a problem while creating new courses. The news forum doesn't appear as usual if the latest news block is missing. You have to add the latest news block and than delete it again to make the news forum appear within your new created course. It's quite annoying, because many people do not want to have there latest news block within their courses. There is a problem while creating new courses. The news forum doesn't appear as usual if the latest news block is missing. You have to add the latest news block and than delete it again to make the news forum appear within your new created course. Refreshing doesn't help. It's quite annoying, because many people do not want to have there latest news block within their courses. There shouldn't be the need to add the latest news block just to make the news forum visible!
          Katarzyna Potocka made changes -
          Summary News forum doesn't appear if latest news block is missing in new courses missing News forum - it doesn't appear if latest news block is missing in new courses
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 68393 ] MDL Full Workflow [ 76065 ]
          Dan Poltawski made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Labels block, forum latest news, block, forum latest news, triaged
          Affects Version/s 2.2.2 [ 11552 ]
          Dan Poltawski made changes -
          Link This issue has a non-specific relationship to MDL-13258 [ MDL-13258 ]
          Hide
          Charles Fulton added a comment -

          I'm submitting a patch to add the forum creation to create_course() itself. It's not just a question of a buggy course--we turned off the news_items block in our default configuration so we don't have any news forums at all.

          Show
          Charles Fulton added a comment - I'm submitting a patch to add the forum creation to create_course() itself. It's not just a question of a buggy course--we turned off the news_items block in our default configuration so we don't have any news forums at all.
          Charles Fulton made changes -
          Pull Master Diff URL https://github.com/mackensen/moodle/compare/MDL-26707-master
          Pull Master Branch MDL-26707-master
          Testing Instructions 1. Remove news_items from $CFG->defaultblocks_override.
          2. Add a new course.
          3. Verify that the new course has a news forum.
          Pull from Repository https://github.com/mackensen/moodle
          Assignee moodle.com [ moodle.com ] Charles Fulton [ cfulton ]
          Affects Version/s 2.3.1 [ 12253 ]
          Charles Fulton made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Charles Fulton made changes -
          Testing Instructions 1. Remove news_items from $CFG->defaultblocks_override.
          2. Add a new course.
          3. Verify that the new course has a news forum.
          1. Uncomment $CFG->defaultblocks_override and remove news_items.
          2. Add a new course.
          3. Verify that the new course has a news forum but not the Latest news block.
          Charles Fulton made changes -
          Labels block, forum latest news, triaged block, forum latest news, patch triaged
          Frédéric Massart made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer fred
          Hide
          Frédéric Massart added a comment -

          Thanks for your patch Charles. Your code looks good.

          What would you think about a require_once instead of the include_once? The course creation would fail if the file is missing anyway.

          I think you can create branches for 2.2 and 2.3 and submit for integration whenever you like!

          Show
          Frédéric Massart added a comment - Thanks for your patch Charles. Your code looks good. What would you think about a require_once instead of the include_once? The course creation would fail if the file is missing anyway. I think you can create branches for 2.2 and 2.3 and submit for integration whenever you like!
          Frédéric Massart made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Hide
          Charles Fulton added a comment -

          Thanks Fred. Please note that I can't (as far as I know) submit for integration.

          Show
          Charles Fulton added a comment - Thanks Fred. Please note that I can't (as far as I know) submit for integration.
          Hide
          Frédéric Massart added a comment -

          Thanks Charles, pushing for integration now!

          Show
          Frédéric Massart added a comment - Thanks Charles, pushing for integration now!
          Frédéric Massart made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I've just been looking at this now for integration.
          At the moment my personal thought on this change is that it needs more discussion sorry.

          Currently the following happens:

          1. User creates a new course
          2. The news items block is added to the new course by default.
          3. When the news block is displayed the following happens:
            1. The news block looks at the courses newsitems setting.
            2. If the news items setting is > 0 then it gets the course news forum.
            3. If the course news forum doesn't exist it gets created.
            4. The block gets the last course.newsitems discussions for display.
          4. The news block displays the last course.newsitems discussions.

          Its important to note in this process that the news block is creating the news forum as part of its functionality and that the news forum then serves the purpose of the block.
          At the same time its important to note that we have a course setting called newsitems, and that it is there to facilitate the block.
          Looking at how things presently work I'm myself leaning towards the thought that that settings + the news forum belong to the block instance.
          This change I think goes against the nature of the design of this functionality (the block + the setting + the forum).
          While the purposed change looks 100% fine what we need to decide is whether we really want to decouple that relationship, so that in effect every course has a news forum regardless of the block.
          If we decide that is the path that we want to go down then this change + the tidy up of the news items block will be the way to go.
          Otherwise we leave everything as it is and perhaps look to improve the documentation of this area.

          Personally this change gets a -1 from me. I think that we should leave it as it and document things more thoroughly.
          But I imagine others will feel differently.

          I've left this in integration - integrators please let us know what you think.
          Also Fred + Charles, any input would be most welcome.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I've just been looking at this now for integration. At the moment my personal thought on this change is that it needs more discussion sorry. Currently the following happens: User creates a new course The news items block is added to the new course by default. When the news block is displayed the following happens: The news block looks at the courses newsitems setting. If the news items setting is > 0 then it gets the course news forum. If the course news forum doesn't exist it gets created. The block gets the last course.newsitems discussions for display. The news block displays the last course.newsitems discussions. Its important to note in this process that the news block is creating the news forum as part of its functionality and that the news forum then serves the purpose of the block. At the same time its important to note that we have a course setting called newsitems, and that it is there to facilitate the block. Looking at how things presently work I'm myself leaning towards the thought that that settings + the news forum belong to the block instance. This change I think goes against the nature of the design of this functionality (the block + the setting + the forum). While the purposed change looks 100% fine what we need to decide is whether we really want to decouple that relationship, so that in effect every course has a news forum regardless of the block. If we decide that is the path that we want to go down then this change + the tidy up of the news items block will be the way to go. Otherwise we leave everything as it is and perhaps look to improve the documentation of this area. Personally this change gets a -1 from me. I think that we should leave it as it and document things more thoroughly. But I imagine others will feel differently. I've left this in integration - integrators please let us know what you think. Also Fred + Charles, any input would be most welcome. Many thanks Sam
          Hide
          Charles Fulton added a comment -

          Sam,

          For me an important point is that current documentation (see esp. http://docs.moodle.org/23/en/News_forum) doesn't suggest the current relationship between the News Forum and the block. We were very surprised when our courses didn't have the news forum after we removed the block from our default configuration. In my view it's a bit of a hack to have the block created when the block gets viewed, and it's much better to handle it on course creation. I don't see why the two should be related since it's a perfectly reasonable use case to have the news forum for announcements and not have the block present. This change brings the code base in line with the documentation and user expectations.

          Charles

          Show
          Charles Fulton added a comment - Sam, For me an important point is that current documentation (see esp. http://docs.moodle.org/23/en/News_forum ) doesn't suggest the current relationship between the News Forum and the block. We were very surprised when our courses didn't have the news forum after we removed the block from our default configuration. In my view it's a bit of a hack to have the block created when the block gets viewed, and it's much better to handle it on course creation. I don't see why the two should be related since it's a perfectly reasonable use case to have the news forum for announcements and not have the block present. This change brings the code base in line with the documentation and user expectations. Charles
          Hide
          Frédéric Massart added a comment -

          Hi Sam,

          I have to say that I agree with Charles. To me this behaviour looked more like a hack and having the News forum to be created upon course creation makes more sense to me. I think there are a few inconsistencies here:

          • The block creates the News forum
          • The course setting 'News items to show' controls the number of items to display in the block
          • The block controls what News forum to fetch entries from: the first 'news' forum from an ordered by ID query.
          • Deleting the News forum won't work unless using a workaround (see http://docs.moodle.org/23/en/News_forum)

          I actually thought about taking this a step further and removing the ability from the block to create the news forum. IMO the block should not be responsible for creating the forum, but only displaying its information. Adding some settings to the block itself so that you can select the news forum to get information from might not be a bad idea either. Although these could probably be taken care of in another issue.

          Show
          Frédéric Massart added a comment - Hi Sam, I have to say that I agree with Charles. To me this behaviour looked more like a hack and having the News forum to be created upon course creation makes more sense to me. I think there are a few inconsistencies here: The block creates the News forum The course setting 'News items to show' controls the number of items to display in the block The block controls what News forum to fetch entries from: the first 'news' forum from an ordered by ID query. Deleting the News forum won't work unless using a workaround (see http://docs.moodle.org/23/en/News_forum ) I actually thought about taking this a step further and removing the ability from the block to create the news forum. IMO the block should not be responsible for creating the forum, but only displaying its information. Adding some settings to the block itself so that you can select the news forum to get information from might not be a bad idea either. Although these could probably be taken care of in another issue.
          Aparup Banerjee made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator nebgor
          Hide
          Aparup Banerjee added a comment - - edited

          Hi,
          i agree that decoupling this mechanism here is the actual question to be dealt with which will fix this issue. Either we stop the news block able to be 'missing' or we decouple.
          Definitely not wanting the block is a use case. I'm curious what the reasons to remove it are though.

          As this has been the 'way' for awhile and if we want to go ahead with this direction, we definitely need to have this discussion with more moodlers (devchat or forums etc).
          i suspect there are reasons for the coupling here that we haven't come across here yet.
          So reopening this for more discussion/votes/docs etc here for this change.

          Show
          Aparup Banerjee added a comment - - edited Hi, i agree that decoupling this mechanism here is the actual question to be dealt with which will fix this issue. Either we stop the news block able to be 'missing' or we decouple. Definitely not wanting the block is a use case. I'm curious what the reasons to remove it are though. As this has been the 'way' for awhile and if we want to go ahead with this direction, we definitely need to have this discussion with more moodlers (devchat or forums etc). i suspect there are reasons for the coupling here that we haven't come across here yet. So reopening this for more discussion/votes/docs etc here for this change.
          Aparup Banerjee made changes -
          Status Integration review in progress [ 10004 ] Reopened [ 4 ]
          CiBoT made changes -
          Status Reopened [ 4 ] Reopened [ 4 ]
          Currently in integration Yes [ 10041 ]
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Charles Fulton added a comment -

          @Aparup, we removed the block because we were aiming for a simplified course layout with our 2.3 launch, after things got cluttered in 1.9. We make very particular choices about which blocks to retain, and most the faculty we surveyed don't use the Latest News block. Further, our use case for the News Forum has nothing to do with the block and this feels rather like a cart before the horse situation to me. Our culture (like many schools) is email-centric and faculty use the News Forum for announcements.

          It doesn't make sense to me to make forum functionality dependent on the block which reports it. I'm all for finding a way to do this better, with actual configuration settings, but that's new functionality which probably wouldn't land until 2.5 anyway.

          Show
          Charles Fulton added a comment - @Aparup, we removed the block because we were aiming for a simplified course layout with our 2.3 launch, after things got cluttered in 1.9. We make very particular choices about which blocks to retain, and most the faculty we surveyed don't use the Latest News block. Further, our use case for the News Forum has nothing to do with the block and this feels rather like a cart before the horse situation to me. Our culture (like many schools) is email-centric and faculty use the News Forum for announcements. It doesn't make sense to me to make forum functionality dependent on the block which reports it. I'm all for finding a way to do this better, with actual configuration settings, but that's new functionality which probably wouldn't land until 2.5 anyway.
          Hide
          Kevin Wiliarty added a comment -

          I frequently work with faculty who want to use the News Forum, but who do not want to have a Latest News block. It is a design choice for them; they want to keep the layout simple. None of them suspects that the forum is dependent on the block, so I would welcome the change proposed here. If it implies a deeper change, then I would support that, too.

          Show
          Kevin Wiliarty added a comment - I frequently work with faculty who want to use the News Forum, but who do not want to have a Latest News block. It is a design choice for them; they want to keep the layout simple. None of them suspects that the forum is dependent on the block, so I would welcome the change proposed here. If it implies a deeper change, then I would support that, too.
          Hide
          Robert Puffer added a comment -

          The old workflow is SO unintuitive unless you always add the news block which we don't don because its pretty much one of the least useful blocks around and we don't waste screen real estate – it cluttered enough. Sans the newsblock an instructor would find it nearly impossible to figure out how to get their news forum (important to many).

          Show
          Robert Puffer added a comment - The old workflow is SO unintuitive unless you always add the news block which we don't don because its pretty much one of the least useful blocks around and we don't waste screen real estate – it cluttered enough. Sans the newsblock an instructor would find it nearly impossible to figure out how to get their news forum (important to many).
          Hide
          Aparup Banerjee added a comment -

          Thanks for the reasons, paints a better picture

          I've spoken with Eloy...

          so noting: it seems that this behaviour change might have undesirable effects if backported to stable branches for some who are used to this behaviour. so to cater to any backporting we could consider a setting 'CFG->createnewsforumoncoursecreation = true;' or so..

          for master, i've added MD here for his comment

          Show
          Aparup Banerjee added a comment - Thanks for the reasons, paints a better picture I've spoken with Eloy... so noting: it seems that this behaviour change might have undesirable effects if backported to stable branches for some who are used to this behaviour. so to cater to any backporting we could consider a setting 'CFG->createnewsforumoncoursecreation = true;' or so.. for master, i've added MD here for his comment
          Hide
          Charles Fulton added a comment -

          Hello, is there any progress on this issue?

          Show
          Charles Fulton added a comment - Hello, is there any progress on this issue?
          Hide
          Martin Dougiamas added a comment -

          I can add a historical perspective, which is that the News forums pre-dates blocks, and also that I think a News forum is an essential thing for a course, and I wanted to "impose" it on teachers in case they forgot or didn't know about it (social constructivism, remember). Also note that the forum is the only non-optional module in Moodle.

          That said, the forum is not dependent on the block. The block is simply dependent on the forum, and the forum is a "special" news forum (that's how the block knows which forum to be dependent on, if the course has many forums). I made the block re-create the block if it was missing to make sure the forum was created properly.

          Although I know this is not super-intuitive, I'm not sure what the problem is here. Three existing workarounds are:

          a) simply create a news forum manually, force subscription etc
          b) add the block temporarily (the forum will be created), then remove the block
          c) use the latest news block because it's actually useful for students.

          If I was designing this from scratch again I would probably have some admin settings to manage default course templates, and everywhere we create new courses we would have to specify a template. The default template would include a News forum. I'd also change the "Latest news" block to a "Latest posts" block which could be configured to point to one or more forums.

          (Note that the patch on this bug is not a solution because courses are created in all sorts of ways ... the minimum requirement is actually just a new record in the course table.)

          Show
          Martin Dougiamas added a comment - I can add a historical perspective, which is that the News forums pre-dates blocks, and also that I think a News forum is an essential thing for a course, and I wanted to "impose" it on teachers in case they forgot or didn't know about it (social constructivism, remember). Also note that the forum is the only non-optional module in Moodle. That said, the forum is not dependent on the block. The block is simply dependent on the forum, and the forum is a "special" news forum (that's how the block knows which forum to be dependent on, if the course has many forums). I made the block re-create the block if it was missing to make sure the forum was created properly. Although I know this is not super-intuitive, I'm not sure what the problem is here. Three existing workarounds are: a) simply create a news forum manually, force subscription etc b) add the block temporarily (the forum will be created), then remove the block c) use the latest news block because it's actually useful for students. If I was designing this from scratch again I would probably have some admin settings to manage default course templates, and everywhere we create new courses we would have to specify a template. The default template would include a News forum. I'd also change the "Latest news" block to a "Latest posts" block which could be configured to point to one or more forums. (Note that the patch on this bug is not a solution because courses are created in all sorts of ways ... the minimum requirement is actually just a new record in the course table.)
          Hide
          Eric Merrill added a comment -

          Without some sort of solution to this, it leaves the admins in a odd situation. You can not configure Moodle to not have the Latest News block, and still have the News Forum, which is non-intuitive - and not properly documented.

          Honestly the way that it is currently done seems like much more of a hack than the proposed patch - if you happen to be the first one to view a newly created course, there is no news forum, but if you reload, or someone else views it, it is there, how does that make sense?

          The argument that this doesn't work if you just insert into mdl_course... doesn't make sense. If you do that now, the course will have none of the default blocks/content, and won't get the news forum anyways. Adding this patch doesn't change anything in that regard, it mearly makes it more consistant in that if make a course (with proper API calls) you get the News Forum, even if you don't have Recent News in your default blocks - as the documentation indicates it should be.

          Show
          Eric Merrill added a comment - Without some sort of solution to this, it leaves the admins in a odd situation. You can not configure Moodle to not have the Latest News block, and still have the News Forum, which is non-intuitive - and not properly documented. Honestly the way that it is currently done seems like much more of a hack than the proposed patch - if you happen to be the first one to view a newly created course, there is no news forum, but if you reload, or someone else views it, it is there, how does that make sense? The argument that this doesn't work if you just insert into mdl_course... doesn't make sense. If you do that now, the course will have none of the default blocks/content, and won't get the news forum anyways. Adding this patch doesn't change anything in that regard, it mearly makes it more consistant in that if make a course (with proper API calls) you get the News Forum, even if you don't have Recent News in your default blocks - as the documentation indicates it should be.
          Hide
          Eric Merrill added a comment - - edited

          Oh I would note though - I think there should be a CFG setting for this - even if it has no front end control. I hate forced things. Many of the patches we run in prod are to change things that were just somebodies (or multiple peoples) preference when they wrote the code.

          Show
          Eric Merrill added a comment - - edited Oh I would note though - I think there should be a CFG setting for this - even if it has no front end control. I hate forced things. Many of the patches we run in prod are to change things that were just somebodies (or multiple peoples) preference when they wrote the code.
          Hide
          Mark Drechsler added a comment -

          I think Martin hit it on the head when he said "If I was designing this from scratch again I would probably have some admin settings to manage default course templates, and everywhere we create new courses we would have to specify a template."

          To me, it looks like this can either be fixed quickly, or fixed properly. The quick fix is to apply the patch and/or update the documentation, leaving things more or less as they are - an unintuitive hangover from a decision made ten years ago in the early days of Moodle. The proper fix is to go right back to first principles and design a better way of managing course templates in Moodle that provides more control for site admins when deploying new courses (I could also add http://tracker.moodle.org/browse/MDL-19753 into this as another potential improvement) - which of course takes more time, and more resources, to implement.

          Speaking from the perspective of the clients I work with this isn't considered a 'big deal', but more of a minor annoyance - but also acknowledging that none I know of have attempted to remove the Latest News block from their default course layout, which would indeed make a difference.

          No answers from me - just thought I'd add another perspective.

          Show
          Mark Drechsler added a comment - I think Martin hit it on the head when he said "If I was designing this from scratch again I would probably have some admin settings to manage default course templates, and everywhere we create new courses we would have to specify a template." To me, it looks like this can either be fixed quickly, or fixed properly. The quick fix is to apply the patch and/or update the documentation, leaving things more or less as they are - an unintuitive hangover from a decision made ten years ago in the early days of Moodle. The proper fix is to go right back to first principles and design a better way of managing course templates in Moodle that provides more control for site admins when deploying new courses (I could also add http://tracker.moodle.org/browse/MDL-19753 into this as another potential improvement) - which of course takes more time, and more resources, to implement. Speaking from the perspective of the clients I work with this isn't considered a 'big deal', but more of a minor annoyance - but also acknowledging that none I know of have attempted to remove the Latest News block from their default course layout, which would indeed make a difference. No answers from me - just thought I'd add another perspective.
          Hide
          Martin Dougiamas added a comment - - edited

          All this patch helps is this group of people: "I like having the news forum created automatically for me in new courses but I don't like having a Latest News block".

          But I'll support the patch (+1) if this is a significant number of people. I don't think the patch actually hurts anything at all except possibly performance when auto-creating a batch of courses.

          I still don't think it's a real solution though, and that the proper way to solve "I like having certain things in my courses when they are created" is the template solution, as I outlined above. That solution will make this one obsolete.

          (And Eric, you are right about the course record ... it used to work correctly that way long ago and people's hacks relied on it but I just tried it and it doesn't work any more in 2.3).

          Show
          Martin Dougiamas added a comment - - edited All this patch helps is this group of people: "I like having the news forum created automatically for me in new courses but I don't like having a Latest News block". But I'll support the patch (+1) if this is a significant number of people. I don't think the patch actually hurts anything at all except possibly performance when auto-creating a batch of courses. I still don't think it's a real solution though, and that the proper way to solve "I like having certain things in my courses when they are created" is the template solution, as I outlined above. That solution will make this one obsolete. (And Eric, you are right about the course record ... it used to work correctly that way long ago and people's hacks relied on it but I just tried it and it doesn't work any more in 2.3).
          Charles Fulton made changes -
          Link This issue is duplicated by MDL-36165 [ MDL-36165 ]
          Chris Follin made changes -
          Labels block, forum latest news, patch triaged block, forum latest moodlerooms news, partner patch triaged
          Hide
          Charles Fulton added a comment -

          Would it be appropriate to raise a policy question for this issue, as outlined in MDL-39214? Alternatively, is there some threshold level of support necessary for decoupling the Latest News block and the News Forum? Note the related issues; it's not just my cohort who thinks this behavior is buggy and non-intuitive, and I don't see why we have to solve the entire problem of course templating in order to resolve this issue.

          In the interim this is rebased against 2.5.

          Show
          Charles Fulton added a comment - Would it be appropriate to raise a policy question for this issue, as outlined in MDL-39214 ? Alternatively, is there some threshold level of support necessary for decoupling the Latest News block and the News Forum? Note the related issues; it's not just my cohort who thinks this behavior is buggy and non-intuitive, and I don't see why we have to solve the entire problem of course templating in order to resolve this issue. In the interim this is rebased against 2.5.
          Charles Fulton made changes -
          Aparup Banerjee made changes -
          Link This issue will be (partly) resolved by MDL-39225 [ MDL-39225 ]
          Aparup Banerjee made changes -
          Link This issue will be (partly) resolved by MDL-39226 [ MDL-39226 ]
          Hide
          Aparup Banerjee added a comment -

          Yes Charles, i think a policy issue would help move this along as well as a forum discussion to get more opinions.

          Show
          Aparup Banerjee added a comment - Yes Charles, i think a policy issue would help move this along as well as a forum discussion to get more opinions.
          Charles Fulton made changes -
          Link This issue is blocked by MDL-39247 [ MDL-39247 ]
          Charles Fulton made changes -
          Link This issue will help resolve MDL-40640 [ MDL-40640 ]
          Hide
          Michael Domingues added a comment -

          As an added consequence of the tight coupling between the News Block and the News Forum, News Forums are erroneously generated (and written to DB) in the language of the first user to visit the course, as opposed to using the course language setting. Outlined in MDL-40640. To respond to Martin's latest comment, this is more than just an aesthetic preference. I agree that a template system would be ideal, but for the here and now, especially when the current design introduces additional erroneous behavior, I think we ought to move forward with Charles's solution.

          Show
          Michael Domingues added a comment - As an added consequence of the tight coupling between the News Block and the News Forum, News Forums are erroneously generated (and written to DB) in the language of the first user to visit the course, as opposed to using the course language setting. Outlined in MDL-40640 . To respond to Martin's latest comment, this is more than just an aesthetic preference. I agree that a template system would be ideal, but for the here and now, especially when the current design introduces additional erroneous behavior, I think we ought to move forward with Charles's solution.
          Michael de Raadt made changes -
          Fix Version/s FRONTEND [ 12581 ]
          Labels block, forum latest moodlerooms news, partner patch triaged moodlerooms partner patch triaged

            People

            • Votes:
              23 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated: