Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26712

Hidden labels with textdecoration are not "hidden" for teachers

    Details

    • Testing Instructions:
      Hide

      1) Go to the courses weekly outline.
      2) Add a resource - label.
      3) Enter in Label text. Set visible to hide.
      4) Check to make sure that text is grey.
      5) Edit the label and change the text colour to red.
      6) save and return to course - ensure that the label is now dimmed.

      Please test in IE as well as other browsers.

      Show
      1) Go to the courses weekly outline. 2) Add a resource - label. 3) Enter in Label text. Set visible to hide. 4) Check to make sure that text is grey. 5) Edit the label and change the text colour to red. 6) save and return to course - ensure that the label is now dimmed. Please test in IE as well as other browsers.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-26712-master

      Description

      If different acitivities and ressources are hidden by teachers, they appear for teachers as "invisible" = grey on the course site. For labels there is the same behaviour unless the labels font-color was edited (eg. to red). In that case the font-color for the hidden labels appears on the course site for teachers as changed (eg. red) and not as usual for "dimmed_text"= grey.
      In my opinion it should appear like all the other "hidden" resources, not depending on the changed "visible" color.

      The attachment shows a hidden label on the demo.moodle.net site.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            phalacee Jason Fowler added a comment -

            I am looking to bypass the need to over-ride the colour of the labels by using a CSS opacity property instead, when applied to black text on a white background, this would have the same result as setting the text to #AAAAAA in colour (the current method used). This would allow the colour of the text to still be set, and then when the label is made invisible, it would be shown as dimmed.

            I am struggling with getting this to work in IE7 and IE8 at the moment, but IE9 and all other non-microsoft browsers seem to work fine.

            Show
            phalacee Jason Fowler added a comment - I am looking to bypass the need to over-ride the colour of the labels by using a CSS opacity property instead, when applied to black text on a white background, this would have the same result as setting the text to #AAAAAA in colour (the current method used). This would allow the colour of the text to still be set, and then when the label is made invisible, it would be shown as dimmed. I am struggling with getting this to work in IE7 and IE8 at the moment, but IE9 and all other non-microsoft browsers seem to work fine.
            Hide
            abgreeve Adrian Greeve added a comment -

            Looks like a simple fix that has taken into account different browser types and versions.

            Show
            abgreeve Adrian Greeve added a comment - Looks like a simple fix that has taken into account different browser types and versions.
            Hide
            phalacee Jason Fowler added a comment -

            Thanks for adding the testing instructions to the issue Adrian

            Show
            phalacee Jason Fowler added a comment - Thanks for adding the testing instructions to the issue Adrian
            Hide
            nebgor Aparup Banerjee added a comment -

            Thank you for this cool fix, this has been integrated.
            Tester: please test on variety of browsers and play with text colours and sizes too.

            Show
            nebgor Aparup Banerjee added a comment - Thank you for this cool fix, this has been integrated. Tester: please test on variety of browsers and play with text colours and sizes too.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Jason.
            Works as mentioned in ie, FF, chrome and opera

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Jason. Works as mentioned in ie, FF, chrome and opera
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi guys,

            Just noting I've opened MDL-31008 to look to tidy up the solution on this issue.
            The solution itself is a smart solution for the hidden label issue, however it should not have been applied to all of the dimmed styles.
            See the issue created for more details.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi guys, Just noting I've opened MDL-31008 to look to tidy up the solution on this issue. The solution itself is a smart solution for the hidden label issue, however it should not have been applied to all of the dimmed styles. See the issue created for more details. Cheers Sam

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11