Moodle
  1. Moodle
  2. MDL-26747

Course reports should be able to have settings.php files

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: Administration
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16662

      Description

      If you put a settings.php into /course/report/something then, at present, this file is never even used.

      Since settings.php is part of the standard plugin interface, it ought to be implemented for course reports.

      (Course reports do appear in the settings menu for courses, but this is where you run the report for an individual course. A course report might also have sitewide settings. These should be available and searchable on the admin menu like all other settings.)

      I would suggest that course report settings.php should

      (a) work the same way as every other settings.php

      (b) the settings should appear in the tree within Plugins/Course reports

        Activity

        Hide
        Tim Hunt added a comment -

        Possible implementation of this feature at https://github.com/timhunt/moodle/compare/master...MDL-26747.

        Testing/review welcome.

        Show
        Tim Hunt added a comment - Possible implementation of this feature at https://github.com/timhunt/moodle/compare/master...MDL-26747 . Testing/review welcome.
        Hide
        Sam Marshall added a comment -

        The attached file can be used for testing; place it as course/report/log/settings.php

        Show
        Sam Marshall added a comment - The attached file can be used for testing; place it as course/report/log/settings.php
        Hide
        Sam Marshall added a comment -

        Filed PULL-433 (which also has information about how to test using the file that is attached in here).

        Show
        Sam Marshall added a comment - Filed PULL-433 (which also has information about how to test using the file that is attached in here).
        Hide
        Sam Marshall added a comment -

        Test sequence:

        1. Visit notifications page. In admin block, expand plugins setting. Verify that nothing has changed, in particular there is no 'Course reports' subcategory.

        2. Place the attached settings.php into the course/report/log folder.

        3. Visit notifications page. Verify that you get a prompt to set the (slightly silly) new test setting.

        4. Confirm prompt. In admin block, expand plugins setting. Verify that there is a 'Course reports' subcategory. Expand this. Verify that there is a 'Logs' entry.

        5. Click on logs entry. Verify that you see a settings page with the test setting.

        Once test is complete, remember to delete the unnecessary settings.php.

        Show
        Sam Marshall added a comment - Test sequence: 1. Visit notifications page. In admin block, expand plugins setting. Verify that nothing has changed, in particular there is no 'Course reports' subcategory. 2. Place the attached settings.php into the course/report/log folder. 3. Visit notifications page. Verify that you get a prompt to set the (slightly silly) new test setting. 4. Confirm prompt. In admin block, expand plugins setting. Verify that there is a 'Course reports' subcategory. Expand this. Verify that there is a 'Logs' entry. 5. Click on logs entry. Verify that you see a settings page with the test setting. Once test is complete, remember to delete the unnecessary settings.php.
        Hide
        Helen Foster added a comment -

        This new feature is included in the latest 2.0.2+. Thanks everyone.

        Show
        Helen Foster added a comment - This new feature is included in the latest 2.0.2+. Thanks everyone.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: