Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Only dev can test it (web service experience recommended):

      Enable the unit test for this function (webservice/simpletest => enable protocol, function and token)

      Then run unit test (after editing it at your convenience). Check that the site information returned are correct. You can write and check the value in your php log to do that.

      Show
      Only dev can test it (web service experience recommended): Enable the unit test for this function (webservice/simpletest => enable protocol, function and token) Then run unit test (after editing it at your convenience). Check that the site information returned are correct. You can write and check the value in your php log to do that.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-26777-wip

      Description

      MUST BE INTEGRATED AFTER MDL-27551

      We need a web service function to return basic site info, especially site name.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Helen Foster added a comment -

            Guessing DEV backlog should be the fix version, rather than the affects version

            Show
            Helen Foster added a comment - Guessing DEV backlog should be the fix version, rather than the affects version
            Hide
            Dongsheng Cai added a comment -

            That's right! Thanks helen

            Show
            Dongsheng Cai added a comment - That's right! Thanks helen
            Hide
            Dongsheng Cai added a comment -

            Jerome, this web service needs to return wwwroot, so we could make use of it in "Web" icon.

            Show
            Dongsheng Cai added a comment - Jerome, this web service needs to return wwwroot, so we could make use of it in "Web" icon.
            Hide
            Jérôme Mouneyrac added a comment -

            TODO: add this service name into the service of MDL-27551

            Show
            Jérôme Mouneyrac added a comment - TODO: add this service name into the service of MDL-27551
            Hide
            Jérôme Mouneyrac added a comment -

            It has been tested when a web service client asks for:

            • a disabled service (empty list of function)
            • the default mobile service
            • local plugin
            • multiple service
            Show
            Jérôme Mouneyrac added a comment - It has been tested when a web service client asks for: a disabled service (empty list of function) the default mobile service local plugin multiple service
            Hide
            Dongsheng Cai added a comment -

            Just a typo 'new exception' should use moodle_exception

            Show
            Dongsheng Cai added a comment - Just a typo 'new exception' should use moodle_exception
            Hide
            Jérôme Mouneyrac added a comment -

            did only few changes since last peer-review, sending directly for integration

            Show
            Jérôme Mouneyrac added a comment - did only few changes since last peer-review, sending directly for integration
            Hide
            Jérôme Mouneyrac added a comment -

            DO NOT INTEGRATE BEFORE MDL-27551 HAS BEEN INTEGRATED

            Show
            Jérôme Mouneyrac added a comment - DO NOT INTEGRATE BEFORE MDL-27551 HAS BEEN INTEGRATED
            Hide
            Jérôme Mouneyrac added a comment -

            MAKING A LAST MINUTE CHANGE - PLEASE DO NOT INTEGRATE YET

            Show
            Jérôme Mouneyrac added a comment - MAKING A LAST MINUTE CHANGE - PLEASE DO NOT INTEGRATE YET
            Hide
            Jérôme Mouneyrac added a comment -

            DO NOT INTEGRATE BEFORE MDL-27551 HAS BEEN INTEGRATED

            thank you can integrate again, I fixed it and rebased (so finally it was a good idea ). I also checked whitespaces and bumped the last version.php.

            Show
            Jérôme Mouneyrac added a comment - DO NOT INTEGRATE BEFORE MDL-27551 HAS BEEN INTEGRATED thank you can integrate again, I fixed it and rebased (so finally it was a good idea ). I also checked whitespaces and bumped the last version.php.
            Hide
            Sam Hemelryk added a comment -

            Thanks guys integrated now.

            Show
            Sam Hemelryk added a comment - Thanks guys integrated now.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Passing thanks (entirely relying in your own tests)

            Show
            Eloy Lafuente (stronk7) added a comment - Passing thanks (entirely relying in your own tests)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This is now upstream, yay! Many thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This is now upstream, yay! Many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: