Buggy grading in lesson containing essays

Joseph, thanks for your report with clear description. Hoping this issue can be fixed soon.

Andrew added as watcher in case this is more a gradebook issue than a lesson issue.

Hi Helen and Andrew,
Just to mention that that bug now has 14 votes...and fixing is still pending.
Joseph

Hi Joseph,

I just created a patch to fix the issue. When you have a chance, could you test the patch and let me know if it fixes the issue?

Patch: https://github.com/rwijaya/moodle/compare/MOODLE_20_STABLE...MDL-26788_m20

Thanks
Rosie

Hi Rosie,
Just tested your patch. Things look better for the first part of my scenario, but the essay grade is still not recorded. Here is the new scenario:

Scenario:

Q1 multiple choice score /5
Q2 multiple choice score /5
Q3 essay score /10

student answers
Q1 correct (5/5)
Q2 wrong (0/5)
Q3 student writes essay

Congratulations - end of lesson reached
You earned 5 out of 10 for the automatically graded questions.
Your 1 essay question(s) will be graded and added
into your final score at a later date.

Your current grade without the essay question(s) is 5 out of 20
Grade report: Lesson: 25%
—
teacher marks Q3 essay 5/10
Grade of essay is not saved
Grade report: Lesson: 25% (not changed)

Hope you can fix the "Essay grade not saved" bug...

Hi Joseph,

Thank you for testing. Question regarding the issue, do you have any specific setting for the lesson?

I can't reproduce the error based on the above scenario.

Adding Apu to review the patch.

Hi Apu,

When you have a chance, could you take a look the patch?

Thanks
Rosie

Hi Rosie,
Sorry about my previous comment. Just tried again and your patch is working fine !
Thank you,
Joseph

Hi Rosie,
The code looks okay to me.
oh, Have you considered implementing the fix in a small class that overrides the earned_score() method ?
cheers,
Aparup

Have discussion with Aparup regarding class overrides that required instantiating unnecessary method for earned_score(). We decided not to create new class to fix the issue.

Thanks Joseph and Aparup for testing the patch.

Rosie

Hi Rossie, which is the cause for moving the:

$essayinfo->score = clean_param($form->score, PARAM_INT);

to:

$score = optional_param('score', 0, PARAM_INT);

IMO, if it's part of the $form, it should be handled in the former way, I think the second is better for GET requests and friends.

Ciao

Edited: In fact, the essay_form already has the type for 'score' defined as integer, that should be enough to get the field automatically cleaned, isn't it? So perhaps none of them are needed and cleaned info is already in $mform->score ?

i've quickly tried the below without luck. didn't work.
$essayinfo->score = $form->score;

$form has : stdClass Object\n(\n [id] => 135\n [attemptid] => 373\n [mode] => update\n [response] => sfedsferdfv\n [submitbutton] => Save changes\n)\n

$form->score probably needs to be cleaned up, its not used anywhere else that i can see.. but Rossi's patch works.

Ok, this has been integrated in its current status as far as 2.0.3 release is imminent and testing reports are ok.

Anyway, plz, fill a new MDL issue about reviewing why that stuff is not coming in the $form and how it should be fixed / improved.

Ciao

Test passed based in previous reports about it working.

Closing as fixed. Many thanks!