[MDL-26796] stop accepting arrays in required_param() and optional_param() - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.0.2
Fix Version/s: 2.2
Component/s: General
Labels:
- triaged

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_22_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Main Branch:
w33_~~MDL-26796~~_m22_arrayparams
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/master...w33_MDL-26796_m22_arrayparams
URL:
http://moodle.org/mod/forum/discuss.php?d=183360
Testing Instructions:

Hide

Visit pretty much all moodle pages and report regressions as new issues.

Show
Visit pretty much all moodle pages and report regressions as new issues.

Description

This is a old hack, I should have protested when this was proposed. This can interfere with our DB layer and other parts of moodle, it may create random errors...
Solution is to add one more optional parameter or different functions.

We can not forbid it in stable because some parts rely on it...

Attachments

Issue Links

caused a regression

MDL-29104 Checking permissions in a course throws a debugging error

Closed

MDL-29107 Messaging course users throws notice

Closed

MDL-30322 qtype calculated* & multianswer forms need to be converted to use optional_param_array

Closed

MDL-50260 Remove unnecessary check in optional_param()

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Integrator:: Eloy Lafuente (stronk7)

Tester:: Rajesh Taneja

Participants:: Eloy Lafuente (stronk7), Helen Foster, Petr Skoda, Rajesh Taneja, Sam Hemelryk, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 14/Mar/11 7:51 AM

Updated:: 18/May/15 11:11 PM

Resolved:: 27/Aug/11 2:02 PM

Fix Release Date:: 5/Dec/11