Moodle
  1. Moodle
  2. MDL-26804

Clean-up legacy references to moodledata/cache/languages and reimplement caching of the list of translations

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: Language
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      During the review of PULL-431, Eloy detected some references to $CFG->dataroot.'/cache/languages'. This used to be a file holding the list of all installed languages (if $CFG->langcache was enabled) and was used by get_list_of_languages(). This function was then refactored to a method of the string manager get_list_of_translations(). The new method does not use any caching yet, there is a todo for it.

      Also, it seems that the path moodledata/cache/languages is used as a directory at several places. That was my mistake at a9e41d and needs fixing.

        Gliffy Diagrams

          Activity

          Hide
          David Mudrak added a comment -

          Patch submitted for review and integration.

          Show
          David Mudrak added a comment - Patch submitted for review and integration.
          Hide
          Helen Foster added a comment -

          Thanks again David

          Show
          Helen Foster added a comment - Thanks again David

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: