Moodle

enrol_user() does not use $status param

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.0.2
  • Fix Version/s: 2.0.3
  • Component/s: Enrolments
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

enrollib.php : enrol_user() should use its $status param

Issue Links

blocks

Improvement - An enhancement to an existing Moodle feature. MDL-26250 Create a web service function that enrols users to a certain course

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jérôme Mouneyrac added a comment -

Not that the fix will have a very weak impact as the only place where $status argument is used is in this backup call:
backup/moodle2/restore_stepslib.php

/**
     * Create user enrolments
     *
     * This has to be called after creation of enrolment instances
     * and before adding of role assignments.
     *
     * @param mixed $data
     * @return void
     */
    public function process_enrolment($data) {
        global $DB;

        $data = (object)$data;

        // Process only if parent instance have been mapped
        if ($enrolid = $this->get_new_parentid('enrol')) {
            if ($instance = $DB->get_record('enrol', array('id'=>$enrolid))) {
                // And only if user is a mapped one
                if ($userid = $this->get_mappingid('user', $data->userid)) {
                    $enrol = enrol_get_plugin($instance->enrol);
                    //TODO: do we need specify modifierid?
                    $enrol->enrol_user($instance, $userid, null, $data->timestart, $data->timeend, $data->status);
                    //note: roles are assigned in restore_ras_and_caps_structure_step::process_assignment() processing above
                }
            }
        }
    }
Show
Jérôme Mouneyrac added a comment - Not that the fix will have a very weak impact as the only place where $status argument is used is in this backup call: backup/moodle2/restore_stepslib.php /** * Create user enrolments * * This has to be called after creation of enrolment instances * and before adding of role assignments. * * @param mixed $data * @ return void */ public function process_enrolment($data) { global $DB; $data = (object)$data; // Process only if parent instance have been mapped if ($enrolid = $ this ->get_new_parentid('enrol')) { if ($instance = $DB->get_record('enrol', array('id'=>$enrolid))) { // And only if user is a mapped one if ($userid = $ this ->get_mappingid('user', $data->userid)) { $enrol = enrol_get_plugin($instance->enrol); //TODO: do we need specify modifierid? $enrol->enrol_user($instance, $userid, null , $data->timestart, $data->timeend, $data->status); //note: roles are assigned in restore_ras_and_caps_structure_step::process_assignment() processing above } } } }
Hide
Permalink
Jérôme Mouneyrac added a comment -

patch: https://github.com/mouneyrac/moodle/commit/d587f077ef87367dc9d69ecfee4320ef0a1bc090

Show
Jérôme Mouneyrac added a comment - patch: https://github.com/mouneyrac/moodle/commit/d587f077ef87367dc9d69ecfee4320ef0a1bc090
Hide
Permalink
Helen Foster added a comment -

Thanks Jerome

Show
Helen Foster added a comment - Thanks Jerome

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: