Moodle
  1. Moodle
  2. MDL-26826

Add the ability to customize dimensions (#d) to the youtube and vimeo videos

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: Filters
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16777

      Description

      After MDL-26697 has landed upstream... the only tiny bit missing that could be helpful under some situations is to extend the youtube/vimeo embeds to also use the #d=400x300 trick to customize the size.

      Not critical but a little extra.

      Ciao

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          Patch submitted, please note it also removes the support for % sizes because they are not supported in object tags. We could try to work around it with hardcoded CSS but I think it does not have much sense for embedded media anyway...

          Show
          Petr Škoda added a comment - Patch submitted, please note it also removes the support for % sizes because they are not supported in object tags. We could try to work around it with hardcoded CSS but I think it does not have much sense for embedded media anyway...
          Hide
          Petr Škoda added a comment -

          if somebody used % sizes in old code they will get default sizes or 0-100 pixel width when d=500x80%, but I guess it was borked for a long time already, so there should not be any BC problems...

          Show
          Petr Škoda added a comment - if somebody used % sizes in old code they will get default sizes or 0-100 pixel width when d=500x80%, but I guess it was borked for a long time already, so there should not be any BC problems...
          Hide
          Sam Hemelryk added a comment -

          Sorry wrong issue

          Show
          Sam Hemelryk added a comment - Sorry wrong issue
          Hide
          Helen Foster added a comment -

          Thanks Eloy and Petr.

          Show
          Helen Foster added a comment - Thanks Eloy and Petr.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: