Moodle
  1. Moodle
  2. MDL-26832

META - Several repository & file picker bugs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.3
    • Component/s: Repositories
    • Labels:
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      16451

      Description

      • When using the file picker and you have "View as List" activated, then paging doesn't work. It appears that the page number is not passed in the AJAX request, so the first page's content is always returned.
      • The default when viewing content in the repository file picker is the "View as Icons", but it doesn't initially render as "Selected" or "Highlighted". It's only after "View as List" has been selected and then "View as Icons" has been reselected.
      • When searching, should this dialog be modal? Currently you can mess around with the main file picker window when the search dialog is up.
      • The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name].
      • When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
      • The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog.
      • Script error displays when selecting a file while file are displayed in view as list mode in IE8. Error details:
        Message: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.
        Line: 2649
        Char: 25
        Code: 0
        URI: http://yui.yahooapis.com/combo?2.8.2/build/treeview/treeview-debug.js
        
      • (Note: might be related to above issue with pushing return/enter in search dialog) Error when enter/return key is pressed in the search dialog in IE8. Error details:
        Message: Invalid argument.
        Line: 482
        Char: 4
        Code: 0
        URI: http://yui.yahooapis.com/combo?2.8.2/build/yahoo-dom-event/yahoo-dom-event.js&2.8.2/build/connection/connection-debug.js&2.8.2/build/logger/logger-debug.js
        

        Issue Links

          Activity

          Mark Nielsen created issue -
          Mark Nielsen made changes -
          Field Original Value New Value
          Description Each issue will be in a sub-task * When using the file picker and you have "View as List" activated, then paging doesn't work. It appears that the page number is not passed in the AJAX request, so the first page's content is always returned.
          * The default when viewing content in the repository file picker is the "View as Icons", but it doesn't initially render as "Selected" or "Highlighted". It's only after "View as List" has been selected and then "View as Icons" has been reselected.
          * When searching, should this dialog be modal? Currently you can mess around with the main file picker window when the search dialog is up.
          * The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name].
          * When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
          * The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog.
          Hide
          Dongsheng Cai added a comment -

          Adding this to stable backlog.

          Show
          Dongsheng Cai added a comment - Adding this to stable backlog.
          Dongsheng Cai made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Fix Version/s 2.0.3 [ 10537 ]
          Hide
          Michael Blake added a comment -

          Raising priority on this issue: it's been reported by a MP and should greatly improve repository usability.

          Show
          Michael Blake added a comment - Raising priority on this issue: it's been reported by a MP and should greatly improve repository usability.
          Michael Blake made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          Hide
          Mark Nielsen added a comment -

          Adding a few more discovered issues.

          Please feel free to ask about more details on any of the issues.

          Show
          Mark Nielsen added a comment - Adding a few more discovered issues. Please feel free to ask about more details on any of the issues.
          Mark Nielsen made changes -
          Description * When using the file picker and you have "View as List" activated, then paging doesn't work. It appears that the page number is not passed in the AJAX request, so the first page's content is always returned.
          * The default when viewing content in the repository file picker is the "View as Icons", but it doesn't initially render as "Selected" or "Highlighted". It's only after "View as List" has been selected and then "View as Icons" has been reselected.
          * When searching, should this dialog be modal? Currently you can mess around with the main file picker window when the search dialog is up.
          * The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name].
          * When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
          * The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog.
          * When using the file picker and you have "View as List" activated, then paging doesn't work. It appears that the page number is not passed in the AJAX request, so the first page's content is always returned.
          * The default when viewing content in the repository file picker is the "View as Icons", but it doesn't initially render as "Selected" or "Highlighted". It's only after "View as List" has been selected and then "View as Icons" has been reselected.
          * When searching, should this dialog be modal? Currently you can mess around with the main file picker window when the search dialog is up.
          * The search dialog has a hard-coded title of "filepicker", this should be something more useful, like Search or Searching in [Repository Name].
          * When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
          * The search dialog doesn't respond to the Enter or Return key being pressed. Those keys should submit the search dialog.
          * Script error displays when selecting a file while file are displayed in view as list mode in IE8. Error details:
          {noformat}
          Message: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.
          Line: 2649
          Char: 25
          Code: 0
          URI: http://yui.yahooapis.com/combo?2.8.2/build/treeview/treeview-debug.js
          {noformat}
          * (Note: might be related to above issue with pushing return/enter in search dialog) Error when enter/return key is pressed in the search dialog in IE8. Error details:
          {noformat}
          Message: Invalid argument.
          Line: 482
          Char: 4
          Code: 0
          URI: http://yui.yahooapis.com/combo?2.8.2/build/yahoo-dom-event/yahoo-dom-event.js&2.8.2/build/connection/connection-debug.js&2.8.2/build/logger/logger-debug.js
          {noformat}
          Hide
          Martin Dougiamas added a comment -

          Dongsheng can you please make some subtasks for these and tackle the low hanging fruit

          Show
          Martin Dougiamas added a comment - Dongsheng can you please make some subtasks for these and tackle the low hanging fruit
          Dongsheng Cai made changes -
          Link This issue has a non-specific relationship to MDL-23989 [ MDL-23989 ]
          Hide
          Dongsheng Cai added a comment -

          issue 5 is related to MDL-23989

          Show
          Dongsheng Cai added a comment - issue 5 is related to MDL-23989
          Hide
          Mark Nielsen added a comment -

          Thanks so much on the work on this issue thus far!!!

          I was wondering if this was going or has been addressed:

          When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.

          Show
          Mark Nielsen added a comment - Thanks so much on the work on this issue thus far!!! I was wondering if this was going or has been addressed: When selecting a file in the file picker and then going through the UI to save the file, if you then remove the file name and click Save, you get an error: "File exists". It should probably spit out an error like "File name required" and maybe do that in the save as UI instead of on post.
          Hide
          Dongsheng Cai added a comment -

          Hi Mark

          The 'file exists' issue will be fixed by MDL-26388, we already have a solution for this

          Show
          Dongsheng Cai added a comment - Hi Mark The 'file exists' issue will be fixed by MDL-26388 , we already have a solution for this
          Dongsheng Cai made changes -
          Link This issue will be resolved by MDL-26388 [ MDL-26388 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 68634 ] MDL Full Workflow [ 76132 ]
          Dongsheng Cai made changes -
          Summary Several repository bugs META - Several repository bugs
          Assignee Dongsheng Cai [ dongsheng ] moodle.com [ moodle.com ]
          Martin Dougiamas made changes -
          Link This issue will be resolved by MDL-28019 [ MDL-28019 ]
          Hide
          Michael Blake added a comment -

          MP has again flagged this issue as causing problems for their client. Please give it priority.

          Show
          Michael Blake added a comment - MP has again flagged this issue as causing problems for their client. Please give it priority.
          Michael Blake made changes -
          Labels partner
          Hide
          Dongsheng Cai added a comment -

          I will focus on those issues for next sprint.

          Show
          Dongsheng Cai added a comment - I will focus on those issues for next sprint.
          Hide
          Silverio Armani added a comment -

          Hi Dongsheng,

          Please, could you add MDL-27025 as a sub-task?

          Show
          Silverio Armani added a comment - Hi Dongsheng, Please, could you add MDL-27025 as a sub-task?
          Dongsheng Cai made changes -
          Summary META - Several repository bugs META - Several repository & file picker bugs
          Dongsheng Cai made changes -
          Link This issue has a non-specific relationship to MDL-28666 [ MDL-28666 ]
          Hide
          Dongsheng Cai added a comment -

          A lot of issues here should be fixed by MDL-31907

          Show
          Dongsheng Cai added a comment - A lot of issues here should be fixed by MDL-31907
          Dongsheng Cai made changes -
          Link This issue will be resolved by MDL-31907 [ MDL-31907 ]
          Dongsheng Cai made changes -
          Link This issue has a non-specific relationship to MDL-28666 [ MDL-28666 ]
          Dan Poltawski made changes -
          Link This issue will help resolve MDL-27178 [ MDL-27178 ]
          Dan Poltawski made changes -
          Link This issue will help resolve MDL-27725 [ MDL-27725 ]
          Hide
          Dan Poltawski added a comment -

          Hi,

          I'm closing this issue as most of the issues in subtasks have been addressed in 2.3

          I have moved the remaining 2 issues to bugs and i'm closing this issue. Thanks everyone.

          Show
          Dan Poltawski added a comment - Hi, I'm closing this issue as most of the issues in subtasks have been addressed in 2.3 I have moved the remaining 2 issues to bugs and i'm closing this issue. Thanks everyone.
          Dan Poltawski made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Assignee moodle.com [ moodle.com ] Marina Glancy [ marina ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Resolution Fixed [ 1 ]

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: