Moodle
  1. Moodle
  2. MDL-26842

replace reserved words in query params in oci driver

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Database:
      Oracle
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16812

      Description

      The problem is that oracle can not cope with reserved words in query parameters, solution is to add some funny prefix to all query param names right before the execution.

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        While this has been integrated, for the records, I don't like this way to avoid reserved words at all. It just adds one more hack to the nasty Oracle driver.

        The unique solution (IMO) about reserved words is to ban them them from codebase completely, no matter where they are used (table/column/alias/param). Reserved means reserved, here and @ Pekin.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - While this has been integrated, for the records, I don't like this way to avoid reserved words at all. It just adds one more hack to the nasty Oracle driver. The unique solution (IMO) about reserved words is to ban them them from codebase completely, no matter where they are used (table/column/alias/param). Reserved means reserved, here and @ Pekin. Ciao
        Hide
        Helen Foster added a comment -

        Thanks Petr

        Show
        Helen Foster added a comment - Thanks Petr

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: