Moodle
  1. Moodle
  2. MDL-26893

theme sky_high: right column disappears in .side-post-only layout

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Themes
    • Labels:
    • Environment:
      all browsers
    • Testing Instructions:
      Hide

      1. Before selecting Sky High in Theme Selector make sure ALL blocks are on the right-hand side (side-post).
      2. Select Sky High theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible.
      3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked?
      4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left).
      5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked.
      6. FURTHER TESTING IF TIME PERMITS: Start by going to "Sky High" Custom Settings page (Site Administration > Appearance > Themes -> CLICK the link Sky High to bring you to the custom settings page for this theme. Here you can change the width settings for both side-pre and side-post. Choose different settings. Save changes and test as per 1 to 5 above.

      Show
      1. Before selecting Sky High in Theme Selector make sure ALL blocks are on the right-hand side (side-post). 2. Select Sky High theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible. 3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked? 4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left). 5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked. 6. FURTHER TESTING IF TIME PERMITS: Start by going to "Sky High" Custom Settings page (Site Administration > Appearance > Themes -> CLICK the link Sky High to bring you to the custom settings page for this theme. Here you can change the width settings for both side-pre and side-post. Choose different settings. Save changes and test as per 1 to 5 above.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:

      Description

      As well as adding the following CSS rule to pagelayout.css

      .side-post-only #page-content #region-main-box #region-post-box #region-pre

      { left: 0; width: 0;}

      The position of right column in the file pagelayout.css must be changed from

      .side-post-only #page-content #region-main-box #region-post-box #region-post

      { left: [[setting:regionwidthdouble]]; width: [[setting:regionwidth]];}

      to

      .side-post-only #page-content #region-main-box #region-post-box #region-post

      { left: [[setting:regionwidth]]; width: [[setting:regionwidth]];}

      The "header" should be changed from

      /*********************************************************************************************

      left column: 230px
      right column: 330px
      padding left/right column: 10px
      padding center column: 30px

      **********************************************************************************************/

      to

      /*********************************************************************************************

      column width: [[setting:regionwidth]]

      **********************************************************************************************/

      In the attachment you can find my proposal for a new pagelayout.css!

        Gliffy Diagrams

        1. pagelayout.css
          4 kB
          Dietmar Wagner
        1. sky1.jpg
          17 kB
        2. sky2.jpg
          30 kB
        3. sky3.jpg
          23 kB
        4. sky4.jpg
          33 kB

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: