Moodle
  1. Moodle
  2. MDL-26894

SCORM 2004 courses trigger PHP notices, when being launched after a first completion of all LOs, which prevents e.g. IE to correctly show the content after the TOC rendering

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.0.3
    • Component/s: SCORM
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      16883

      Description

      Found on evaluating MDL-26863 and then MDL-26880.
      Note: FF correctly show the TOC and launch the item, even with the notices.

        Activity

        Hide
        Matteo Scaramuccia added a comment - - edited

        Patch proposal: https://github.com/scara/moodle/commit/36c0108a2f9f7ac6168598c3ec1d3d84bf25e9f0
        Test case:

        1. Apply MDL-26880 proposed fix, otherwise no one will be able to store any SCORM 2004 tracking data into the database;
        2. Apply the sequence of calls suggested as MDL-26880 test case, to create a completion status into the database;
        3. Enter for the second time with FF or IE: using IE, before applying the suggested patch above, will not show the content on the right

        Note: the above patch applies to vanilla Moodle code and not to a being MDL-26880 patched one. It should be dependent on that as this bug is dependent on MDL-26880: not sure if this is the right way to proceed in terms of Core Dev workflow.

        Show
        Matteo Scaramuccia added a comment - - edited Patch proposal: https://github.com/scara/moodle/commit/36c0108a2f9f7ac6168598c3ec1d3d84bf25e9f0 Test case: Apply MDL-26880 proposed fix, otherwise no one will be able to store any SCORM 2004 tracking data into the database; Apply the sequence of calls suggested as MDL-26880 test case, to create a completion status into the database; Enter for the second time with FF or IE: using IE, before applying the suggested patch above, will not show the content on the right Note: the above patch applies to vanilla Moodle code and not to a being MDL-26880 patched one. It should be dependent on that as this bug is dependent on MDL-26880 : not sure if this is the right way to proceed in terms of Core Dev workflow.
        Hide
        Dan Marsden added a comment -

        Pull request submitted - thanks Matteo

        Show
        Dan Marsden added a comment - Pull request submitted - thanks Matteo
        Hide
        Helen Foster added a comment -

        Matteo, thanks for your report and patch and Dan, thanks for fixing it. The fix is included in the latest 2.0.2+.

        Show
        Helen Foster added a comment - Matteo, thanks for your report and patch and Dan, thanks for fixing it. The fix is included in the latest 2.0.2+.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: